mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Extended loplugin:ostr: editeng

Browse Source 
Change-Id: I5dbd4047d2b66c12475020abfdd2b8f16d65a8f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159714
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
This commit is contained in:
Stephan Bergmann
2023-11-19 22:04:58 +01:00
parent 7068754492
commit c860e7cc97
4 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
editeng/source/editeng/editview.cxx
View File

@@ -535,7 +535,7 @@ void EditView::ShowCursor( bool bGotoCursor, bool bForceVisCursor, bool bActivat
static const OString aPayload = OString::boolean(true); static const OString aPayload = OString::boolean(true);
pImpEditView->mpViewShell->libreOfficeKitViewCallback(LOK_CALLBACK_CURSOR_VISIBLE, aPayload); pImpEditView->mpViewShell->libreOfficeKitViewCallback(LOK_CALLBACK_CURSOR_VISIBLE, aPayload);
pImpEditView->mpViewShell->NotifyOtherViews(LOK_CALLBACK_VIEW_CURSOR_VISIBLE, "visible", aPayload); pImpEditView->mpViewShell->NotifyOtherViews(LOK_CALLBACK_VIEW_CURSOR_VISIBLE, "visible"_ostr, aPayload);
} }
} }
@@ -553,7 +553,7 @@ void EditView::HideCursor(bool bDeactivate)
OString aPayload = OString::boolean(false); OString aPayload = OString::boolean(false);
pImpEditView->mpViewShell->libreOfficeKitViewCallback(LOK_CALLBACK_CURSOR_VISIBLE, aPayload); pImpEditView->mpViewShell->libreOfficeKitViewCallback(LOK_CALLBACK_CURSOR_VISIBLE, aPayload);
pImpEditView->mpViewShell->NotifyOtherViews(LOK_CALLBACK_VIEW_CURSOR_VISIBLE, "visible", aPayload); pImpEditView->mpViewShell->NotifyOtherViews(LOK_CALLBACK_VIEW_CURSOR_VISIBLE, "visible"_ostr, aPayload);
} }
} }

4
editeng/source/editeng/impedit.cxx
View File

@@ -439,12 +439,12 @@ void ImpEditView::lokSelectionCallback(const std::optional<tools::PolyPolygon> &
{ {
// Another shell wants to know about our existing selection. // Another shell wants to know about our existing selection.
if (mpViewShell != mpOtherShell) if (mpViewShell != mpOtherShell)
mpViewShell->NotifyOtherView(mpOtherShell, LOK_CALLBACK_TEXT_VIEW_SELECTION, "selection", sRectangle); mpViewShell->NotifyOtherView(mpOtherShell, LOK_CALLBACK_TEXT_VIEW_SELECTION, "selection"_ostr, sRectangle);
} }
else else
{ {
mpViewShell->libreOfficeKitViewCallback(LOK_CALLBACK_TEXT_SELECTION, sRectangle); mpViewShell->libreOfficeKitViewCallback(LOK_CALLBACK_TEXT_SELECTION, sRectangle);
mpViewShell->NotifyOtherViews(LOK_CALLBACK_TEXT_VIEW_SELECTION, "selection", sRectangle); mpViewShell->NotifyOtherViews(LOK_CALLBACK_TEXT_VIEW_SELECTION, "selection"_ostr, sRectangle);
} }
pOutWin->GetOutDev()->Pop(); pOutWin->GetOutDev()->Pop();

2
editeng/source/items/CustomPropertyField.cxx
View File

@@ -45,7 +45,7 @@ bool CustomPropertyField::operator==(const SvxFieldData& rOther) const
MetaAction* CustomPropertyField::createBeginComment() const MetaAction* CustomPropertyField::createBeginComment() const
{ {
return new MetaCommentAction("FIELD_SEQ_BEGIN"); return new MetaCommentAction("FIELD_SEQ_BEGIN"_ostr);
} }
OUString CustomPropertyField::GetFormatted(uno::Reference<document::XDocumentProperties> const & xDocumentProperties) OUString CustomPropertyField::GetFormatted(uno::Reference<document::XDocumentProperties> const & xDocumentProperties)

16
editeng/source/items/flditem.cxx
View File

@@ -266,12 +266,12 @@ bool SvxFieldData::operator==( const SvxFieldData& rFld ) const
MetaAction* SvxFieldData::createBeginComment() const MetaAction* SvxFieldData::createBeginComment() const
{ {
return new MetaCommentAction( "FIELD_SEQ_BEGIN" ); return new MetaCommentAction( "FIELD_SEQ_BEGIN"_ostr );
} }
MetaAction* SvxFieldData::createEndComment() MetaAction* SvxFieldData::createEndComment()
{ {
return new MetaCommentAction( "FIELD_SEQ_END" ); return new MetaCommentAction( "FIELD_SEQ_END"_ostr );
} }
@@ -428,7 +428,7 @@ OUString SvxDateField::GetFormatted( Date const & aDate, SvxDateFormat eFormat,
MetaAction* SvxDateField::createBeginComment() const MetaAction* SvxDateField::createBeginComment() const
{ {
return new MetaCommentAction( "FIELD_SEQ_BEGIN" ); return new MetaCommentAction( "FIELD_SEQ_BEGIN"_ostr );
} }
SvxURLField::SvxURLField() SvxURLField::SvxURLField()
@@ -466,7 +466,7 @@ bool SvxURLField::operator==( const SvxFieldData& rOther ) const
MetaAction* SvxURLField::createBeginComment() const MetaAction* SvxURLField::createBeginComment() const
{ {
// #i46618# Adding target URL to metafile comment // #i46618# Adding target URL to metafile comment
return new MetaCommentAction( "FIELD_SEQ_BEGIN", return new MetaCommentAction( "FIELD_SEQ_BEGIN"_ostr,
0, 0,
reinterpret_cast<const sal_uInt8*>(aURL.getStr()), reinterpret_cast<const sal_uInt8*>(aURL.getStr()),
2*aURL.getLength() ); 2*aURL.getLength() );
@@ -490,7 +490,7 @@ bool SvxPageTitleField::operator==( const SvxFieldData& rCmp ) const
MetaAction* SvxPageTitleField::createBeginComment() const MetaAction* SvxPageTitleField::createBeginComment() const
{ {
return new MetaCommentAction( "FIELD_SEQ_BEGIN;PageTitleField" ); return new MetaCommentAction( "FIELD_SEQ_BEGIN;PageTitleField"_ostr );
} }
// //
@@ -513,7 +513,7 @@ bool SvxPageField::operator==( const SvxFieldData& rCmp ) const
MetaAction* SvxPageField::createBeginComment() const MetaAction* SvxPageField::createBeginComment() const
{ {
return new MetaCommentAction( "FIELD_SEQ_BEGIN;PageField" ); return new MetaCommentAction( "FIELD_SEQ_BEGIN;PageField"_ostr );
} }
@@ -543,7 +543,7 @@ bool SvxTimeField::operator==( const SvxFieldData& rCmp ) const
MetaAction* SvxTimeField::createBeginComment() const MetaAction* SvxTimeField::createBeginComment() const
{ {
return new MetaCommentAction( "FIELD_SEQ_BEGIN" ); return new MetaCommentAction( "FIELD_SEQ_BEGIN"_ostr );
} }
SvxFileField::SvxFileField() {} SvxFileField::SvxFileField() {}
@@ -691,7 +691,7 @@ OUString SvxExtTimeField::GetFormatted( tools::Time const & aTime, SvxTimeFormat
MetaAction* SvxExtTimeField::createBeginComment() const MetaAction* SvxExtTimeField::createBeginComment() const
{ {
return new MetaCommentAction( "FIELD_SEQ_BEGIN" ); return new MetaCommentAction( "FIELD_SEQ_BEGIN"_ostr );
} }