mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

clang-tidy: performance-unnecessary-copy-initialization in basic

Browse Source 
Change-Id: I38bc2711bdec2bdaf998401083ff9b62a5595616
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176389
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2024-11-11 11:14:54 +02:00
parent f59d4e4e3e
commit cc70c63f8f
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
basic/source/classes/sbunoobj.cxx
View File

@@ -1842,7 +1842,7 @@ static OUString Impl_DumpProperties(SbUnoObject& rUnoObj)
Reference< XIntrospectionAccess > xAccess = rUnoObj.getIntrospectionAccess(); Reference< XIntrospectionAccess > xAccess = rUnoObj.getIntrospectionAccess();
if( !xAccess.is() ) if( !xAccess.is() )
{ {
Reference< XInvocation > xInvok = rUnoObj.getInvocation(); const Reference< XInvocation >& xInvok = rUnoObj.getInvocation();
if( xInvok.is() ) if( xInvok.is() )
xAccess = xInvok->getIntrospection(); xAccess = xInvok->getIntrospection();
} }
@@ -1916,7 +1916,7 @@ static OUString Impl_DumpMethods(SbUnoObject& rUnoObj)
Reference< XIntrospectionAccess > xAccess = rUnoObj.getIntrospectionAccess(); Reference< XIntrospectionAccess > xAccess = rUnoObj.getIntrospectionAccess();
if( !xAccess.is() ) if( !xAccess.is() )
{ {
Reference< XInvocation > xInvok = rUnoObj.getInvocation(); const Reference< XInvocation >& xInvok = rUnoObj.getInvocation();
if( xInvok.is() ) if( xInvok.is() )
xAccess = xInvok->getIntrospection(); xAccess = xInvok->getIntrospection();
} }

4
basic/source/classes/sbxmod.cxx
View File

@@ -857,13 +857,13 @@ void SbModule::SetSource32( const OUString& r )
sal_uInt16 nLine1 = aTok.GetLine(); sal_uInt16 nLine1 = aTok.GetLine();
if( aTok.Next() == SYMBOL ) if( aTok.Next() == SYMBOL )
{ {
OUString aName_( aTok.GetSym() ); const OUString& rName_( aTok.GetSym() );
SbxDataType t = aTok.GetType(); SbxDataType t = aTok.GetType();
if( t == SbxVARIANT && eEndTok == ENDSUB ) if( t == SbxVARIANT && eEndTok == ENDSUB )
{ {
t = SbxVOID; t = SbxVOID;
} }
pMeth = GetMethod( aName_, t ); pMeth = GetMethod( rName_, t );
pMeth->nLine1 = pMeth->nLine2 = nLine1; pMeth->nLine1 = pMeth->nLine2 = nLine1;
// The method is for a start VALID // The method is for a start VALID
pMeth->bInvalid = false; pMeth->bInvalid = false;