mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Related: tdf#82998 don't emit an Indeterminate state change for boxes

Browse Source 
Emitting object:state-changed:indeterminate is appropriate for things like
tri-state checkboxes when the state is neither fully checked nor fully
unchecked. ... jdiggs think that this event doesn't make sense in this instance
for any platform's accessibility API

Change-Id: Id8288522a825ad7ff61524ad4f225a79c015bb8f
This commit is contained in:
Caolán McNamara
2015-04-03 14:10:24 +01:00
parent db41e27474
commit ccaeafab70
1 changed files with 2 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
accessibility/source/standard/vclxaccessiblebox.cxx
View File

@@ -113,9 +113,8 @@ void VCLXAccessibleBox::ProcessWindowEvent (const VclWindowEvent& rVclWindowEven
case VCLEVENT_DROPDOWN_SELECT: case VCLEVENT_DROPDOWN_SELECT:
case VCLEVENT_LISTBOX_SELECT: case VCLEVENT_LISTBOX_SELECT:
case VCLEVENT_LISTBOX_FOCUSITEMCHANGED: case VCLEVENT_LISTBOX_FOCUSITEMCHANGED:
{ {
// Forward the call to the list child. // Forward the call to the list child.
VCLXAccessibleList* pList = static_cast<VCLXAccessibleList*>(m_xList.get()); VCLXAccessibleList* pList = static_cast<VCLXAccessibleList*>(m_xList.get());
if ( pList == NULL ) if ( pList == NULL )
{ {
@@ -125,14 +124,9 @@ void VCLXAccessibleBox::ProcessWindowEvent (const VclWindowEvent& rVclWindowEven
if ( pList != NULL ) if ( pList != NULL )
{ {
pList->ProcessWindowEvent (rVclWindowEvent, m_bIsDropDownBox); pList->ProcessWindowEvent (rVclWindowEvent, m_bIsDropDownBox);
if(m_bIsDropDownBox) if (m_bIsDropDownBox)
{ {
NotifyAccessibleEvent(AccessibleEventId::VALUE_CHANGED, Any(), Any()); NotifyAccessibleEvent(AccessibleEventId::VALUE_CHANGED, Any(), Any());
Any aOldValue;
Any aNewValue;
aOldValue <<= AccessibleStateType::INDETERMINATE;
NotifyAccessibleEvent(AccessibleEventId::STATE_CHANGED, aOldValue, aNewValue);
} }
} }
break; break;
@@ -187,12 +181,6 @@ void VCLXAccessibleBox::ProcessWindowEvent (const VclWindowEvent& rVclWindowEven
pList->UpdateSelection_Acc(sText, m_bIsDropDownBox); pList->UpdateSelection_Acc(sText, m_bIsDropDownBox);
if (m_bIsDropDownBox || ( !m_bIsDropDownBox && m_aBoxType==COMBOBOX)) if (m_bIsDropDownBox || ( !m_bIsDropDownBox && m_aBoxType==COMBOBOX))
NotifyAccessibleEvent(AccessibleEventId::VALUE_CHANGED, Any(), Any()); NotifyAccessibleEvent(AccessibleEventId::VALUE_CHANGED, Any(), Any());
Any aOldValue;
Any aNewValue;
aOldValue <<= AccessibleStateType::INDETERMINATE;
NotifyAccessibleEvent(AccessibleEventId::STATE_CHANGED, aOldValue, aNewValue);
} }
} }
break; break;