diff --git a/framework/source/dispatch/windowcommanddispatch.cxx b/framework/source/dispatch/windowcommanddispatch.cxx index 7f961e798204..69205499dcee 100644 --- a/framework/source/dispatch/windowcommanddispatch.cxx +++ b/framework/source/dispatch/windowcommanddispatch.cxx @@ -114,16 +114,16 @@ IMPL_LINK(WindowCommandDispatch, impl_notifyCommand, void*, pParam) if ( ! pData) return 0L; - const int nCommand = pData->GetDialogId(); + const ShowDialogId nCommand = pData->GetDialogId(); OUString sCommand; switch (nCommand) { - case SHOWDIALOG_ID_PREFERENCES : + case ShowDialogId::Preferences : sCommand = ".uno:OptionsTreeDialog"; break; - case SHOWDIALOG_ID_ABOUT : + case ShowDialogId::About : sCommand = ".uno:About"; break; diff --git a/include/vcl/cmdevt.hxx b/include/vcl/cmdevt.hxx index 942d45bb443a..fd308eb829ed 100644 --- a/include/vcl/cmdevt.hxx +++ b/include/vcl/cmdevt.hxx @@ -253,21 +253,24 @@ inline CommandModKeyData::CommandModKeyData( sal_uInt16 nCode ) } -// - CommanDialogData - +// - CommandDialogData - -#define SHOWDIALOG_ID_PREFERENCES 1 -#define SHOWDIALOG_ID_ABOUT 2 +enum class ShowDialogId +{ + Preferences = 1, + About = 2, +}; class VCL_DLLPUBLIC CommandDialogData { - int m_nDialogId; - public: - CommandDialogData( int nDialogId = SHOWDIALOG_ID_PREFERENCES ) + ShowDialogId m_nDialogId; +public: + CommandDialogData( ShowDialogId nDialogId = ShowDialogId::Preferences ) : m_nDialogId( nDialogId ) {} - int GetDialogId() const { return m_nDialogId; } + ShowDialogId GetDialogId() const { return m_nDialogId; } }; // Media Commands diff --git a/vcl/osx/salmenu.cxx b/vcl/osx/salmenu.cxx index b1e652e344b9..61e7b766dad6 100644 --- a/vcl/osx/salmenu.cxx +++ b/vcl/osx/salmenu.cxx @@ -44,13 +44,13 @@ const AquaSalMenu* AquaSalMenu::pCurrentMenuBar = NULL; @interface MainMenuSelector : NSObject { } --(void)showDialog: (int)nDialog; +-(void)showDialog: (ShowDialogId)nDialog; -(void)showPreferences: (id)sender; -(void)showAbout: (id)sender; @end @implementation MainMenuSelector --(void)showDialog: (int)nDialog +-(void)showDialog: (ShowDialogId)nDialog { if( AquaSalMenu::pCurrentMenuBar ) { @@ -63,9 +63,9 @@ const AquaSalMenu* AquaSalMenu::pCurrentMenuBar = NULL; else { OUString aDialog; - if( nDialog == SHOWDIALOG_ID_ABOUT ) + if( nDialog == ShowDialogId::About ) aDialog = "ABOUT"; - else if( nDialog == SHOWDIALOG_ID_PREFERENCES ) + else if( nDialog == ShowDialogId::Preferences ) aDialog = "PREFERENCES"; const ApplicationEvent* pAppEvent = new ApplicationEvent( ApplicationEvent::TYPE_SHOWDIALOG, aDialog); @@ -78,14 +78,14 @@ const AquaSalMenu* AquaSalMenu::pCurrentMenuBar = NULL; (void)sender; YIELD_GUARD; - [self showDialog: SHOWDIALOG_ID_PREFERENCES]; + [self showDialog: ShowDialogId::Preferences]; } -(void)showAbout: (id) sender { (void)sender; YIELD_GUARD; - [self showDialog: SHOWDIALOG_ID_ABOUT]; + [self showDialog: ShowDialogId::About]; } @end diff --git a/vcl/source/window/winproc.cxx b/vcl/source/window/winproc.cxx index 30db41410b6e..d50093edbd6d 100644 --- a/vcl/source/window/winproc.cxx +++ b/vcl/source/window/winproc.cxx @@ -2256,7 +2256,7 @@ static void ImplHandleSalExtTextInputPos( vcl::Window* pWindow, SalExtTextInputP } } -static bool ImplHandleShowDialog( vcl::Window* pWindow, int nDialogId ) +static bool ImplHandleShowDialog( vcl::Window* pWindow, ShowDialogId nDialogId ) { if( ! pWindow ) return false; @@ -2605,7 +2605,7 @@ bool ImplWindowFrameProc( vcl::Window* _pWindow, SalFrame* /*pFrame*/, break; case SALEVENT_SHOWDIALOG: { - int nDialogID = static_cast(reinterpret_cast(pEvent)); + ShowDialogId nDialogID = static_cast(reinterpret_cast(pEvent)); nRet = ImplHandleShowDialog( pWindow, nDialogID ); } break;