fix Graphic duplication in import and add GraphicMapper

When importing writerfilter, we change to oox when
importing images. This transition doesn't store any
previous contexts and all instances are reset. The
problem occurs when we have identical images because
the transition erases all caches we have to determine
if an image has already been imported or not, which
causes that we import the same image multiple times
which create unnecessary copies.

This introduces the XGraphicMapper, which can be used
to store the XGraphic for a key and can be transferred
between writerfilter to oox. With this we can remember
which images were already imported and don't create
unnecessary internal copies which decreases memory.

This also includes a test which checks that the import
and export doesn't produce unnecessary copies of
identical images. The test checks that for OOXML, ODF
and MS Binary formats.

Change-Id: I33dc19218c565937fab77e132b3a996c51358b6e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103283
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

include/oox/helper/graphichelper.hxx

@@ -31,6 +31,7 @@
 #include <rtl/ustring.hxx>
 #include <sal/types.h>
 #include <com/sun/star/graphic/XGraphicProvider2.hpp>
+#include <com/sun/star/graphic/XGraphicMapper.hpp>
 
 struct WmfExternal;
 
@@ -133,9 +134,10 @@ public:
         @return The original Graphic size in 100thmm */
     css::awt::Size getOriginalSize( const css::uno::Reference< css::graphic::XGraphic >& rxGraphic ) const;
 
+    void setGraphicMapper(css::uno::Reference<css::graphic::XGraphicMapper> const & rxGraphicMapper);
 
+    void initializeGraphicMapperIfNeeded() const;
 private:
-    typedef ::std::map< OUString, css::uno::Reference< css::graphic::XGraphic > > EmbeddedGraphicMap;
 
     css::uno::Reference< css::uno::XComponentContext > mxContext;
     css::uno::Reference< css::graphic::XGraphicProvider2 > mxGraphicProvider;
@@ -143,9 +145,9 @@ private:
     css::awt::DeviceInfo maDeviceInfo; ///< Current output device info.
     ::std::map< sal_Int32, ::Color >  maSystemPalette;  ///< Maps system colors (XML tokens) to RGB color values.
     StorageRef          mxStorage;                  ///< Storage containing embedded graphics.
-    mutable EmbeddedGraphicMap maEmbeddedGraphics;  ///< Maps all embedded graphics by their storage path.
     double              mfPixelPerHmmX;             ///< Number of screen pixels per 1/100 mm in X direction.
     double              mfPixelPerHmmY;             ///< Number of screen pixels per 1/100 mm in Y direction.
+    css::uno::Reference<css::graphic::XGraphicMapper> mxGraphicMapper;
 };
 
 

include/oox/shape/ShapeFilterBase.hxx

@@ -25,6 +25,7 @@
 #include <oox/vml/vmldrawing.hxx>
 #include <oox/core/xmlfilterbase.hxx>
 #include <oox/drawingml/drawingmltypes.hxx>
+#include <com/sun/star/graphic/XGraphicMapper.hpp>
 
 namespace oox::drawingml::table {
 
@@ -66,6 +67,11 @@ public:
 
     void importTheme();
 
+    void setGraphicMapper(css::uno::Reference<css::graphic::XGraphicMapper> const & rxGraphicMapper)
+    {
+        mxGraphicMapper = rxGraphicMapper;
+    }
+
 private:
     virtual ::oox::ole::VbaProject* implCreateVbaProject() const override;
     virtual OUString SAL_CALL getImplementationName() override;
@@ -73,6 +79,7 @@ private:
 
     std::shared_ptr< ::oox::drawingml::chart::ChartConverter > mxChartConv;
     ::oox::drawingml::ThemePtr mpTheme;
+    css::uno::Reference<css::graphic::XGraphicMapper> mxGraphicMapper;
 };
 
 } // namespace oox::shape

offapi/UnoApi_offapi.mk

@@ -210,6 +210,7 @@ $(eval $(call gb_UnoApi_add_idlfiles_nohdl,offapi,com/sun/star/frame,\
 $(eval $(call gb_UnoApi_add_idlfiles_nohdl,offapi,com/sun/star/graphic,\
 	GraphicObject \
 	GraphicProvider \
+	GraphicMapper \
 	Primitive2DTools \
 	SvgTools \
 	EmfTools \
@@ -2719,6 +2720,7 @@ $(eval $(call gb_UnoApi_add_idlfiles,offapi,com/sun/star/graphic,\
 	XGraphicRasterizer \
 	XGraphicRenderer \
 	XGraphicTransformer \
+	XGraphicMapper \
 	XPrimitive2D \
 	XPrimitive2DRenderer \
 	XPrimitive3D \

offapi/com/sun/star/graphic/GraphicMapper.idl

@@ -0,0 +1,30 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ */
+
+#ifndef com_sun_star_graphic_GraphicMapper_idl
+#define com_sun_star_graphic_GraphicMapper_idl
+
+#include <com/sun/star/graphic/XGraphicMapper.idl>
+
+module com { module sun { module star { module graphic
+{
+
+/** implementation of the XGraphicMapper interface
+
+    @see XGraphicMapper
+    @since LibreOffice 7.1
+*/
+service GraphicMapper : XGraphicMapper;
+
+} ; } ; } ; } ;
+
+#endif
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */

offapi/com/sun/star/graphic/XGraphicMapper.idl

@@ -0,0 +1,35 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#ifndef com_sun_star_graphic_XGraphicCache_idl
+#define com_sun_star_graphic_XGraphicCache_idl
+
+#include <com/sun/star/graphic/XGraphic.idl>
+
+module com { module sun { module star { module graphic
+{
+
+/** This interface allows mapping of XGraphics for a certain string key
+
+    @since LibreOffice 7.1
+ */
+interface XGraphicMapper
+{
+    /** Find if we have the XGraphic for the certain key */
+    com::sun::star::graphic::XGraphic findGraphic([in] string Id);
+
+    /** Insert a new entry to map an id/key to the XGraphic */
+    void putGraphic([in] string Id, [in] com::sun::star::graphic::XGraphic Graphic);
+};
+
+}; }; }; };
+
+#endif
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */

offapi/com/sun/star/xml/sax/XFastShapeContextHandler.idl

@@ -1,4 +1,4 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+ /* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
 /*
  * This file is part of the LibreOffice project.
  *
@@ -25,7 +25,7 @@
 #include <com/sun/star/frame/XModel.idl>
 #include <com/sun/star/io/XInputStream.idl>
 #include <com/sun/star/document/XDocumentProperties.idl>
-
+#include <com/sun/star/graphic/XGraphicMapper.idl>
 
 module com {  module sun {  module star {  module xml {  module sax {
 
@@ -45,6 +45,13 @@ interface XFastShapeContextHandler: com::sun::star::xml::sax::XFastContextHandle
     [attribute] com::sun::star::awt::Point Position;
     [attribute] com::sun::star::document::XDocumentProperties DocumentProperties;
     [attribute] sequence< com::sun::star::beans::PropertyValue > MediaDescriptor;
+
+    /** Graphic mapper to map a key/id string to a XGraphic. This is needed to
+        remember for XGraphics for a path in the document storage
+
+        @since LibreOffice 7.1
+     */
+    void setGraphicMapper([in] com::sun::star::graphic::XGraphicMapper xGraphicMapper);
 };
 
 

oox/source/helper/graphichelper.cxx

@@ -27,6 +27,7 @@
 #include <com/sun/star/frame/Desktop.hpp>
 #include <com/sun/star/graphic/GraphicProvider.hpp>
 #include <com/sun/star/util/MeasureUnit.hpp>
+#include <com/sun/star/graphic/GraphicMapper.hpp>
 #include <osl/diagnose.h>
 #include <sal/log.hxx>
 #include <comphelper/seqstream.hxx>
@@ -316,16 +317,24 @@ void GraphicHelper::importEmbeddedGraphics(const std::vector<OUString>& rStreamN
     std::vector<OUString> aMissingStreamNames;
     std::vector< uno::Reference<io::XInputStream> > aMissingStreams;
 
+    initializeGraphicMapperIfNeeded();
+
+    SAL_WARN_IF(!mxGraphicMapper.is(), "oox", "GraphicHelper::importEmbeddedGraphic - graphic mapper not available");
+
     for (const auto& rStreamName : rStreamNames)
     {
-        if(rStreamName.isEmpty())
+
+        if (rStreamName.isEmpty())
         {
             SAL_WARN("oox", "GraphicHelper::importEmbeddedGraphics - empty stream name");
             continue;
         }
 
-        EmbeddedGraphicMap::const_iterator aIt = maEmbeddedGraphics.find(rStreamName);
+        Reference<XGraphic> xGraphic;
-        if (aIt == maEmbeddedGraphics.end())
+
+        xGraphic = mxGraphicMapper->findGraphic(rStreamName);
+
+        if (!xGraphic.is())
         {
             aMissingStreamNames.push_back(rStreamName);
             aMissingStreams.push_back(mxStorage->openInputStream(rStreamName));
@@ -334,11 +343,14 @@ void GraphicHelper::importEmbeddedGraphics(const std::vector<OUString>& rStreamN
 
     std::vector< uno::Reference<graphic::XGraphic> > aGraphics = importGraphics(aMissingStreams);
 
+
     assert(aGraphics.size() == aMissingStreamNames.size());
     for (size_t i = 0; i < aGraphics.size(); ++i)
     {
         if (aGraphics[i].is())
-            maEmbeddedGraphics[aMissingStreamNames[i]] = aGraphics[i];
+        {
+            mxGraphicMapper->putGraphic(aMissingStreamNames[i], aGraphics[i]);
+        }
     }
 }
 
@@ -346,22 +358,26 @@ Reference< XGraphic > GraphicHelper::importEmbeddedGraphic( const OUString& rStr
 {
     Reference< XGraphic > xGraphic;
     OSL_ENSURE( !rStreamName.isEmpty(), "GraphicHelper::importEmbeddedGraphic - empty stream name" );
+
     if( !rStreamName.isEmpty() )
     {
-        EmbeddedGraphicMap::const_iterator aIt = maEmbeddedGraphics.find( rStreamName );
+        initializeGraphicMapperIfNeeded();
-        if( aIt == maEmbeddedGraphics.end() )
+
+        SAL_WARN_IF(!mxGraphicMapper.is(), "oox", "GraphicHelper::importEmbeddedGraphic - graphic mapper not available");
+
+        xGraphic = mxGraphicMapper->findGraphic(rStreamName);
+        if (!xGraphic.is())
         {
             // Lazy-loading doesn't work with TIFF or WMF at the moment.
             WmfExternal aHeader;
             if ( (rStreamName.endsWith(".tiff") || rStreamName.endsWith(".wmf") ) && !pExtHeader)
                 pExtHeader = &aHeader;
 
-            xGraphic = importGraphic(mxStorage->openInputStream(rStreamName), pExtHeader);
+            auto xStream = mxStorage->openInputStream(rStreamName);
-            if( xGraphic.is() )
+            xGraphic = importGraphic(xStream, pExtHeader);
-                maEmbeddedGraphics[ rStreamName ] = xGraphic;
+            if (xGraphic.is())
+                mxGraphicMapper->putGraphic(rStreamName, xGraphic);
         }
-        else
-            xGraphic = aIt->second;
     }
     return xGraphic;
 }
@@ -379,6 +395,20 @@ awt::Size GraphicHelper::getOriginalSize( const Reference< XGraphic >& xGraphic
     return aSizeHmm;
 }
 
+void GraphicHelper::setGraphicMapper(css::uno::Reference<css::graphic::XGraphicMapper> const & rGraphicMapper)
+{
+    mxGraphicMapper = rGraphicMapper;
+}
+
+void GraphicHelper::initializeGraphicMapperIfNeeded() const
+{
+    if (!mxGraphicMapper.is())
+    {
+        auto* pNonConstThis = const_cast<GraphicHelper*>(this);
+        pNonConstThis->mxGraphicMapper = graphic::GraphicMapper::create(mxContext);
+    }
+}
+
 } // namespace oox
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */

oox/source/shape/ShapeContextHandler.cxx

@@ -593,6 +593,12 @@ void SAL_CALL ShapeContextHandler::setMediaDescriptor(const uno::Sequence<beans:
     maMediaDescriptor = rMediaDescriptor;
 }
 
+void SAL_CALL ShapeContextHandler::setGraphicMapper(css::uno::Reference<css::graphic::XGraphicMapper> const & rxGraphicMapper)
+{
+    auto pShapeFilterBase = static_cast<ShapeFilterBase*>(mxFilterBase.get());
+    pShapeFilterBase->setGraphicMapper(rxGraphicMapper);
+}
+
 OUString ShapeContextHandler::getImplementationName()
 {
     return "com.sun.star.comp.oox.ShapeContextHandler";

oox/source/shape/ShapeContextHandler.hxx

@@ -119,6 +119,8 @@ public:
     virtual css::uno::Sequence<css::beans::PropertyValue> SAL_CALL getMediaDescriptor() override;
     virtual void SAL_CALL setMediaDescriptor(const css::uno::Sequence<css::beans::PropertyValue>& rMediaDescriptor) override;
 
+    void SAL_CALL setGraphicMapper(css::uno::Reference<css::graphic::XGraphicMapper> const & rGraphicMapper) override;
+
 private:
     ShapeContextHandler(ShapeContextHandler const &) = delete;
     void operator =(ShapeContextHandler const &) = delete;

oox/source/shape/ShapeFilterBase.cxx

@@ -104,7 +104,10 @@ ShapeGraphicHelper::ShapeGraphicHelper( const ShapeFilterBase& rFilter ) :
 
 GraphicHelper* ShapeFilterBase::implCreateGraphicHelper() const
 {
-    return new ShapeGraphicHelper( *this );
+    GraphicHelper* pGraphicHelper = new ShapeGraphicHelper(*this);
+    if (mxGraphicMapper.is())
+        pGraphicHelper->setGraphicMapper(mxGraphicMapper);
+    return pGraphicHelper;
 }
 
 ::Color ShapeFilterBase::getSchemeColor( sal_Int32 nToken ) const

sw/qa/extras/globalfilter/globalfilter.cxx

@@ -44,6 +44,7 @@ public:
     void testLinkedGraphicRT();
     void testImageWithSpecialID();
     void testGraphicShape();
+    void testMultipleIdenticalGraphics();
     void testCharHighlight();
     void testCharHighlightODF();
     void testCharHighlightBody();
@@ -68,6 +69,7 @@ public:
     CPPUNIT_TEST(testLinkedGraphicRT);
     CPPUNIT_TEST(testImageWithSpecialID);
     CPPUNIT_TEST(testGraphicShape);
+    CPPUNIT_TEST(testMultipleIdenticalGraphics);
     CPPUNIT_TEST(testCharHighlight);
     CPPUNIT_TEST(testCharHighlightODF);
     CPPUNIT_TEST(testMSCharBackgroundEditing);
@@ -394,6 +396,87 @@ void Test::testGraphicShape()
     }
 }
 
+namespace
+{
+
+std::vector<uno::Reference<graphic::XGraphic>>
+    lcl_getGraphics(const uno::Reference<lang::XComponent>& xComponent)
+{
+    std::vector<uno::Reference<graphic::XGraphic>> aGraphics;
+    uno::Reference<drawing::XShape> xShape;
+
+    uno::Reference<drawing::XDrawPageSupplier> xDrawPageSupplier(xComponent, uno::UNO_QUERY);
+    uno::Reference<drawing::XDrawPage> xDrawPage = xDrawPageSupplier->getDrawPage();
+    for (sal_Int32 i = 0; i < xDrawPage->getCount(); ++i)
+    {
+        uno::Reference<beans::XPropertySet> xShapeProperties(xDrawPage->getByIndex(i), uno::UNO_QUERY);
+        uno::Reference<graphic::XGraphic> xGraphic;
+        xShapeProperties->getPropertyValue("Graphic") >>= xGraphic;
+        if (xGraphic.is())
+        {
+            aGraphics.push_back(xGraphic);
+        }
+    }
+
+    return aGraphics;
+}
+
+}
+
+void Test::testMultipleIdenticalGraphics()
+{
+    // We have multiple identical graphics. When we save them we want
+    // them to be saved de-duplicated and the same should still be true
+    // after loading them again. This test check that the de-duplication
+    // works as expected.
+
+    const OUString aFilterNames[] {
+        "writer8",
+        //"Rich Text Format", // doesn't work correctly for now
+        "MS Word 97",
+        "Office Open XML Text",
+    };
+
+    for (OUString const & rFilterName : aFilterNames)
+    {
+        if (mxComponent.is())
+            mxComponent->dispose();
+
+        mxComponent = loadFromDesktop(m_directories.getURLFromSrc("/sw/qa/extras/globalfilter/data/multiple_identical_graphics.odt"), "com.sun.star.text.TextDocument");
+
+        // Export the document and import again for a check
+        utl::MediaDescriptor aMediaDescriptor;
+        aMediaDescriptor["FilterName"] <<= rFilterName;
+        utl::TempFile aTempFile;
+        aTempFile.EnableKillingFile();
+        uno::Reference<frame::XStorable> xStorable(mxComponent, uno::UNO_QUERY);
+        xStorable->storeToURL(aTempFile.GetURL(), aMediaDescriptor.getAsConstPropertyValueList());
+        mxComponent->dispose();
+
+        mxComponent = loadFromDesktop(aTempFile.GetURL(), "com.sun.star.text.TextDocument");
+
+        // Check whether graphic exported well
+        const OString sFailedMessage = OStringLiteral("Failed on filter: ") + rFilterName.toUtf8();
+        auto aGraphics = lcl_getGraphics(mxComponent);
+
+        CPPUNIT_ASSERT_EQUAL_MESSAGE(sFailedMessage.getStr(), size_t(5), aGraphics.size());
+
+        // Get all GfxLink addresses, we expect all of them to be the same
+        // indicating we use the same graphic instance for all shapes
+        std::vector<sal_Int64> aGfxLinkAddresses;
+        for (auto const & rxGraphic : aGraphics)
+        {
+            GfxLink* pLink = Graphic(rxGraphic).GetSharedGfxLink().get();
+            aGfxLinkAddresses.emplace_back(reinterpret_cast<sal_Int64>(pLink));
+        }
+
+        // Check all addresses are the same
+        bool bResult = std::equal(aGfxLinkAddresses.begin() + 1, aGfxLinkAddresses.end(), aGfxLinkAddresses.begin());
+        const OString sGraphicNotTheSameFailedMessage = OStringLiteral("Graphics not the same for filter: '") + rFilterName.toUtf8() + OStringLiteral("'");
+        CPPUNIT_ASSERT_EQUAL_MESSAGE(sGraphicNotTheSameFailedMessage.getStr(), true, bResult);
+    }
+}
+
 void Test::testCharHighlightBody()
 {
     // MS Word has two kind of character backgrounds called character shading and highlighting

vcl/Library_vcl.mk

@@ -330,6 +330,7 @@ $(eval $(call gb_Library_add_exception_objects,vcl,\
     vcl/source/graphic/grfattr \
     vcl/source/graphic/Manager \
     vcl/source/graphic/UnoGraphic \
+    vcl/source/graphic/UnoGraphicMapper \
     vcl/source/graphic/UnoGraphicDescriptor \
     vcl/source/graphic/UnoGraphicObject \
     vcl/source/graphic/UnoGraphicProvider \

vcl/source/graphic/UnoGraphicMapper.cxx

@@ -0,0 +1,87 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include <com/sun/star/uno/XComponentContext.hpp>
+#include <com/sun/star/lang/XServiceInfo.hpp>
+#include <com/sun/star/graphic/XGraphicMapper.hpp>
+#include <com/sun/star/graphic/XGraphic.hpp>
+#include <cppuhelper/implbase.hxx>
+#include <cppuhelper/supportsservice.hxx>
+#include <comphelper/unique_disposing_ptr.hxx>
+
+#include <memory>
+#include <unordered_map>
+
+using namespace css;
+
+namespace
+{
+class GraphicMapper : public cppu::WeakImplHelper<graphic::XGraphicMapper, lang::XServiceInfo>
+{
+private:
+    std::unordered_map<OUString, uno::Reference<graphic::XGraphic>> maGraphicMap;
+
+public:
+    GraphicMapper() = default;
+
+protected:
+    // XServiceInfo
+    OUString SAL_CALL getImplementationName() override
+    {
+        return "com.sun.star.comp.graphic.GraphicMapper";
+    }
+    sal_Bool SAL_CALL supportsService(const OUString& ServiceName) override
+    {
+        return cppu::supportsService(this, ServiceName);
+    }
+    css::uno::Sequence<OUString> SAL_CALL getSupportedServiceNames() override
+    {
+        return { "com.sun.star.graphic.GraphicMapper" };
+    }
+
+    // XTypeProvider
+    css::uno::Sequence<css::uno::Type> SAL_CALL getTypes() override
+    {
+        static const uno::Sequence<uno::Type> aTypes{
+            cppu::UnoType<lang::XServiceInfo>::get(), cppu::UnoType<lang::XTypeProvider>::get(),
+            cppu::UnoType<graphic::XGraphicMapper>::get()
+        };
+        return aTypes;
+    }
+    css::uno::Sequence<sal_Int8> SAL_CALL getImplementationId() override
+    {
+        return css::uno::Sequence<sal_Int8>();
+    }
+
+    // XGraphicMapper
+    css::uno::Reference<css::graphic::XGraphic> SAL_CALL findGraphic(const OUString& rId) override
+    {
+        auto aIterator = maGraphicMap.find(rId);
+
+        if (aIterator == maGraphicMap.end())
+            return css::uno::Reference<css::graphic::XGraphic>();
+
+        return aIterator->second;
+    }
+    void SAL_CALL putGraphic(const OUString& rId,
+                             css::uno::Reference<css::graphic::XGraphic> const& rGraphic) override
+    {
+        maGraphicMap.emplace(rId, rGraphic);
+    }
+};
+}
+
+extern "C" SAL_DLLPUBLIC_EXPORT css::uno::XInterface*
+com_sun_star_comp_graphic_GraphicMapper_get_implementation(css::uno::XComponentContext*,
+                                                           css::uno::Sequence<css::uno::Any> const&)
+{
+    return cppu::acquire(new GraphicMapper);
+}
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */

vcl/vcl.common.component

@@ -27,6 +27,10 @@
       constructor="com_sun_star_graphic_GraphicObject_get_implementation">
     <service name="com.sun.star.graphic.GraphicObject"/>
   </implementation>
+  <implementation name="com.sun.star.comp.graphic.GraphicMapper"
+      constructor="com_sun_star_comp_graphic_GraphicMapper_get_implementation">
+    <service name="com.sun.star.graphic.GraphicMapper"/>
+  </implementation>
   <implementation name="com.sun.star.datatransfer.MimeCntTypeFactory"
     constructor="dtrans_CMimeContentTypeFactory_get_implementation">
     <service name="com.sun.star.datatransfer.MimeContentTypeFactory"/>

writerfilter/source/ooxml/OOXMLDocumentImpl.cxx

@@ -23,6 +23,7 @@
 #include <com/sun/star/document/XDocumentPropertiesSupplier.hpp>
 #include <com/sun/star/xml/sax/SAXException.hpp>
 #include <com/sun/star/xml/dom/DocumentBuilder.hpp>
+#include <com/sun/star/graphic/GraphicMapper.hpp>
 #include <ooxml/resourceids.hxx>
 #include "OOXMLStreamImpl.hxx"
 #include "OOXMLDocumentImpl.hxx"
@@ -60,6 +61,7 @@ OOXMLDocumentImpl::OOXMLDocumentImpl(OOXMLStream::Pointer_t const & pStream, con
     , mnProgressEndPos(0)
     , m_rBaseURL(utl::MediaDescriptor(rDescriptor).getUnpackedValueOrDefault("DocumentBaseURL", OUString()))
     , maMediaDescriptor(rDescriptor)
+    , mxGraphicMapper(graphic::GraphicMapper::create(mpStream->getContext()))
 {
     pushShapeContext();
 }

writerfilter/source/ooxml/OOXMLDocumentImpl.hxx

@@ -22,6 +22,7 @@
 #include <ooxml/OOXMLDocument.hxx>
 
 #include <com/sun/star/xml/dom/XDocument.hpp>
+#include <com/sun/star/graphic/XGraphicMapper.hpp>
 
 #include "OOXMLPropertySet.hxx"
 
@@ -63,6 +64,8 @@ class OOXMLDocumentImpl : public OOXMLDocument
     /// DocumentBaseURL
     OUString m_rBaseURL;
     css::uno::Sequence<css::beans::PropertyValue> maMediaDescriptor;
+    /// Graphic mapper
+    css::uno::Reference<css::graphic::XGraphicMapper> mxGraphicMapper;
 
 private:
     void resolveFastSubStream(Stream & rStream,
@@ -134,7 +137,13 @@ public:
     bool IsSkipImages() const { return mbSkipImages; };
     OUString const& GetDocumentBaseURL() const { return m_rBaseURL; };
     const css::uno::Sequence<css::beans::PropertyValue>& getMediaDescriptor() const;
+
+    const css::uno::Reference<css::graphic::XGraphicMapper>& getGraphicMapper() const
+    {
+        return mxGraphicMapper;
+    }
 };
+
 }
 #endif // OOXML_DOCUMENT_IMPL_HXX
 

writerfilter/source/ooxml/OOXMLFastContextHandler.cxx

@@ -1670,6 +1670,11 @@ void OOXMLFastContextHandlerShape::setToken(Token_t nToken)
 
     mrShapeContext->setRelationFragmentPath(mpParserState->getTarget());
 
+    auto xGraphicMapper = getDocument()->getGraphicMapper();
+
+    if (xGraphicMapper.is())
+        mrShapeContext->setGraphicMapper(xGraphicMapper);
+
     OOXMLFastContextHandler::setToken(nToken);
 
     if (mrShapeContext.is())