diff --git a/dbaccess/uiconfig/ui/queryfilterdialog.ui b/dbaccess/uiconfig/ui/queryfilterdialog.ui index a52ea3651ba3..46164e2f503d 100644 --- a/dbaccess/uiconfig/ui/queryfilterdialog.ui +++ b/dbaccess/uiconfig/ui/queryfilterdialog.ui @@ -99,7 +99,6 @@ True False Operator - end 0 @@ -112,7 +111,6 @@ True False Field name - end 1 @@ -124,7 +122,6 @@ True False Condition - end 2 @@ -135,7 +132,7 @@ True False - True + 0 - none - @@ -150,6 +147,7 @@ True False True + 0 = <> @@ -172,7 +170,7 @@ True False - True + 0 - none - @@ -186,7 +184,7 @@ True False - True + 0 - none - @@ -201,6 +199,7 @@ True False True + 0 2 @@ -212,6 +211,7 @@ True False True + 0 2 @@ -223,7 +223,6 @@ True False Value - end 3 @@ -234,6 +233,7 @@ True True + True True @@ -245,6 +245,7 @@ True True + True True @@ -256,6 +257,7 @@ True True + True True @@ -267,7 +269,7 @@ True False - True + 0 AND OR @@ -282,7 +284,7 @@ True False - True + 0 AND OR diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx index 265a921f3f7c..b254a68cdae1 100644 --- a/vcl/unx/gtk3/gtk3gtkinst.cxx +++ b/vcl/unx/gtk3/gtk3gtkinst.cxx @@ -6398,6 +6398,7 @@ class GtkInstanceComboBox : public GtkInstanceContainer, public vcl::ISearchable private: GtkComboBox* m_pComboBox; GtkTreeModel* m_pTreeModel; + GtkCellRenderer* m_pTextRenderer; GtkMenu* m_pMenu; std::unique_ptr m_xSorter; vcl::QuickSelectionEngine m_aQuickSelectionEngine; @@ -6710,23 +6711,19 @@ public: if (!g_list_length(cells)) { //Always use the same text column renderer layout - GtkCellRenderer* text_renderer = gtk_cell_renderer_text_new(); - gtk_cell_layout_pack_end(GTK_CELL_LAYOUT(m_pComboBox), text_renderer, true); - gtk_cell_layout_set_attributes(GTK_CELL_LAYOUT(m_pComboBox), text_renderer, "text", 0, nullptr); - g_object_set(G_OBJECT(text_renderer), "ellipsize", PANGO_ELLIPSIZE_MIDDLE, nullptr); + m_pTextRenderer = gtk_cell_renderer_text_new(); + gtk_cell_layout_pack_end(GTK_CELL_LAYOUT(m_pComboBox), m_pTextRenderer, true); + gtk_cell_layout_set_attributes(GTK_CELL_LAYOUT(m_pComboBox), m_pTextRenderer, "text", 0, nullptr); } else { - // this bit isn't great, I really want to be able to ellipse the text in the comboboxtext itself and let - // the popup menu render them in full, in the interim allow the text to wrap in both cases - GtkCellRenderer* cell = static_cast(cells->data); - g_object_set(G_OBJECT(cell), "ellipsize", PANGO_ELLIPSIZE_MIDDLE, nullptr); + m_pTextRenderer = static_cast(cells->data); if (g_list_length(cells) == 2) { //The ComboBox is always going to show the column associated with //the entry when there is one, left to its own devices this image //column will be after it, but we want it before - gtk_cell_layout_reorder(GTK_CELL_LAYOUT(m_pComboBox), cell, 1); + gtk_cell_layout_reorder(GTK_CELL_LAYOUT(m_pComboBox), m_pTextRenderer, 1); } } g_list_free(cells); @@ -6773,7 +6770,18 @@ public: GtkCellRenderer* cell = static_cast(cells->data); GtkRequisition size; gtk_cell_renderer_get_preferred_size(cell, m_pWidget, &size, nullptr); - gtk_cell_renderer_set_fixed_size(cell, nWidth, size.height); + if (nWidth < size.width) + { + // this bit isn't great, I really want to be able to ellipse the text in the comboboxtext itself and let + // the popup menu render them in full, in the interim ellipse both + g_object_set(G_OBJECT(m_pTextRenderer), "ellipsize", PANGO_ELLIPSIZE_MIDDLE, nullptr); + gtk_cell_renderer_set_fixed_size(cell, nWidth, size.height); + } + else + { + g_object_set(G_OBJECT(m_pTextRenderer), "ellipsize", PANGO_ELLIPSIZE_NONE, nullptr); + gtk_cell_renderer_set_fixed_size(cell, size.width, size.height); + } g_list_free(cells); gtk_widget_set_size_request(m_pWidget, nWidth, nHeight);