mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:constparams in basctl..chart2

Browse Source 
Change-Id: I9ac9a34ba58f411d5aad235407553df63216319c
Reviewed-on: https://gerrit.libreoffice.org/66791
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2019-01-23 14:31:11 +02:00
parent d113fe7742
commit d2cf4cb762
11 changed files with 19 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
basctl/source/basicide/bastype2.cxx
View File

@@ -1319,7 +1319,7 @@ bool SbTreeListBox::FindEntry(const OUString& rText, EntryType eType, weld::Tree
return false; return false;
} }
bool SbTreeListBox::IsEntryProtected(weld::TreeIter* pEntry) bool SbTreeListBox::IsEntryProtected(const weld::TreeIter* pEntry)
{ {
bool bProtected = false; bool bProtected = false;
if (pEntry && m_xControl->get_iter_depth(*pEntry) == 1) if (pEntry && m_xControl->get_iter_depth(*pEntry) == 1)
@@ -1355,7 +1355,7 @@ void SbTreeListBox::AddEntry(
m_xControl->insert(pParent, -1, &rText, &sId, nullptr, nullptr, &rImage, bChildrenOnDemand); m_xControl->insert(pParent, -1, &rText, &sId, nullptr, nullptr, &rImage, bChildrenOnDemand);
} }
void SbTreeListBox::SetEntryBitmaps(weld::TreeIter& rIter, const OUString& rImage) void SbTreeListBox::SetEntryBitmaps(const weld::TreeIter& rIter, const OUString& rImage)
{ {
m_xControl->set_expander_image(rIter, rImage); m_xControl->set_expander_image(rIter, rImage);
} }

6
basctl/source/basicide/bastype3.cxx
View File

@@ -258,7 +258,7 @@ void SbTreeListBox::ScanAllEntries()
} }
} }
SbxVariable* SbTreeListBox::FindVariable(weld::TreeIter* pEntry) SbxVariable* SbTreeListBox::FindVariable(const weld::TreeIter* pEntry)
{ {
if ( !pEntry ) if ( !pEntry )
return nullptr; return nullptr;
@@ -449,7 +449,7 @@ EntryDescriptor TreeListBox::GetEntryDescriptor( SvTreeListEntry* pEntry )
return EntryDescriptor( aDocument, eLocation, aLibName, aLibSubName, aName, aMethodName, eType ); return EntryDescriptor( aDocument, eLocation, aLibName, aLibSubName, aName, aMethodName, eType );
} }
EntryDescriptor SbTreeListBox::GetEntryDescriptor(weld::TreeIter* pEntry) EntryDescriptor SbTreeListBox::GetEntryDescriptor(const weld::TreeIter* pEntry)
{ {
ScriptDocument aDocument( ScriptDocument::getApplicationScriptDocument() ); ScriptDocument aDocument( ScriptDocument::getApplicationScriptDocument() );
LibraryLocation eLocation = LIBRARY_LOCATION_UNKNOWN; LibraryLocation eLocation = LIBRARY_LOCATION_UNKNOWN;
@@ -691,7 +691,7 @@ bool SbTreeListBox::IsValidEntry(weld::TreeIter& rEntry)
return bIsValid; return bIsValid;
} }
SbModule* SbTreeListBox::FindModule(weld::TreeIter* pEntry) SbModule* SbTreeListBox::FindModule(const weld::TreeIter* pEntry)
{ {
return dynamic_cast<SbModule*>(FindVariable(pEntry)); return dynamic_cast<SbModule*>(FindVariable(pEntry));
} }

2
basctl/source/basicide/breakpoint.cxx
View File

@@ -125,7 +125,7 @@ void BreakPointList::ResetHitCount()
} }
} }
void BreakPointList::remove(BreakPoint* ptr) void BreakPointList::remove(const BreakPoint* ptr)
{ {
for ( auto i = maBreakPoints.begin(); i != maBreakPoints.end(); ++i ) for ( auto i = maBreakPoints.begin(); i != maBreakPoints.end(); ++i )
{ {

2
basctl/source/basicide/breakpoint.hxx
View File

@@ -72,7 +72,7 @@ public:
size_t size() const; size_t size() const;
BreakPoint& at(size_t i); BreakPoint& at(size_t i);
const BreakPoint& at(size_t i) const; const BreakPoint& at(size_t i) const;
void remove(BreakPoint* ptr); void remove(const BreakPoint* ptr);
void remove(size_t i); void remove(size_t i);
}; };

2
basctl/source/basicide/macrodlg.cxx
View File

@@ -338,7 +338,7 @@ SbMethod* MacroChooser::CreateMacro()
return pMethod; return pMethod;
} }
void MacroChooser::SaveSetCurEntry(weld::TreeView& rBox, weld::TreeIter& rEntry) void MacroChooser::SaveSetCurEntry(weld::TreeView& rBox, const weld::TreeIter& rEntry)
{ {
// the edit would be killed by the highlight otherwise: // the edit would be killed by the highlight otherwise:

2
basctl/source/basicide/macrodlg.hxx
View File

@@ -61,7 +61,7 @@ private:
DECL_LINK(ButtonHdl, weld::Button&, void); DECL_LINK(ButtonHdl, weld::Button&, void);
void CheckButtons(); void CheckButtons();
void SaveSetCurEntry(weld::TreeView& rBox, weld::TreeIter& rEntry); void SaveSetCurEntry(weld::TreeView& rBox, const weld::TreeIter& rEntry);
void UpdateFields(); void UpdateFields();
void EnableButton(weld::Button& rButton, bool bEnable); void EnableButton(weld::Button& rButton, bool bEnable);

12
basctl/source/inc/bastype2.hxx
View File

@@ -256,7 +256,7 @@ private:
weld::Window* m_pTopLevel; weld::Window* m_pTopLevel;
BrowseMode nMode; BrowseMode nMode;
DocumentEventNotifier m_aNotifier; DocumentEventNotifier m_aNotifier;
void SetEntryBitmaps(weld::TreeIter& rIter, const OUString& rImage); void SetEntryBitmaps(const weld::TreeIter& rIter, const OUString& rImage);
protected: protected:
DECL_LINK(RequestingChildrenHdl, weld::TreeIter&, bool); DECL_LINK(RequestingChildrenHdl, weld::TreeIter&, bool);
@@ -286,16 +286,16 @@ public:
void ScanAllEntries(); void ScanAllEntries();
void UpdateEntries(); void UpdateEntries();
bool IsEntryProtected(weld::TreeIter* pEntry); bool IsEntryProtected(const weld::TreeIter* pEntry);
void SetMode( BrowseMode nM ) { nMode = nM; } void SetMode( BrowseMode nM ) { nMode = nM; }
BrowseMode GetMode() const { return nMode; } BrowseMode GetMode() const { return nMode; }
SbModule* FindModule(weld::TreeIter* pEntry); SbModule* FindModule(const weld::TreeIter* pEntry);
SbxVariable* FindVariable(weld::TreeIter* pEntry); SbxVariable* FindVariable(const weld::TreeIter* pEntry);
bool FindRootEntry(const ScriptDocument& rDocument, LibraryLocation eLocation, weld::TreeIter& rIter); bool FindRootEntry(const ScriptDocument& rDocument, LibraryLocation eLocation, weld::TreeIter& rIter);
bool FindEntry(const OUString& rText, EntryType eType, weld::TreeIter& rIter); bool FindEntry(const OUString& rText, EntryType eType, weld::TreeIter& rIter);
EntryDescriptor GetEntryDescriptor(weld::TreeIter* pEntry); EntryDescriptor GetEntryDescriptor(const weld::TreeIter* pEntry);
static ItemType ConvertType (EntryType eType); static ItemType ConvertType (EntryType eType);
bool IsValidEntry(weld::TreeIter& rEntry); bool IsValidEntry(weld::TreeIter& rEntry);
@@ -303,7 +303,7 @@ public:
weld::TreeIter* pIter, bool bChildrenOnDemand, std::unique_ptr<Entry>&& rUserData); weld::TreeIter* pIter, bool bChildrenOnDemand, std::unique_ptr<Entry>&& rUserData);
void connect_changed(const Link<weld::TreeView&, void>& rLink) { m_xControl->connect_changed(rLink); } void connect_changed(const Link<weld::TreeView&, void>& rLink) { m_xControl->connect_changed(rLink); }
std::unique_ptr<weld::TreeIter> make_iterator(weld::TreeIter* pIter = nullptr) const { return m_xControl->make_iterator(pIter); } std::unique_ptr<weld::TreeIter> make_iterator(const weld::TreeIter* pIter = nullptr) const { return m_xControl->make_iterator(pIter); }
void copy_iterator(const weld::TreeIter& rSource, weld::TreeIter& rDest) const { m_xControl->copy_iterator(rSource, rDest); } void copy_iterator(const weld::TreeIter& rSource, weld::TreeIter& rDest) const { m_xControl->copy_iterator(rSource, rDest); }
bool get_selected(weld::TreeIter* pIter) const { return m_xControl->get_selected(pIter); } bool get_selected(weld::TreeIter* pIter) const { return m_xControl->get_selected(pIter); }
void select(const weld::TreeIter& rIter) { m_xControl->select(rIter); } void select(const weld::TreeIter& rIter) { m_xControl->select(rIter); }

2
basegfx/source/range/b2drangeclipper.cxx
View File

@@ -706,7 +706,7 @@ namespace basegfx
Iterator first, Iterator first,
Iterator last, Iterator last,
ListOfEdges& rActiveEdgeList, ListOfEdges& rActiveEdgeList,
SweepLineEvent& rCurrEvent, SweepLineEvent const & rCurrEvent,
VectorOfPolygons& rPolygonPool, VectorOfPolygons& rPolygonPool,
B2DPolyPolygon& rRes ) B2DPolyPolygon& rRes )
{ {

2
canvas/workben/canvasdemo.cxx
View File

@@ -155,7 +155,7 @@ class DemoRenderer
mxCanvas->drawText( aText, mxDefaultFont, maViewState, aRenderState, 0); mxCanvas->drawText( aText, mxDefaultFont, maViewState, aRenderState, 0);
} }
void drawRect( tools::Rectangle rRect, uno::Sequence< double > &aColor, int /*nWidth*/ ) void drawRect( tools::Rectangle rRect, const uno::Sequence< double > &aColor, int /*nWidth*/ )
{ {
uno::Sequence< geometry::RealPoint2D > aPoints(4); uno::Sequence< geometry::RealPoint2D > aPoints(4);
uno::Reference< rendering::XLinePolyPolygon2D > xPoly; uno::Reference< rendering::XLinePolyPolygon2D > xPoly;

2
chart2/source/controller/dialogs/tp_DataSource.cxx
View File

@@ -756,7 +756,7 @@ void DataSourceTabPage::disposingRangeSelection()
m_rDialogModel.getRangeSelectionHelper()->stopRangeListening( false ); m_rDialogModel.getRangeSelectionHelper()->stopRangeListening( false );
} }
bool DataSourceTabPage::updateModelFromControl(weld::Entry* pField) bool DataSourceTabPage::updateModelFromControl(const weld::Entry* pField)
{ {
if (!m_bIsDirty) if (!m_bIsDirty)
return true; return true;

2
chart2/source/controller/dialogs/tp_DataSource.hxx
View File

@@ -97,7 +97,7 @@ private:
<TRUE/> if the text from the field is a valid format to the internal <TRUE/> if the text from the field is a valid format to the internal
data was valid data was valid
*/ */
bool updateModelFromControl(weld::Entry* pField = nullptr); bool updateModelFromControl(const weld::Entry* pField = nullptr);
/** @return </sal_True>, if the edit field contains a valid range entry. If no /** @return </sal_True>, if the edit field contains a valid range entry. If no
XCellRangesAccess can be obtained, </sal_False> is returned. XCellRangesAccess can be obtained, </sal_False> is returned.