mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:unnecessaryvirtual

Browse Source 
Change-Id: Iec5de34f908ac370302ab51a33f17dfc23ea2446
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92834
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin 2020-04-24 08:23:42 +02:00
parent 3f38a57a4e
commit d34b6243d6
6 changed files with 14 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
compilerplugins/clang/unnecessaryvirtual-dead.results
View File

@ -8,6 +8,8 @@ canvas/inc/base/graphicdevicebase.hxx:318
void canvas::GraphicDeviceBase::removeVetoableChangeListener(const class rtl::OUString &,const class com::sun::star::uno::Reference<class com::sun::star::beans::XVetoableChangeListener> &,) void canvas::GraphicDeviceBase::removeVetoableChangeListener(const class rtl::OUString &,const class com::sun::star::uno::Reference<class com::sun::star::beans::XVetoableChangeListener> &,)
include/basegfx/utils/unopolypolygon.hxx:97 include/basegfx/utils/unopolypolygon.hxx:97
void basegfx::unotools::UnoPolyPolygon::modifying()const void basegfx::unotools::UnoPolyPolygon::modifying()const
include/vcl/lstbox.hxx:132
void ListBox::UserDraw(const class UserDrawEvent &,)
sc/source/core/opencl/formulagroupcl.cxx:1069 sc/source/core/opencl/formulagroupcl.cxx:1069
void sc::opencl::(anonymous namespace)::DynamicKernelSlidingArgument::GenSlidingWindowFunction(class std::__cxx11::basic_stringstream<char> &,) void sc::opencl::(anonymous namespace)::DynamicKernelSlidingArgument::GenSlidingWindowFunction(class std::__cxx11::basic_stringstream<char> &,)
slideshow/source/engine/animationfactory.cxx:437 slideshow/source/engine/animationfactory.cxx:437
@ -16,7 +18,7 @@ vcl/inc/salframe.hxx:145
void SalFrame::SetRepresentedURL(const class rtl::OUString &,) void SalFrame::SetRepresentedURL(const class rtl::OUString &,)
vcl/inc/salframe.hxx:264 vcl/inc/salframe.hxx:264
void SalFrame::BeginSheet(class SalFrame *,)const void SalFrame::BeginSheet(class SalFrame *,)const
vcl/inc/salinst.hxx:202 vcl/inc/salinst.hxx:203
void SalInstance::releaseMainThread() void SalInstance::releaseMainThread()
vcl/inc/salmenu.hxx:81 vcl/inc/salmenu.hxx:81
void SalMenu::RemoveMenuBarButton(unsigned short,) void SalMenu::RemoveMenuBarButton(unsigned short,)

24
compilerplugins/clang/unnecessaryvirtual.results
View File

@ -300,18 +300,12 @@ include/vbahelper/vbareturntypes.hxx:41
type-parameter-0-0 ooo::vba::DefaultReturnHelper::getValue() type-parameter-0-0 ooo::vba::DefaultReturnHelper::getValue()
include/vcl/customweld.hxx:42 include/vcl/customweld.hxx:42
class rtl::OUString weld::CustomWidgetController::GetHelpText()const class rtl::OUString weld::CustomWidgetController::GetHelpText()const
include/vcl/lstbox.hxx:135 include/vcl/lstbox.hxx:132
void ListBox::DoubleClick() void ListBox::UserDraw(const class UserDrawEvent &,)
include/vcl/treelistbox.hxx:458 include/vcl/treelistbox.hxx:686
_Bool SvTreeListBox::NotifyAcceptDrop(class SvTreeListEntry *,) _Bool SvTreeListBox::Expand(class SvTreeListEntry *,)
include/vcl/treelistbox.hxx:470 include/vcl/treelistbox.hxx:687
enum TriState SvTreeListBox::NotifyCopying(class SvTreeListEntry *,class SvTreeListEntry *,class SvTreeListEntry *&,unsigned long &,) _Bool SvTreeListBox::Collapse(class SvTreeListEntry *,)
include/vcl/treelistbox.hxx:493
class rtl::OUString SvTreeListBox::GetEntryAltText(class SvTreeListEntry *,)const
include/vcl/treelistbox.hxx:494
class rtl::OUString SvTreeListBox::GetEntryLongDescription(class SvTreeListEntry *,)const
include/vcl/treelistbox.hxx:669
long SvTreeListBox::GetTabPos(const class SvTreeListEntry *,class SvLBoxTab *,)
include/vcl/weld.hxx:103 include/vcl/weld.hxx:103
void weld::Widget::set_visible(_Bool,) void weld::Widget::set_visible(_Bool,)
sc/source/core/opencl/formulagroupcl.cxx:1061 sc/source/core/opencl/formulagroupcl.cxx:1061
@ -418,9 +412,9 @@ vcl/inc/salframe.hxx:194
void SalFrame::Flush(const class tools::Rectangle &,) void SalFrame::Flush(const class tools::Rectangle &,)
vcl/inc/salframe.hxx:264 vcl/inc/salframe.hxx:264
void SalFrame::BeginSheet(class SalFrame *,)const void SalFrame::BeginSheet(class SalFrame *,)const
vcl/inc/salinst.hxx:92 vcl/inc/salinst.hxx:93
_Bool SalInstance::SVMainHook(int *,) _Bool SalInstance::SVMainHook(int *,)
vcl/inc/salinst.hxx:202 vcl/inc/salinst.hxx:203
void SalInstance::releaseMainThread() void SalInstance::releaseMainThread()
vcl/inc/salmenu.hxx:80 vcl/inc/salmenu.hxx:80
_Bool SalMenu::AddMenuBarButton(const struct SalMenuButtonItem &,) _Bool SalMenu::AddMenuBarButton(const struct SalMenuButtonItem &,)
@ -432,7 +426,7 @@ vcl/inc/salobj.hxx:49
void SalObject::Enable(_Bool,) void SalObject::Enable(_Bool,)
vcl/inc/salprn.hxx:116 vcl/inc/salprn.hxx:116
enum SalPrinterError SalPrinter::GetErrorCode() enum SalPrinterError SalPrinter::GetErrorCode()
vcl/inc/skia/gdiimpl.hxx:222 vcl/inc/skia/gdiimpl.hxx:226
void SkiaSalGraphicsImpl::createSurface() void SkiaSalGraphicsImpl::createSurface()
vcl/inc/unx/gtk/gtkdata.hxx:121 vcl/inc/unx/gtk/gtkdata.hxx:121
int GtkSalDisplay::CaptureMouse(class SalFrame *,) int GtkSalDisplay::CaptureMouse(class SalFrame *,)

2
include/vcl/lstbox.hxx
View File

@ -101,7 +101,6 @@ private:
DECL_DLLPRIVATE_LINK( ImplDoubleClickHdl, ImplListBoxWindow*, void ); DECL_DLLPRIVATE_LINK( ImplDoubleClickHdl, ImplListBoxWindow*, void );
DECL_DLLPRIVATE_LINK( ImplPopupModeEndHdl, FloatingWindow*, void ); DECL_DLLPRIVATE_LINK( ImplPopupModeEndHdl, FloatingWindow*, void );
DECL_DLLPRIVATE_LINK( ImplSelectionChangedHdl, sal_Int32, void ); DECL_DLLPRIVATE_LINK( ImplSelectionChangedHdl, sal_Int32, void );
DECL_DLLPRIVATE_LINK( ImplUserDrawHdl, UserDrawEvent*, void );
DECL_DLLPRIVATE_LINK( ImplFocusHdl, sal_Int32, void ); DECL_DLLPRIVATE_LINK( ImplFocusHdl, sal_Int32, void );
DECL_DLLPRIVATE_LINK( ImplListItemSelectHdl, LinkParamNone*, void ); DECL_DLLPRIVATE_LINK( ImplListItemSelectHdl, LinkParamNone*, void );
@ -129,7 +128,6 @@ public:
virtual bool PreNotify( NotifyEvent& rNEvt ) override; virtual bool PreNotify( NotifyEvent& rNEvt ) override;
virtual void StateChanged( StateChangedType nType ) override; virtual void StateChanged( StateChangedType nType ) override;
virtual void DataChanged( const DataChangedEvent& rDCEvt ) override; virtual void DataChanged( const DataChangedEvent& rDCEvt ) override;
virtual void UserDraw( const UserDrawEvent& rUDEvt );
virtual void Select(); virtual void Select();
void DoubleClick(); void DoubleClick();

4
include/vcl/treelistbox.hxx
View File

@ -683,8 +683,8 @@ public:
void SetDragDropMode( DragDropMode ); void SetDragDropMode( DragDropMode );
void SetSelectionMode( SelectionMode ); void SetSelectionMode( SelectionMode );
virtual bool Expand( SvTreeListEntry* pParent ); bool Expand( SvTreeListEntry* pParent );
virtual bool Collapse( SvTreeListEntry* pParent ); bool Collapse( SvTreeListEntry* pParent );
virtual bool Select( SvTreeListEntry* pEntry, bool bSelect=true ); virtual bool Select( SvTreeListEntry* pEntry, bool bSelect=true );
sal_uLong SelectChildren( SvTreeListEntry* pParent, bool bSelect ); sal_uLong SelectChildren( SvTreeListEntry* pParent, bool bSelect );
void SelectAll( bool bSelect ); void SelectAll( bool bSelect );

1
vcl/inc/listbox.hxx
View File

@ -579,7 +579,6 @@ public:
void SetImage( const Image& rImg ) { maImage = rImg; } void SetImage( const Image& rImg ) { maImage = rImg; }
void SetMBDownHdl( const Link<void*,void>& rLink ) { maMBDownHdl = rLink; } void SetMBDownHdl( const Link<void*,void>& rLink ) { maMBDownHdl = rLink; }
void SetUserDrawHdl( const Link<UserDrawEvent*, void>& rLink ) { maUserDrawHdl = rLink; }
void EnableUserDraw( bool bUserDraw ) { mbUserDrawEnabled = bUserDraw; } void EnableUserDraw( bool bUserDraw ) { mbUserDrawEnabled = bUserDraw; }
bool IsUserDrawEnabled() const { return mbUserDrawEnabled; } bool IsUserDrawEnabled() const { return mbUserDrawEnabled; }

11
vcl/source/control/listbox.cxx
View File

@ -118,7 +118,6 @@ void ListBox::ImplInit( vcl::Window* pParent, WinBits nStyle )
mpImplWin = VclPtr<ImplWin>::Create( this, (nStyle & (WB_LEFT|WB_RIGHT|WB_CENTER))|WB_NOBORDER ); mpImplWin = VclPtr<ImplWin>::Create( this, (nStyle & (WB_LEFT|WB_RIGHT|WB_CENTER))|WB_NOBORDER );
mpImplWin->SetMBDownHdl( LINK( this, ListBox, ImplClickBtnHdl ) ); mpImplWin->SetMBDownHdl( LINK( this, ListBox, ImplClickBtnHdl ) );
mpImplWin->SetUserDrawHdl( LINK( this, ListBox, ImplUserDrawHdl ) );
mpImplWin->Show(); mpImplWin->Show();
mpImplWin->GetDropTarget()->addDropTargetListener(xDrop); mpImplWin->GetDropTarget()->addDropTargetListener(xDrop);
mpImplWin->SetEdgeBlending(false); mpImplWin->SetEdgeBlending(false);
@ -138,7 +137,6 @@ void ListBox::ImplInit( vcl::Window* pParent, WinBits nStyle )
mpImplLB->SetScrollHdl( LINK( this, ListBox, ImplScrollHdl ) ); mpImplLB->SetScrollHdl( LINK( this, ListBox, ImplScrollHdl ) );
mpImplLB->SetCancelHdl( LINK( this, ListBox, ImplCancelHdl ) ); mpImplLB->SetCancelHdl( LINK( this, ListBox, ImplCancelHdl ) );
mpImplLB->SetDoubleClickHdl( LINK( this, ListBox, ImplDoubleClickHdl ) ); mpImplLB->SetDoubleClickHdl( LINK( this, ListBox, ImplDoubleClickHdl ) );
mpImplLB->SetUserDrawHdl( LINK( this, ListBox, ImplUserDrawHdl ) );
mpImplLB->SetFocusHdl( LINK( this, ListBox, ImplFocusHdl ) ); mpImplLB->SetFocusHdl( LINK( this, ListBox, ImplFocusHdl ) );
mpImplLB->SetListItemSelectHdl( LINK( this, ListBox, ImplListItemSelectHdl ) ); mpImplLB->SetListItemSelectHdl( LINK( this, ListBox, ImplListItemSelectHdl ) );
mpImplLB->SetPosPixel( Point() ); mpImplLB->SetPosPixel( Point() );
@ -1319,15 +1317,6 @@ void ListBox::GetMaxVisColumnsAndLines( sal_uInt16& rnCols, sal_uInt16& rnLines
} }
} }
IMPL_LINK( ListBox, ImplUserDrawHdl, UserDrawEvent*, pEvent, void )
{
UserDraw( *pEvent );
}
void ListBox::UserDraw( const UserDrawEvent& )
{
}
void ListBox::SetReadOnly( bool bReadOnly ) void ListBox::SetReadOnly( bool bReadOnly )
{ {
if ( mpImplLB->IsReadOnly() != bReadOnly ) if ( mpImplLB->IsReadOnly() != bReadOnly )