mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tighten up the check a little more

Browse Source 
Change-Id: Ic19364d2daa064a20da0ed9d9641f1646d8f6ce3
This commit is contained in:
Noel Grandin
2017-05-16 09:39:23 +02:00
parent d67747c59c
commit d39717a6d6
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
compilerplugins/clang/unusedfields.cxx
View File

@@ -188,6 +188,10 @@ static char easytolower(char in)
return in-('Z'-'z');
return in;
}
bool startswith(const std::string& rStr, const char* pSubStr)
{
return rStr.compare(0, strlen(pSubStr), pSubStr) == 0;
}
bool UnusedFields::VisitMemberExpr( const MemberExpr* memberExpr )
{
@@ -248,11 +252,11 @@ bool UnusedFields::VisitMemberExpr( const MemberExpr* memberExpr )
{
// check for calls to ReadXXX() type methods and the operator>>= methods on Any.
const FunctionDecl * calleeFunctionDecl = callExpr->getDirectCallee();
if (calleeFunctionDecl)
if (calleeFunctionDecl && calleeFunctionDecl->getIdentifier())
{
std::string name = calleeFunctionDecl->getQualifiedNameAsString();
std::string name = calleeFunctionDecl->getNameAsString();
std::transform(name.begin(), name.end(), name.begin(), easytolower);
if (name.find("read") != std::string::npos || name.find(">>=") != std::string::npos)
if (startswith(name, "read") || name.find(">>=") != std::string::npos)
// this is a write-only call
;
else