From d5903802e2c40d6fccbc322c49b5f9a311551b9b Mon Sep 17 00:00:00 2001 From: Mohammed Abdul Azeem Date: Sun, 25 Mar 2018 12:50:34 +0530 Subject: [PATCH] tdf#116467: fix for SVG files being imported as blank Any SAX-to-SAX transformation, like in this case should use SvXMLLegacyToFastDocHandler on the left end, as right end of the pipe is moved to fast Contexts. Used delegating constructor here, since m_xDocumentHandler is constant in SVGReader class. Change-Id: I1fc841c96aaa618f0b566fdb0301ad48fd869f1c Reviewed-on: https://gerrit.libreoffice.org/51815 Tested-by: Jenkins Reviewed-by: Michael Meeks --- filter/inc/svgreader.hxx | 7 +++++++ filter/source/svg/svgreader.cxx | 10 +++++++++- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/filter/inc/svgreader.hxx b/filter/inc/svgreader.hxx index 29ff6ab4d7e9..3149e1770158 100644 --- a/filter/inc/svgreader.hxx +++ b/filter/inc/svgreader.hxx @@ -15,16 +15,23 @@ #include #include #include +#include namespace svgi { class SVGReader { +private: const css::uno::Reference< css::uno::XComponentContext > m_xContext; const css::uno::Reference< css::io::XInputStream > m_xInputStream; const css::uno::Reference< css::xml::sax::XDocumentHandler > m_xDocumentHandler; + SVGReader( const css::uno::Reference& xContext, + const css::uno::Reference< css::io::XInputStream >& xInputStream, + const css::uno::Reference< css::xml::sax::XDocumentHandler >& xDocumentHandler, + SvXMLImport *pFastHandler); + public: FILTER_DLLPUBLIC SVGReader( const css::uno::Reference& xContext, const css::uno::Reference< css::io::XInputStream >& xInputStream, diff --git a/filter/source/svg/svgreader.cxx b/filter/source/svg/svgreader.cxx index 5227bd072b50..bc78d0cce10a 100644 --- a/filter/source/svg/svgreader.cxx +++ b/filter/source/svg/svgreader.cxx @@ -2081,9 +2081,17 @@ static void dumpTree( const uno::Reference xElem ) SVGReader::SVGReader(const uno::Reference& xContext, const uno::Reference& xInputStream, const uno::Reference& xDocumentHandler) : + SVGReader(xContext, xInputStream, xDocumentHandler, dynamic_cast(xDocumentHandler.get())) +{ +} + +SVGReader::SVGReader(const uno::Reference& xContext, + const uno::Reference& xInputStream, + const uno::Reference& xDocumentHandler, + SvXMLImport *pFastHandler) : m_xContext( xContext ), m_xInputStream( xInputStream ), - m_xDocumentHandler( xDocumentHandler ) + m_xDocumentHandler( pFastHandler != nullptr ? new SvXMLLegacyToFastDocHandler(pFastHandler) : xDocumentHandler ) { }