From d65ccee2917baadbc1ebf85e61107cfdfcc159cf Mon Sep 17 00:00:00 2001 From: Eike Rathke Date: Tue, 27 Aug 2024 19:12:32 +0200 Subject: [PATCH] Related: tdf#161599 ChildAccess::asValue() must return Reference ... otherwise the unotools/source/config/configitem.cxx ConfigItem::impl_packLocalizedProperties() checking for (getValueTypeName() == "com.sun.star.uno.XInterface") would not hit and thus not pack the properties, returning just the useless XWeak pointer as property. This in ScUnoAddInCollection::ReadConfiguration() lead to English names not being extracted from configured Add-Ins' DisplayName or CompatibilityName, nor any CompatibilityName added to the list. Fallout from commit bc70f674c2487ad826f8fe04e626de1829f5b40d CommitDate: Sun Jun 18 08:41:27 2023 +0200 Use getXWeak in configmgr Change-Id: Ibaab8c08a06113b27ceffe1c45ef548c1d6fa225 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172476 Reviewed-by: Eike Rathke Tested-by: Jenkins --- configmgr/source/childaccess.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configmgr/source/childaccess.cxx b/configmgr/source/childaccess.cxx index adbc2159fa6e..506f47c0084c 100644 --- a/configmgr/source/childaccess.cxx +++ b/configmgr/source/childaccess.cxx @@ -245,7 +245,7 @@ css::uno::Any ChildAccess::asValue() return child.is() ? child->asValue() : css::uno::Any(); } } - value <<= css::uno::Reference(getXWeak()); + value <<= css::uno::Reference< css::uno::XInterface >(getXWeak()); } return value; }