Catch block smells like leftover debugging code
...especially as it doesn't change hr from S_OK, and compiling with /EHsc (instead of /EHa) reveals that OleRun does not throw any (C++) exceptions (and thus produces an "unreachable code" warning for the catch block). Change-Id: Ic34e83e6ede3a214ccb073e3e54d6fcc493d46ea
This commit is contained in:
@@ -988,16 +988,7 @@ void OleComponent::RunObject()
|
|||||||
|
|
||||||
if ( !OleIsRunning( m_pNativeImpl->m_pOleObject ) )
|
if ( !OleIsRunning( m_pNativeImpl->m_pOleObject ) )
|
||||||
{
|
{
|
||||||
HRESULT hr = S_OK;
|
HRESULT hr = OleRun( m_pNativeImpl->m_pObj );
|
||||||
try
|
|
||||||
{
|
|
||||||
hr = OleRun( m_pNativeImpl->m_pObj );
|
|
||||||
}
|
|
||||||
catch( ... )
|
|
||||||
{
|
|
||||||
int i = 0;
|
|
||||||
i++;
|
|
||||||
}
|
|
||||||
|
|
||||||
if ( FAILED( hr ) )
|
if ( FAILED( hr ) )
|
||||||
{
|
{
|
||||||
|
Reference in New Issue
Block a user