mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Upcoming improved loplugin:staticanonymous -> redundantstatic: basic

Browse Source 
Change-Id: I1046ee1ea28e19afa51b0e20ee573105ced77535
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97522
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
This commit is contained in:
Stephan Bergmann
2020-06-30 15:25:15 +02:00
parent eb582a59f8
commit d902e04baf
12 changed files with 28 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
basic/qa/cppunit/test_scanner.cxx
View File

@@ -67,12 +67,12 @@ namespace
CPPUNIT_TEST_SUITE_END(); CPPUNIT_TEST_SUITE_END();
}; };
static const OUString cr = "\n"; const OUString cr = "\n";
static const OUString rem = "REM"; const OUString rem = "REM";
static const OUString asdf = "asdf"; const OUString asdf = "asdf";
static const OUString dot = "."; const OUString dot = ".";
static const OUString goto_ = "goto"; const OUString goto_ = "goto";
static const OUString excl = "!"; const OUString excl = "!";
std::vector<Symbol> getSymbols(const OUString& source, sal_Int32& errors, bool bCompatible = false) std::vector<Symbol> getSymbols(const OUString& source, sal_Int32& errors, bool bCompatible = false)
{ {

12
basic/source/basmgr/basmgr.cxx
View File

@@ -84,12 +84,12 @@ typedef WeakImplHelper< script::XStarBasicAccess > StarBasicAccessHelper;
// Version 2 // Version 2
// + bool bReference // + bool bReference
static const char szStdLibName[] = "Standard"; const char szStdLibName[] = "Standard";
static const char szBasicStorage[] = "StarBASIC"; const char szBasicStorage[] = "StarBASIC";
static const char szOldManagerStream[] = "BasicManager"; const char szOldManagerStream[] = "BasicManager";
static const char szManagerStream[] = "BasicManager2"; const char szManagerStream[] = "BasicManager2";
static const char szImbedded[] = "LIBIMBEDDED"; const char szImbedded[] = "LIBIMBEDDED";
static const char szCryptingKey[] = "CryptedBasic"; const char szCryptingKey[] = "CryptedBasic";
const StreamMode eStreamReadMode = StreamMode::READ | StreamMode::NOCREATE | StreamMode::SHARE_DENYALL; const StreamMode eStreamReadMode = StreamMode::READ | StreamMode::NOCREATE | StreamMode::SHARE_DENYALL;

2
basic/source/classes/image.cxx
View File

@@ -86,7 +86,7 @@ static void SbiCloseRecord( SvStream& r, sal_uInt64 nOff )
r.Seek( nPos ); r.Seek( nPos );
} }
static constexpr sal_uInt32 nUnicodeDataMagicNumber = 0x556E6920; // "Uni " BE constexpr sal_uInt32 nUnicodeDataMagicNumber = 0x556E6920; // "Uni " BE
static bool GetToUnicodePoolData(SvStream& r, sal_uInt64 nLen, sal_uInt64 nNext) static bool GetToUnicodePoolData(SvStream& r, sal_uInt64 nLen, sal_uInt64 nNext)
{ {

8
basic/source/classes/sb.cxx
View File

@@ -1947,10 +1947,10 @@ void StarBASIC::DetachAllDocBasicItems()
// #118116 Implementation Collection object // #118116 Implementation Collection object
static const char pCountStr[] = "Count"; const char pCountStr[] = "Count";
static const char pAddStr[] = "Add"; const char pAddStr[] = "Add";
static const char pItemStr[] = "Item"; const char pItemStr[] = "Item";
static const char pRemoveStr[] = "Remove"; const char pRemoveStr[] = "Remove";
static sal_uInt16 nCountHash = 0, nAddHash, nItemHash, nRemoveHash; static sal_uInt16 nCountHash = 0, nAddHash, nItemHash, nRemoveHash;
SbxInfoRef BasicCollection::xAddInfo; SbxInfoRef BasicCollection::xAddInfo;

8
basic/source/classes/sbunoobj.cxx
View File

@@ -98,11 +98,11 @@ using namespace cppu;
// Identifiers for creating the strings for dbg_Properties // Identifiers for creating the strings for dbg_Properties
static char const ID_DBG_SUPPORTEDINTERFACES[] = "Dbg_SupportedInterfaces"; char const ID_DBG_SUPPORTEDINTERFACES[] = "Dbg_SupportedInterfaces";
static char const ID_DBG_PROPERTIES[] = "Dbg_Properties"; char const ID_DBG_PROPERTIES[] = "Dbg_Properties";
static char const ID_DBG_METHODS[] = "Dbg_Methods"; char const ID_DBG_METHODS[] = "Dbg_Methods";
static char const aSeqLevelStr[] = "[]"; char const aSeqLevelStr[] = "[]";
// Gets the default property for a uno object. Note: There is some // Gets the default property for a uno object. Note: There is some
// redirection built in. The property name specifies the name // redirection built in. The property name specifies the name

2
basic/source/comp/buffer.cxx
View File

@@ -22,7 +22,7 @@
#include <basic/sberrors.hxx> #include <basic/sberrors.hxx>
const static sal_uInt32 UP_LIMIT=0xFFFFFF00; const sal_uInt32 UP_LIMIT=0xFFFFFF00;
// The SbiBuffer will be expanded in increments of at least 16 Bytes. // The SbiBuffer will be expanded in increments of at least 16 Bytes.
// This is necessary, because many classes emanate from a buffer length // This is necessary, because many classes emanate from a buffer length

2
basic/source/comp/exprgen.cxx
View File

@@ -34,7 +34,7 @@ struct OpTable {
} }
static const OpTable aOpTable [] = { const OpTable aOpTable [] = {
{ EXPON,SbiOpcode::EXP_ }, { EXPON,SbiOpcode::EXP_ },
{ MUL, SbiOpcode::MUL_ }, { MUL, SbiOpcode::MUL_ },
{ DIV, SbiOpcode::DIV_ }, { DIV, SbiOpcode::DIV_ },

2
basic/source/comp/parser.cxx
View File

@@ -47,7 +47,7 @@ struct SbiStatement {
#define Y true #define Y true
#define N false #define N false
static const SbiStatement StmntTable [] = { const SbiStatement StmntTable [] = {
{ ATTRIBUTE, &SbiParser::Attribute, Y, Y, }, // ATTRIBUTE { ATTRIBUTE, &SbiParser::Attribute, Y, Y, }, // ATTRIBUTE
{ CALL, &SbiParser::Call, N, Y, }, // CALL { CALL, &SbiParser::Call, N, Y, }, // CALL
{ CLOSE, &SbiParser::Close, N, Y, }, // CLOSE { CLOSE, &SbiParser::Close, N, Y, }, // CLOSE

2
basic/source/comp/token.cxx
View File

@@ -32,7 +32,7 @@ struct TokenTable { SbiToken t; const char *s; };
} }
static const TokenTable aTokTable_Basic [] = { const TokenTable aTokTable_Basic [] = {
{ CAT, "&" }, { CAT, "&" },
{ MUL, "*" }, { MUL, "*" },
{ PLUS, "+" }, { PLUS, "+" },

2
basic/source/runtime/ddectrl.cxx
View File

@@ -25,7 +25,7 @@
#define DDE_FIRSTERR 0x4000 #define DDE_FIRSTERR 0x4000
#define DDE_LASTERR 0x4011 #define DDE_LASTERR 0x4011
static const ErrCode nDdeErrMap[] = const ErrCode nDdeErrMap[] =
{ {
/* DMLERR_ADVACKTIMEOUT */ ErrCode(0x4000), ERRCODE_BASIC_DDE_TIMEOUT, /* DMLERR_ADVACKTIMEOUT */ ErrCode(0x4000), ERRCODE_BASIC_DDE_TIMEOUT,
/* DMLERR_BUSY */ ErrCode(0x4001), ERRCODE_BASIC_DDE_BUSY, /* DMLERR_BUSY */ ErrCode(0x4001), ERRCODE_BASIC_DDE_BUSY,

2
basic/source/runtime/runtime.cxx
View File

@@ -1778,7 +1778,7 @@ void removeDimAsNewRecoverItem( SbxVariable* pVar )
// saving object variable // saving object variable
// not-object variables will cause errors // not-object variables will cause errors
static const char pCollectionStr[] = "Collection"; const char pCollectionStr[] = "Collection";
void SbiRuntime::StepSET_Impl( SbxVariableRef& refVal, SbxVariableRef& refVar, bool bHandleDefaultProp ) void SbiRuntime::StepSET_Impl( SbxVariableRef& refVal, SbxVariableRef& refVar, bool bHandleDefaultProp )
{ {

2
basic/source/sbx/sbxscan.cxx
View File

@@ -292,7 +292,7 @@ ErrCode SbxValue::ScanNumIntnl( const OUString& rSrc, double& nVal, bool bSingle
} }
static const double roundArray[] = { const double roundArray[] = {
5.0e+0, 0.5e+0, 0.5e-1, 0.5e-2, 0.5e-3, 0.5e-4, 0.5e-5, 0.5e-6, 0.5e-7, 5.0e+0, 0.5e+0, 0.5e-1, 0.5e-2, 0.5e-3, 0.5e-4, 0.5e-5, 0.5e-6, 0.5e-7,
0.5e-8, 0.5e-9, 0.5e-10,0.5e-11,0.5e-12,0.5e-13,0.5e-14,0.5e-15 }; 0.5e-8, 0.5e-9, 0.5e-10,0.5e-11,0.5e-12,0.5e-13,0.5e-14,0.5e-15 };