mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pEmpty is completely insane to use

Browse Source 
DbtToStringConverter protects against a NULL pointer, but not a
pointer to the too short data that pEmpty provides

Change-Id: I5d21e852ce0373eff7d3627e266b9cbc77f5dd09
This commit is contained in:
Caolán McNamara
2013-10-24 16:18:41 +01:00
parent 3617e1a37f
commit d94f3a68f7
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
xmlhelp/source/cxxhelp/provider/databases.cxx
View File

@@ -746,15 +746,13 @@ void KeywordInfo::KeywordElement::init( Databases *pDatabases,helpdatafileproxy:
listAnchor.realloc( id.size() ); listAnchor.realloc( id.size() );
listTitle.realloc( id.size() ); listTitle.realloc( id.size() );
const sal_Char* pData = NULL;
const sal_Char pEmpty[] = "";
for( sal_uInt32 i = 0; i < id.size(); ++i ) for( sal_uInt32 i = 0; i < id.size(); ++i )
{ {
listId[i] = id[i]; listId[i] = id[i];
listAnchor[i] = anchor[i]; listAnchor[i] = anchor[i];
pData = pEmpty; const sal_Char* pData = NULL;
if( pHdf ) if( pHdf )
{ {
OString idi( id[i].getStr(),id[i].getLength(),RTL_TEXTENCODING_UTF8 ); OString idi( id[i].getStr(),id[i].getLength(),RTL_TEXTENCODING_UTF8 );