cid#1557699 COPY_INSTEAD_OF_MOVE

and

cid#1557435 COPY_INSTEAD_OF_MOVE
cid#1557307 COPY_INSTEAD_OF_MOVE
cid#1557209 COPY_INSTEAD_OF_MOVE
cid#1557192 COPY_INSTEAD_OF_MOVE
cid#1557184 COPY_INSTEAD_OF_MOVE
cid#1557183 COPY_INSTEAD_OF_MOVE
cid#1557171 COPY_INSTEAD_OF_MOVE
cid#1557150 COPY_INSTEAD_OF_MOVE
cid#1557148 COPY_INSTEAD_OF_MOVE
cid#1557123 COPY_INSTEAD_OF_MOVE
cid#1557118 COPY_INSTEAD_OF_MOVE
cid#1557116 COPY_INSTEAD_OF_MOVE
cid#1557103 COPY_INSTEAD_OF_MOVE
cid#1557078 COPY_INSTEAD_OF_MOVE
cid#1557075 COPY_INSTEAD_OF_MOVE
cid#1557071 COPY_INSTEAD_OF_MOVE
cid#1557070 COPY_INSTEAD_OF_MOVE
cid#1557067 COPY_INSTEAD_OF_MOVE
cid#1557049 COPY_INSTEAD_OF_MOVE
cid#1557046 COPY_INSTEAD_OF_MOVE
cid#1557042 COPY_INSTEAD_OF_MOVE
cid#1557036 COPY_INSTEAD_OF_MOVE
cid#1557030 COPY_INSTEAD_OF_MOVE
cid#1557024 COPY_INSTEAD_OF_MOVE
cid#1557012 COPY_INSTEAD_OF_MOVE
cid#1557009 COPY_INSTEAD_OF_MOVE
cid#1557008 COPY_INSTEAD_OF_MOVE
cid#1557004 COPY_INSTEAD_OF_MOVE
cid#1556999 COPY_INSTEAD_OF_MOVE
cid#1556992 COPY_INSTEAD_OF_MOVE
cid#1556987 COPY_INSTEAD_OF_MOVE
cid#1556984 COPY_INSTEAD_OF_MOVE
cid#1556981 COPY_INSTEAD_OF_MOVE

Change-Id: Id2687aa282f4e2d4b8053b73c7aa1a74a9516b16
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171974
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
This commit is contained in:
Caolán McNamara 2024-08-17 14:37:04 +01:00
parent c6a71f5daf
commit dd689fb914
33 changed files with 37 additions and 37 deletions

View File

@ -189,7 +189,7 @@ bool IncomingRequest::execute_throw(
args.push_back(inArguments_[0].getValue(t));
} else {
assert(inArguments_.empty());
retType = t;
retType = std::move(t);
}
break;
}

View File

@ -469,7 +469,7 @@ void SpellDialog::StartSpellOptDlg_Impl()
std::unique_ptr<SfxTabPage> xPage = SvxLinguTabPage::Create(m_xOptionsDlg->get_content_area(), m_xOptionsDlg.get(), xSet.get());
static_cast<SvxLinguTabPage*>(xPage.get())->HideGroups( GROUP_MODULES );
m_xOptionsDlg->SetTabPage(std::move(xPage));
weld::GenericDialogController::runAsync(m_xOptionsDlg, [this, xSet] (sal_uInt32 nResult) {
weld::GenericDialogController::runAsync(m_xOptionsDlg, [this, xSet=std::move(xSet)] (sal_uInt32 nResult) {
if (RET_OK == nResult)
{
InitUserDicts();

View File

@ -192,7 +192,7 @@ void ORelationTableView::AddConnection(const OJoinExchangeData& jxdSource, const
pTabConnData->SetConnLine( 0, sSourceFieldName, sDestFieldName );
if ( bAskUser || m_pExistingConnection )
m_pCurrentlyTabConnData = pTabConnData; // this implies that we ask the user what to do
m_pCurrentlyTabConnData = std::move(pTabConnData); // this implies that we ask the user what to do
else
{
try

View File

@ -1724,7 +1724,7 @@ namespace emfplushelper
std::move(emptyVector), // EMF-PLUS has no DX-array
{},
std::move(fontAttribute),
locale,
std::move(locale),
color.getBColor());
}
drawinglayer::primitive2d::Primitive2DReference aPrimitiveText(pBaseText);

View File

@ -1600,7 +1600,7 @@ bool SvtFileDialog::PrepareExecute()
aFolderURL.removeSegment();
}
INetURLObject aObj = aFolderURL;
INetURLObject aObj = std::move(aFolderURL);
if ( aObj.GetProtocol() == INetProtocol::File )
{
// set folder as current directory

View File

@ -384,7 +384,7 @@ void myparser::traverse( xmlNodePtr parentNode )
ll.push_back(keyword);
}
if (!ll.empty())
(*keywords)[anchor] = ll;
(*keywords)[anchor] = std::move(ll);
}
else if (branch.compare("contents") == 0)
{
@ -410,7 +410,7 @@ void myparser::traverse( xmlNodePtr parentNode )
if (hidstr != "." && !hidstr.empty()) //simple case of explicitly named target
{
assert(!hidstr.empty());
(*helptexts)[hidstr] = text;
(*helptexts)[hidstr] = std::move(text);
}
else //apply to list of "current" hids determined by recent bookmarks that have hid in their branch
{

View File

@ -286,7 +286,7 @@ void BreakIterator_Unicode::loadICUBreakIterator(const css::lang::Locale& rLocal
throw uno::RuntimeException("Failed to create ICU BreakIterator: error " + OUString::createFromAscii(u_errorName(status)));
}
icuBI->mpValue = std::make_shared<BI_ValueData>();
icuBI->mpValue->mpBreakIterator = pBI;
icuBI->mpValue->mpBreakIterator = std::move(pBI);
theBIMap.insert( std::make_pair( aBIMapLocaleTypeKey, icuBI->mpValue));
} while (false);
if (!icuBI->mpValue || !icuBI->mpValue->mpBreakIterator) {

View File

@ -202,7 +202,7 @@ uno::Sequence< Locale > SAL_CALL LangGuess_Impl::getAvailableLanguages( )
css::lang::Locale current_aRes;
current_aRes.Language = OUString::createFromAscii( gs[i].GetLanguage() );
current_aRes.Country = OUString::createFromAscii( gs[i].GetCountry() );
pRes[i] = current_aRes;
pRes[i] = std::move(current_aRes);
}
return aRes;

View File

@ -196,7 +196,7 @@ void CustomShapeProperties::pushToPropSet(
aAdjustmentVal.Value <<= adjustmentGuide.maFormula.toInt32();
aAdjustmentVal.State = PropertyState_DIRECT_VALUE;
aAdjustmentVal.Name = adjustmentGuide.maName;
aAdjustmentSeqRange[ nAdjustmentIndex ] = aAdjustmentVal;
aAdjustmentSeqRange[ nAdjustmentIndex ] = std::move(aAdjustmentVal);
}
} else if ( aAdjustmentSeq.hasElements() ) {
EnhancedCustomShapeAdjustmentValue aAdjustmentVal;
@ -205,7 +205,7 @@ void CustomShapeProperties::pushToPropSet(
aAdjustmentVal.Name = adjustmentGuide.maName;
if (nIndex < aAdjustmentSeq.getLength())
{
aAdjustmentSeqRange[nIndex] = aAdjustmentVal;
aAdjustmentSeqRange[nIndex] = std::move(aAdjustmentVal);
++nIndex;
}
}

View File

@ -83,7 +83,7 @@ void ShapeCreationVisitor::visit(LayoutNode& rAtom)
{
pShape->setInternalName(rAtom.getName());
rAtom.addNodeShape(pShape);
mrDgm.getLayout()->getPresPointShapeMap()[pNewNode] = pShape;
mrDgm.getLayout()->getPresPointShapeMap()[pNewNode] = std::move(pShape);
}
}
else

View File

@ -236,7 +236,7 @@ ContextHandlerRef TextCharacterPropertiesContext::onCreateContext( sal_Int32 aEl
{
oox::drawingml::Color theColor;
theColor.setSrgbClr(colorAttrib.value());
mrTextCharacterProperties.maUnderlineColor = theColor;
mrTextCharacterProperties.maUnderlineColor = std::move(theColor);
}
break;
}

View File

@ -896,7 +896,7 @@ uno::Sequence< beans::PropertyValue > OWriteStream_Impl::InsertOwnProps(
break;
if (i == aResult.getLength())
aResult.realloc(i + 1);
aResult.getArray()[i] = aPropVal;
aResult.getArray()[i] = std::move(aPropVal);
}
return aResult;

View File

@ -2684,7 +2684,7 @@ void DynamicKernel::CreateKernel()
}
lastSecondKernelHash = lastOneKernelHash;
lastSecondProgram = lastOneProgram;
lastOneKernelHash = KernelHash;
lastOneKernelHash = std::move(KernelHash);
lastOneProgram = mpProgram;
}
mpKernel = clCreateKernel(mpProgram, kname.c_str(), &err);

View File

@ -7217,14 +7217,14 @@ void ScInterpreter::ScLookup()
{
ScMatrixRef pTempMat = GetNewMat( 1, nElems, /*bEmpty*/true );
pTempMat->PutDoubleVector( vArray, 0, 0);
pDataMat2 = pTempMat;
pDataMat2 = std::move(pTempMat);
}
else
{
ScMatrixRef pTempMat = GetNewMat( nElems, 1, /*bEmpty*/true );
for (size_t i=0; i < nElems; ++i)
pTempMat->PutDouble( vArray[i], i, 0);
pDataMat2 = pTempMat;
pDataMat2 = std::move(pTempMat);
}
}
}

View File

@ -1355,11 +1355,11 @@ void ScInterpreter::CalculateAddSub(bool _bSub)
{
double fVal;
bool bFlag;
ScMatrixRef pMat = pMat1;
ScMatrixRef pMat = std::move(pMat1);
if (!pMat)
{
fVal = fVal1;
pMat = pMat2;
pMat = std::move(pMat2);
bFlag = true; // double - Matrix
}
else

View File

@ -303,7 +303,7 @@ std::unique_ptr<ScDBData> ScXMLDatabaseRangeContext::ConvertToDBData(const OUStr
table::TableOrientation eOrient = mpQueryParam->bByRow ?
table::TableOrientation_ROWS : table::TableOrientation_COLUMNS;
aProperty.Value <<= eOrient;
aSortSequence.getArray()[nOldSize] = aProperty;
aSortSequence.getArray()[nOldSize] = std::move(aProperty);
ScSortParam aParam;
ScSortDescriptor::FillSortParam(aParam, aSortSequence);

View File

@ -1564,7 +1564,7 @@ void SlideshowImpl::registerShapeEvents( Reference< XShapes > const & xShapes )
continue; // skip all others
}
maShapeEventMap[ xShape ] = pEvent;
maShapeEventMap[ xShape ] = std::move(pEvent);
if( mxListenerProxy.is() )
mxListenerProxy->addShapeEventListener( xShape );

View File

@ -1950,7 +1950,7 @@ private:
}
else
{
rInfo.maMap = aMap;
rInfo.maMap = std::move(aMap);
PrepareScaledPage(*it, *pPage, ePageKind, rInfo);
}
}

View File

@ -386,7 +386,7 @@ void RecentDocsViewItem::OpenDocument()
// after select!!!
sfx2::LoadRecentFile *const pLoadRecentFile = new sfx2::LoadRecentFile;
pLoadRecentFile->xDispatch = xDispatch;
pLoadRecentFile->aTargetURL = aTargetURL;
pLoadRecentFile->aTargetURL = std::move(aTargetURL);
pLoadRecentFile->aArgSeq = aArgsList;
pLoadRecentFile->pView = &mrParentView;

View File

@ -1065,7 +1065,7 @@ void SfxOleSection::LoadProperty( SvStream& rStrm, sal_Int32 nPropId )
if( xProp )
{
SetError( xProp->Load( rStrm ) );
maPropMap[ nPropId ] = xProp;
maPropMap[ nPropId ] = std::move(xProp);
}
}

View File

@ -335,7 +335,7 @@ void SlideBackgroundFillPrimitive2D::get2DDecomposition(
if(!getBuffered2DDecomposition())
{
// remember last Fill
const_cast< SlideBackgroundFillPrimitive2D* >(this)->maLastFill = aFill;
const_cast< SlideBackgroundFillPrimitive2D* >(this)->maLastFill = std::move(aFill);
}
// use parent implementation

View File

@ -338,7 +338,7 @@ namespace toolkit
OSL_VERIFY( i_event.Element >>= aImageURLs );
::std::vector< CachedImage > aImages;
lcl_init( aImageURLs, aImages );
maCachedImageSets[ position ] = aImages;
maCachedImageSets[ position ] = std::move(aImages);
updateImageList_nothrow();
}

View File

@ -1050,7 +1050,7 @@ bool INetURLObject::setAbsURIRef(std::u16string_view rTheAbsURIRef,
OUStringBuffer aSynAuthority(64);
if ( !bHasUser )
{
aSynAuthority = aSynUser;
aSynAuthority = std::move(aSynUser);
}
else
{

View File

@ -47,7 +47,7 @@ struct VCL_DLLPUBLIC ExternalPDFStream
}
else
{
mpPDFDocument = pPDFDocument;
mpPDFDocument = std::move(pPDFDocument);
}
}
return mpPDFDocument;

View File

@ -369,7 +369,7 @@ bool Bitmap::Rotate(Degree10 nAngle10, const Color& rFillColor)
pWriteAcc.reset();
}
aRotatedBmp = aNewBmp;
aRotatedBmp = std::move(aNewBmp);
}
else
{

View File

@ -350,7 +350,7 @@ void NotebookBar::UpdateDefaultSettings()
aStyleSet.SetToolTextColor(aTextColor);
aAllSettings.SetStyleSettings(aStyleSet);
DefaultSettings = aAllSettings;
DefaultSettings = std::move(aAllSettings);
}
void NotebookBar::UpdatePersonaSettings()

View File

@ -270,7 +270,7 @@ void TextView::ImpPaint(vcl::RenderContext& rRenderContext, const Point& rStartP
if (aFont.IsTransparent())
aColor = COL_TRANSPARENT;
aFont.SetFillColor(aColor);
mpImpl->mpTextEngine->maFont = aFont;
mpImpl->mpTextEngine->maFont = std::move(aFont);
}
}

View File

@ -1336,7 +1336,7 @@ void OS2METReader::ReadBezier(bool bGivenPos, sal_uInt16 nOrderLen)
if( nNumPoints != aBezPoly.GetSize() )
aBezPoly.SetSize( nNumPoints );
aPolygon = aBezPoly;
aPolygon = std::move(aBezPoly);
}
aAttr.aCurPos = aPolygon[ nNumPoints - 1 ];

View File

@ -474,7 +474,7 @@ void SVMConverter::ImplConvertFromSVM1( SvStream& rIStm, GDIMetaFile& rMtf )
{
rMtf.ReplaceAction(
new MetaPolyPolygonAction(
aInputPolyPolygon),
std::move(aInputPolyPolygon)),
nLastPolygonAction);
}
}

View File

@ -10456,7 +10456,7 @@ void PDFWriterImpl::setClipRegion( const basegfx::B2DPolyPolygon& rRegion )
basegfx::B2DPolyPolygon aRegion(rRegion);
aRegion.transform(aCurrentTransform);
m_aGraphicsStack.front().m_aClipRegion = aRegion;
m_aGraphicsStack.front().m_aClipRegion = std::move(aRegion);
m_aGraphicsStack.front().m_bClipRegion = true;
m_aGraphicsStack.front().m_nUpdateFlags |= GraphicsStateUpdateFlags::ClipRegion;
}

View File

@ -1131,7 +1131,7 @@ bool Printer::SetOrientation( Orientation eOrientation )
{
ImplUpdateJobSetupPaper( aJobSetup );
mbNewJobSetup = true;
maJobSetup = aJobSetup;
maJobSetup = std::move(aJobSetup);
ImplUpdatePageData();
ImplUpdateFontList();
return true;

View File

@ -858,7 +858,7 @@ void SystemQueueInfo::run()
rParm.pHandler( aLines, aSysPrintQueues, &rParm );
std::unique_lock aGuard( m_aMutex );
m_bChanged = true;
m_aQueues = aSysPrintQueues;
m_aQueues = std::move(aSysPrintQueues);
m_aCommand = OUString::createFromAscii( rParm.pPrintCommand );
#if OSL_DEBUG_LEVEL > 1
SAL_INFO("vcl.unx.print", "printing queue command: success.");

View File

@ -6028,7 +6028,7 @@ void GtkSalFrame::IMHandler::signalIMPreeditChanged( GtkIMContext* pIMContext, g
pThis->m_aInputEvent.maText = sText;
pThis->m_aInputEvent.mnCursorPos = nCursorPos;
pThis->m_aInputEvent.mnCursorFlags = nCursorFlags;
pThis->m_aInputFlags = aInputFlags;
pThis->m_aInputFlags = std::move(aInputFlags);
pThis->m_aInputEvent.mpTextAttr = pThis->m_aInputFlags.data();
SolarMutexGuard aGuard;