mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:virtualdead unused param in SdrHdl::onHelpRequest

Browse Source 
Change-Id: I3d75755bd6fd7f3168725c53fd8ce571a938fa37
Reviewed-on: https://gerrit.libreoffice.org/81181
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin 2019-10-17 16:47:45 +02:00
parent d5ec8bc929
commit defd2cb025
5 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
compilerplugins/clang/virtualdead.unusedparams.results
View File

@ -184,9 +184,6 @@ include/svx/IAccessibleParent.hxx:80
include/svx/selectioncontroller.hxx:48
_Bool sdr::SelectionController::onMouseButtonUp(const class MouseEvent &,class vcl::Window *,)
10
include/svx/svdhdl.hxx:242
void SdrHdl::onHelpRequest(const class HelpEvent &,)
0
include/vcl/accessibletable.hxx:91
class tools::Rectangle vcl::table::IAccessibleTable::GetFieldCharacterBounds(int,int,int,)
001

2
include/svx/svdhdl.hxx
View File

@ -239,7 +239,7 @@ public:
virtual void onMouseEnter(const MouseEvent& rMEvt);
/** is called when help is requested for the area of this handle */
virtual void onHelpRequest(const HelpEvent& rHEvt);
virtual void onHelpRequest();
/** is called when the mouse leaves the area of this handle. If the handle changes his
visualisation during mouse over it must override this method and call Touch(). */

4
sd/source/ui/view/viewoverlaymanager.cxx
View File

@ -139,7 +139,7 @@ public:
virtual PointerStyle GetPointer() const override;
virtual void onMouseEnter(const MouseEvent& rMEvt) override;
virtual void onHelpRequest(const HelpEvent& rHEvt) override;
virtual void onHelpRequest() override;
virtual void onMouseLeave() override;
int getHighlightId() const { return mnHighlightId; }
@ -196,7 +196,7 @@ void ImageButtonHdl::ShowTip()
Help::ShowQuickHelp(pWindow, aScreenRect, aHelpText);
}
void ImageButtonHdl::onHelpRequest(const HelpEvent& /*rHEvt*/)
void ImageButtonHdl::onHelpRequest()
{
ShowTip();
}

2
svx/source/svdraw/svdhdl.cxx
View File

@ -1064,7 +1064,7 @@ void SdrHdl::onMouseEnter(const MouseEvent& /*rMEvt*/)
{
}
void SdrHdl::onHelpRequest(const HelpEvent& /*rHEvt*/)
void SdrHdl::onHelpRequest()
{
}

2
svx/source/svdraw/svdmrkv.cxx
View File

@ -1449,7 +1449,7 @@ bool SdrMarkView::RequestHelp(const HelpEvent& rHEvt)
SdrHdl* pCurrentHdl = GetHdl(nHdl);
if (pCurrentHdl->mbMouseOver)
{
pCurrentHdl->onHelpRequest(rHEvt);
pCurrentHdl->onHelpRequest();
return true;
}
}