mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

coverity#705538 Unintentional integer overflow

Browse Source 
Change-Id: I50f0701bea8f2f2e00a6b1396ba7cfbf5e0bd00c
This commit is contained in:
Caolán McNamara
2014-04-18 13:50:00 +01:00
parent 49b981c6b2
commit dfeadd06ce
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
sot/source/sdstor/stgcache.cxx
View File

@@ -331,9 +331,9 @@ bool StgCache::Read( sal_Int32 nPage, void* pBuf, sal_Int32 nPg )
SetError( SVSTREAM_READ_ERROR ); SetError( SVSTREAM_READ_ERROR );
else if ( nPage < nPages ) else if ( nPage < nPages )
{ {
sal_uLong nPos = Page2Pos( nPage ); sal_uInt32 nPos = Page2Pos( nPage );
sal_Int32 nPg2 = ( ( nPage + nPg ) > nPages ) ? nPages - nPage : nPg; sal_Int32 nPg2 = ( ( nPage + nPg ) > nPages ) ? nPages - nPage : nPg;
sal_uLong nBytes = nPg2 * nPageSize; sal_uInt32 nBytes = nPg2 * nPageSize;
// fixed address and size for the header // fixed address and size for the header
if( nPage == -1 ) if( nPage == -1 )
{ {
@@ -362,8 +362,8 @@ bool StgCache::Write( sal_Int32 nPage, void* pBuf, sal_Int32 nPg )
{ {
if( Good() ) if( Good() )
{ {
sal_uLong nPos = Page2Pos( nPage ); sal_uInt32 nPos = Page2Pos( nPage );
sal_uLong nBytes = 0; sal_uInt32 nBytes = 0;
if ( SAL_MAX_INT32 / nPg > nPageSize ) if ( SAL_MAX_INT32 / nPg > nPageSize )
nBytes = nPg * nPageSize; nBytes = nPg * nPageSize;