mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:unnecessaryvirtual

Browse Source 
Change-Id: Iaba4e315aecf8dfe336e5fd5e95235ff66ab53a8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86652
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2020-01-13 08:33:28 +02:00
parent 6e71005fb4
commit e0bfaf5aff
4 changed files with 63 additions and 81 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
compilerplugins/clang/unnecessaryvirtual-dead.results
View File

@@ -1,5 +1,5 @@
basic/source/comp/codegen.cxx:464 basic/source/comp/codegen.cxx:478
void OffSetAccumulator::start(const unsigned char *,) void (anonymous namespace)::OffSetAccumulator::start(const unsigned char *,)
include/basegfx/utils/unopolypolygon.hxx:97 include/basegfx/utils/unopolypolygon.hxx:97
void basegfx::unotools::UnoPolyPolygon::modifying()const void basegfx::unotools::UnoPolyPolygon::modifying()const
include/canvas/base/bufferedgraphicdevicebase.hxx:108 include/canvas/base/bufferedgraphicdevicebase.hxx:108
@@ -8,12 +8,16 @@ include/canvas/base/graphicdevicebase.hxx:306
void canvas::GraphicDeviceBase::removePropertyChangeListener(const class rtl::OUString &,const class com::sun::star::uno::Reference<class com::sun::star::beans::XPropertyChangeListener> &,) void canvas::GraphicDeviceBase::removePropertyChangeListener(const class rtl::OUString &,const class com::sun::star::uno::Reference<class com::sun::star::beans::XPropertyChangeListener> &,)
include/canvas/base/graphicdevicebase.hxx:319 include/canvas/base/graphicdevicebase.hxx:319
void canvas::GraphicDeviceBase::removeVetoableChangeListener(const class rtl::OUString &,const class com::sun::star::uno::Reference<class com::sun::star::beans::XVetoableChangeListener> &,) void canvas::GraphicDeviceBase::removeVetoableChangeListener(const class rtl::OUString &,const class com::sun::star::uno::Reference<class com::sun::star::beans::XVetoableChangeListener> &,)
sc/source/core/opencl/formulagroupcl.cxx:1059 sc/source/core/opencl/formulagroupcl.cxx:1062
void sc::opencl::DynamicKernelSlidingArgument::GenSlidingWindowFunction(class std::__cxx11::basic_stringstream<char> &,) void sc::opencl::(anonymous namespace)::DynamicKernelSlidingArgument::GenSlidingWindowFunction(class std::__cxx11::basic_stringstream<char> &,)
slideshow/source/engine/animationfactory.cxx:441 slideshow/source/engine/animationfactory.cxx:439
void slideshow::internal::(anonymous namespace)::GenericAnimation::prefetch() void slideshow::internal::(anonymous namespace)::GenericAnimation::prefetch()
vcl/inc/salframe.hxx:145 vcl/inc/salframe.hxx:145
void SalFrame::SetRepresentedURL(const class rtl::OUString &,) void SalFrame::SetRepresentedURL(const class rtl::OUString &,)
vcl/inc/salinst.hxx:202
void SalInstance::releaseMainThread()
vcl/inc/salmenu.hxx:71
void SalMenu::SetItemBits(unsigned int,enum MenuItemBits,)
vcl/inc/salmenu.hxx:81 vcl/inc/salmenu.hxx:81
void SalMenu::RemoveMenuBarButton(unsigned short,) void SalMenu::RemoveMenuBarButton(unsigned short,)
vcl/inc/salobj.hxx:49 vcl/inc/salobj.hxx:49

2
compilerplugins/clang/unnecessaryvirtual.py
View File

@@ -1,4 +1,4 @@
#!/usr/bin/python #!/usr/bin/python2
import io import io
import re import re

126
compilerplugins/clang/unnecessaryvirtual.results
View File

@@ -1,40 +1,40 @@
basic/source/comp/codegen.cxx:464 basic/source/comp/codegen.cxx:478
void OffSetAccumulator::start(const unsigned char *,) void (anonymous namespace)::OffSetAccumulator::start(const unsigned char *,)
basic/source/comp/codegen.cxx:465 basic/source/comp/codegen.cxx:479
void OffSetAccumulator::processOpCode0(enum SbiOpcode,) void (anonymous namespace)::OffSetAccumulator::processOpCode0(enum SbiOpcode,)
basic/source/comp/codegen.cxx:466 basic/source/comp/codegen.cxx:480
void OffSetAccumulator::processOpCode1(enum SbiOpcode,type-parameter-0-0,) void (anonymous namespace)::OffSetAccumulator::processOpCode1(enum SbiOpcode,type-parameter-0-0,)
basic/source/comp/codegen.cxx:467 basic/source/comp/codegen.cxx:481
void OffSetAccumulator::processOpCode2(enum SbiOpcode,type-parameter-0-0,type-parameter-0-0,) void (anonymous namespace)::OffSetAccumulator::processOpCode2(enum SbiOpcode,type-parameter-0-0,type-parameter-0-0,)
basic/source/comp/codegen.cxx:476 basic/source/comp/codegen.cxx:490
_Bool OffSetAccumulator::processParams() _Bool (anonymous namespace)::OffSetAccumulator::processParams()
basic/source/comp/codegen.cxx:487 basic/source/comp/codegen.cxx:501
void BufferTransformer::start(const unsigned char *,) void (anonymous namespace)::BufferTransformer::start(const unsigned char *,)
basic/source/comp/codegen.cxx:488 basic/source/comp/codegen.cxx:502
void BufferTransformer::processOpCode0(enum SbiOpcode,) void (anonymous namespace)::BufferTransformer::processOpCode0(enum SbiOpcode,)
basic/source/comp/codegen.cxx:492 basic/source/comp/codegen.cxx:506
void BufferTransformer::processOpCode1(enum SbiOpcode,type-parameter-0-0,) void (anonymous namespace)::BufferTransformer::processOpCode1(enum SbiOpcode,type-parameter-0-0,)
basic/source/comp/codegen.cxx:517 basic/source/comp/codegen.cxx:531
void BufferTransformer::processOpCode2(enum SbiOpcode,type-parameter-0-0,type-parameter-0-0,) void (anonymous namespace)::BufferTransformer::processOpCode2(enum SbiOpcode,type-parameter-0-0,type-parameter-0-0,)
basic/source/comp/codegen.cxx:526 basic/source/comp/codegen.cxx:540
_Bool BufferTransformer::processParams() _Bool (anonymous namespace)::BufferTransformer::processParams()
chart2/source/inc/WeakListenerAdapter.hxx:57 chart2/source/inc/WeakListenerAdapter.hxx:57
void chart::WeakListenerAdapter::disposing(const struct com::sun::star::lang::EventObject &,) void chart::WeakListenerAdapter::disposing(const struct com::sun::star::lang::EventObject &,)
extensions/source/dbpilots/unoautopilot.hxx:98 extensions/source/dbpilots/unoautopilot.hxx:98
class cppu::IPropertyArrayHelper * dbp::OUnoAutoPilot::createArrayHelper()const class cppu::IPropertyArrayHelper * dbp::OUnoAutoPilot::createArrayHelper()const
extensions/source/propctrlr/commoncontrol.hxx:127
short pcr::CommonBehaviourControl::getControlType()
extensions/source/propctrlr/commoncontrol.hxx:129
class com::sun::star::uno::Reference<class com::sun::star::inspection::XPropertyControlContext> pcr::CommonBehaviourControl::getControlContext()
extensions/source/propctrlr/commoncontrol.hxx:131 extensions/source/propctrlr/commoncontrol.hxx:131
void pcr::CommonBehaviourControl::setControlContext(const class com::sun::star::uno::Reference<class com::sun::star::inspection::XPropertyControlContext> &,) short pcr::CommonBehaviourControl::getControlType()
extensions/source/propctrlr/commoncontrol.hxx:133 extensions/source/propctrlr/commoncontrol.hxx:133
class com::sun::star::uno::Reference<class com::sun::star::awt::XWindow> pcr::CommonBehaviourControl::getControlWindow() class com::sun::star::uno::Reference<class com::sun::star::inspection::XPropertyControlContext> pcr::CommonBehaviourControl::getControlContext()
extensions/source/propctrlr/commoncontrol.hxx:135 extensions/source/propctrlr/commoncontrol.hxx:135
unsigned char pcr::CommonBehaviourControl::isModified() void pcr::CommonBehaviourControl::setControlContext(const class com::sun::star::uno::Reference<class com::sun::star::inspection::XPropertyControlContext> &,)
extensions/source/propctrlr/commoncontrol.hxx:137 extensions/source/propctrlr/commoncontrol.hxx:137
void pcr::CommonBehaviourControl::notifyModifiedValue() class com::sun::star::uno::Reference<class com::sun::star::awt::XWindow> pcr::CommonBehaviourControl::getControlWindow()
extensions/source/propctrlr/commoncontrol.hxx:139
unsigned char pcr::CommonBehaviourControl::isModified()
extensions/source/propctrlr/commoncontrol.hxx:141 extensions/source/propctrlr/commoncontrol.hxx:141
void pcr::CommonBehaviourControl::notifyModifiedValue()
extensions/source/propctrlr/commoncontrol.hxx:156
void pcr::CommonBehaviourControl::disposing() void pcr::CommonBehaviourControl::disposing()
forms/source/xforms/datatypes.hxx:234 forms/source/xforms/datatypes.hxx:234
class cppu::IPropertyArrayHelper * xforms::ODerivedDataType::createArrayHelper()const class cppu::IPropertyArrayHelper * xforms::ODerivedDataType::createArrayHelper()const
@@ -52,10 +52,6 @@ forms/source/xforms/namedcollection.hxx:99
class com::sun::star::uno::Sequence<class rtl::OUString> NamedCollection::getElementNames() class com::sun::star::uno::Sequence<class rtl::OUString> NamedCollection::getElementNames()
forms/source/xforms/namedcollection.hxx:104 forms/source/xforms/namedcollection.hxx:104
unsigned char NamedCollection::hasByName(const class rtl::OUString &,) unsigned char NamedCollection::hasByName(const class rtl::OUString &,)
fpicker/source/office/fileview.cxx:139
void ViewTabListBox_Impl::~ViewTabListBox_Impl()
fpicker/source/office/fileview.hxx:76
void SvtFileView::~SvtFileView()
include/basegfx/utils/unopolypolygon.hxx:97 include/basegfx/utils/unopolypolygon.hxx:97
void basegfx::unotools::UnoPolyPolygon::modifying()const void basegfx::unotools::UnoPolyPolygon::modifying()const
include/comphelper/interaction.hxx:54 include/comphelper/interaction.hxx:54
@@ -86,8 +82,8 @@ include/svl/svdde.hxx:244
_Bool DdeTopic::StartAdviseLoop() _Bool DdeTopic::StartAdviseLoop()
include/svl/svdde.hxx:300 include/svl/svdde.hxx:300
void DdeService::~DdeService() void DdeService::~DdeService()
include/svx/svdpage.hxx:111 include/svx/svdtext.hxx:60
void SdrObjList::sort(class std::__debug::vector<int, class std::allocator<int> > &,) const class SfxItemSet & SdrText::GetItemSet()const
include/toolkit/controls/geometrycontrolmodel.hxx:183 include/toolkit/controls/geometrycontrolmodel.hxx:183
void OGeometryControlModel::fillProperties(class com::sun::star::uno::Sequence<struct com::sun::star::beans::Property> &,class com::sun::star::uno::Sequence<struct com::sun::star::beans::Property> &,)const void OGeometryControlModel::fillProperties(class com::sun::star::uno::Sequence<struct com::sun::star::beans::Property> &,class com::sun::star::uno::Sequence<struct com::sun::star::beans::Property> &,)const
include/vbahelper/vbacollectionimpl.hxx:290 include/vbahelper/vbacollectionimpl.hxx:290
@@ -114,24 +110,18 @@ include/vbahelper/vbareturntypes.hxx:41
type-parameter-0-0 ooo::vba::DefaultReturnHelper::getValue() type-parameter-0-0 ooo::vba::DefaultReturnHelper::getValue()
include/vcl/customweld.hxx:41 include/vcl/customweld.hxx:41
class rtl::OUString weld::CustomWidgetController::GetHelpText()const class rtl::OUString weld::CustomWidgetController::GetHelpText()const
include/vcl/dialog.hxx:115 include/vcl/weld.hxx:101
short Dialog::Execute()
include/vcl/dialog.hxx:138
_Bool Dialog::StartExecuteAsync(struct VclAbstractDialog::AsyncContext &,)
include/vcl/weld.hxx:100
void weld::Widget::set_visible(_Bool,) void weld::Widget::set_visible(_Bool,)
sc/source/core/opencl/formulagroupcl.cxx:1051 sc/source/core/opencl/formulagroupcl.cxx:1054
_Bool sc::opencl::DynamicKernelSlidingArgument::NeedParallelReduction()const _Bool sc::opencl::(anonymous namespace)::DynamicKernelSlidingArgument::NeedParallelReduction()const
sc/source/core/opencl/formulagroupcl.cxx:1059 sc/source/core/opencl/formulagroupcl.cxx:1062
void sc::opencl::DynamicKernelSlidingArgument::GenSlidingWindowFunction(class std::__cxx11::basic_stringstream<char> &,) void sc::opencl::(anonymous namespace)::DynamicKernelSlidingArgument::GenSlidingWindowFunction(class std::__cxx11::basic_stringstream<char> &,)
sc/source/core/opencl/formulagroupcl.cxx:1338 sc/source/core/opencl/formulagroupcl.cxx:1345
void sc::opencl::ParallelReductionVectorRef::GenSlidingWindowFunction(class std::__cxx11::basic_stringstream<char> &,) void sc::opencl::(anonymous namespace)::ParallelReductionVectorRef::GenSlidingWindowFunction(class std::__cxx11::basic_stringstream<char> &,)
sc/source/core/opencl/formulagroupcl.cxx:1518 sc/source/core/opencl/formulagroupcl.cxx:1347
class std::__cxx11::basic_string<char, struct std::char_traits<char>, class std::allocator<char> > sc::opencl::ParallelReductionVectorRef::GenSlidingWindowDeclRef(_Bool,)const class std::__cxx11::basic_string<char, struct std::char_traits<char>, class std::allocator<char> > sc::opencl::(anonymous namespace)::ParallelReductionVectorRef::GenSlidingWindowDeclRef(_Bool,)const
sc/source/core/opencl/formulagroupcl.cxx:1553 sc/source/core/opencl/formulagroupcl.cxx:1361
unsigned long sc::opencl::ParallelReductionVectorRef::Marshal(struct _cl_kernel *,int,int,struct _cl_program *,) unsigned long sc::opencl::(anonymous namespace)::ParallelReductionVectorRef::Marshal(struct _cl_kernel *,int,int,struct _cl_program *,)
sc/source/ui/inc/AccessibleContextBase.hxx:74
_Bool ScAccessibleContextBase::isShowing()
sc/source/ui/vba/vbacondition.hxx:41 sc/source/ui/vba/vbacondition.hxx:41
class rtl::OUString ScVbaCondition::Formula1() class rtl::OUString ScVbaCondition::Formula1()
sc/source/ui/vba/vbacondition.hxx:42 sc/source/ui/vba/vbacondition.hxx:42
@@ -212,20 +202,22 @@ slideshow/source/engine/activities/activitiesfactory.cxx:538
void slideshow::internal::(anonymous namespace)::ValuesActivity::endAnimation() void slideshow::internal::(anonymous namespace)::ValuesActivity::endAnimation()
slideshow/source/engine/activities/activitiesfactory.cxx:583 slideshow/source/engine/activities/activitiesfactory.cxx:583
void slideshow::internal::(anonymous namespace)::ValuesActivity::performEnd() void slideshow::internal::(anonymous namespace)::ValuesActivity::performEnd()
slideshow/source/engine/animationfactory.cxx:441 slideshow/source/engine/animationfactory.cxx:439
void slideshow::internal::(anonymous namespace)::GenericAnimation::prefetch() void slideshow::internal::(anonymous namespace)::GenericAnimation::prefetch()
slideshow/source/engine/animationfactory.cxx:444 slideshow/source/engine/animationfactory.cxx:442
void slideshow::internal::(anonymous namespace)::GenericAnimation::start(const class std::shared_ptr<class slideshow::internal::AnimatableShape> &,const class std::shared_ptr<class slideshow::internal::ShapeAttributeLayer> &,) void slideshow::internal::(anonymous namespace)::GenericAnimation::start(const class std::shared_ptr<class slideshow::internal::AnimatableShape> &,const class std::shared_ptr<class slideshow::internal::ShapeAttributeLayer> &,)
sw/inc/flypos.hxx:37 sw/inc/flypos.hxx:37
void SwPosFlyFrame::~SwPosFlyFrame() void SwPosFlyFrame::~SwPosFlyFrame()
sw/source/core/inc/dflyobj.hxx:55
void SwFlyDrawObj::SetTextBox(_Bool,)
vcl/inc/salframe.hxx:145 vcl/inc/salframe.hxx:145
void SalFrame::SetRepresentedURL(const class rtl::OUString &,) void SalFrame::SetRepresentedURL(const class rtl::OUString &,)
vcl/inc/salframe.hxx:191 vcl/inc/salframe.hxx:191
void SalFrame::Flush(const class tools::Rectangle &,) void SalFrame::Flush(const class tools::Rectangle &,)
vcl/inc/salinst.hxx:92 vcl/inc/salinst.hxx:92
_Bool SalInstance::SVMainHook(int *,) _Bool SalInstance::SVMainHook(int *,)
vcl/inc/salinst.hxx:202
void SalInstance::releaseMainThread()
vcl/inc/salmenu.hxx:71
void SalMenu::SetItemBits(unsigned int,enum MenuItemBits,)
vcl/inc/salmenu.hxx:80 vcl/inc/salmenu.hxx:80
_Bool SalMenu::AddMenuBarButton(const struct SalMenuButtonItem &,) _Bool SalMenu::AddMenuBarButton(const struct SalMenuButtonItem &,)
vcl/inc/salmenu.hxx:81 vcl/inc/salmenu.hxx:81
@@ -236,11 +228,11 @@ vcl/inc/salobj.hxx:49
void SalObject::Enable(_Bool,) void SalObject::Enable(_Bool,)
vcl/inc/salprn.hxx:116 vcl/inc/salprn.hxx:116
enum SalPrinterError SalPrinter::GetErrorCode() enum SalPrinterError SalPrinter::GetErrorCode()
vcl/inc/unx/glyphcache.hxx:54 vcl/inc/skia/gdiimpl.hxx:210
void FreetypeManager::~FreetypeManager() void SkiaSalGraphicsImpl::createSurface()
vcl/inc/unx/gtk/gtkdata.hxx:136 vcl/inc/unx/gtk/gtkdata.hxx:121
int GtkSalDisplay::CaptureMouse(class SalFrame *,) int GtkSalDisplay::CaptureMouse(class SalFrame *,)
vcl/inc/unx/saldata.hxx:51 vcl/inc/unx/saldata.hxx:50
void X11SalData::Init() void X11SalData::Init()
vcl/inc/unx/saldisp.hxx:182 vcl/inc/unx/saldisp.hxx:182
void SalXLib::~SalXLib() void SalXLib::~SalXLib()
@@ -264,22 +256,8 @@ vcl/inc/unx/saldisp.hxx:406
void SalX11Display::Yield() void SalX11Display::Yield()
vcl/inc/unx/salframe.h:207 vcl/inc/unx/salframe.h:207
void X11SalFrame::updateGraphics(_Bool,) void X11SalFrame::updateGraphics(_Bool,)
vcl/inc/unx/salinst.h:45 vcl/inc/unx/salinst.h:44
class SalX11Display * X11SalInstance::CreateDisplay()const class SalX11Display * X11SalInstance::CreateDisplay()const
workdir/../vcl/inc/qt5/Qt5FilePicker.hxx:145
void Qt5FilePicker::disposing(const struct com::sun::star::lang::EventObject &,)
workdir/../vcl/inc/qt5/Qt5FilePicker.hxx:161
void Qt5FilePicker::addCustomControl(short,)
workdir/../vcl/inc/qt5/Qt5Frame.hxx:160
void Qt5Frame::registerDragSource(class Qt5DragSource *,)
workdir/../vcl/inc/qt5/Qt5Frame.hxx:161
void Qt5Frame::deregisterDragSource(const class Qt5DragSource *,)
workdir/../vcl/inc/qt5/Qt5Frame.hxx:162
void Qt5Frame::registerDropTarget(class Qt5DropTarget *,)
workdir/../vcl/inc/qt5/Qt5Frame.hxx:163
void Qt5Frame::deregisterDropTarget(const class Qt5DropTarget *,)
workdir/../vcl/inc/qt5/Qt5Instance.hxx:82
class Qt5FilePicker * Qt5Instance::createPicker(const class com::sun::star::uno::Reference<class com::sun::star::uno::XComponentContext> &,enum QFileDialog::FileMode,)
writerfilter/source/ooxml/OOXMLFactory.hxx:72 writerfilter/source/ooxml/OOXMLFactory.hxx:72
void writerfilter::ooxml::OOXMLFactory_ns::startAction(class writerfilter::ooxml::OOXMLFastContextHandler *,) void writerfilter::ooxml::OOXMLFactory_ns::startAction(class writerfilter::ooxml::OOXMLFastContextHandler *,)
writerfilter/source/ooxml/OOXMLFactory.hxx:73 writerfilter/source/ooxml/OOXMLFactory.hxx:73

2
include/svx/svdtext.hxx
View File

@@ -57,7 +57,7 @@ public:
// default uses GetObjectItemSet, but may be overridden to // default uses GetObjectItemSet, but may be overridden to
// return a text-specific ItemSet // return a text-specific ItemSet
virtual const SfxItemSet& GetItemSet() const; const SfxItemSet& GetItemSet() const;
// This class does not need an own SdrModel reference - always // This class does not need an own SdrModel reference - always
// has the SdrTextObj working with so can use SdrModel::getSdrModelFromSdrObject() // has the SdrTextObj working with so can use SdrModel::getSdrModelFromSdrObject()