mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:finalclasses in vcl

Browse Source 
Change-Id: I7de9cd6c5569217aa8d379c6d112cd1874bca8e2
Reviewed-on: https://gerrit.libreoffice.org/43151
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2017-10-05 07:50:24 +02:00
parent e5d943d984
commit e1261e6ea6
20 changed files with 35 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
compilerplugins/clang/finalclasses.cxx
View File

@@ -57,7 +57,11 @@ public:
bool shouldVisitTemplateInstantiations () const { return true; }
bool shouldVisitImplicitCode() const { return true; }
bool VisitCXXRecordDecl( const CXXRecordDecl* decl);
private:
void checkBase(QualType qt);
};
bool startsWith(const std::string& rStr, const char* pSubStr) {
@@ -81,23 +85,18 @@ bool FinalClasses::VisitCXXRecordDecl(const CXXRecordDecl* decl)
if (ignoreLocation(decl))
return true;
decl = decl->getCanonicalDecl();
if (!decl->isThisDeclarationADefinition())
if (!decl->hasDefinition())
return true;
for (auto it = decl->bases_begin(); it != decl->bases_end(); ++it)
{
const CXXBaseSpecifier spec = *it;
// need to look through typedefs, hence the getUnqualifiedDesugaredType
QualType baseType = spec.getType().getDesugaredType(compiler.getASTContext());
std::string x;
// so that we get just the template name, excluding the template parameters
if (baseType->isRecordType())
x = baseType->getAsCXXRecordDecl()->getQualifiedNameAsString();
else if (auto templateType = baseType->getAs<TemplateSpecializationType>())
x = templateType->getTemplateName().getAsTemplateDecl()->getQualifiedNameAsString();
else
x = baseType.getAsString();
inheritedFromSet.insert( x );
checkBase(spec.getType());
}
for (auto it = decl->vbases_begin(); it != decl->vbases_end(); ++it)
{
const CXXBaseSpecifier spec = *it;
checkBase(spec.getType());
}
bool bFoundProtected = false;
@@ -135,6 +134,21 @@ bool FinalClasses::VisitCXXRecordDecl(const CXXRecordDecl* decl)
return true;
}
void FinalClasses::checkBase(QualType baseType)
{
// need to look through typedefs, hence the getUnqualifiedDesugaredType
baseType = baseType.getDesugaredType(compiler.getASTContext());
std::string x;
// so that we get just the template name, excluding the template parameters
if (baseType->isRecordType())
x = baseType->getAsCXXRecordDecl()->getQualifiedNameAsString();
else if (auto templateType = baseType->getAs<TemplateSpecializationType>())
x = templateType->getTemplateName().getAsTemplateDecl()->getQualifiedNameAsString();
else
x = baseType.getAsString();
inheritedFromSet.insert( x );
}
loplugin::Plugin::Registration< FinalClasses > X("finalclasses", false);
}