mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve loplugin:unreffun

Browse Source 
...to avoid a false positive in --enable-qt5

> [build CXX] vcl/qt5/Qt5Widget.cxx
> /home/sbergman/lo/core/vcl/qt5/Qt5Widget.cxx:466:21: error: Unreferenced function declaration [loplugin:unreffun]
>     friend QWidget* createQt5Widget(Qt5Frame& rFrame, QWidget* parent, Qt::WindowFlags f);
>     ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 1 error generated.

Change-Id: I01e47bc5f5147916737d62fe18ce5312a0221a3f
Reviewed-on: https://gerrit.libreoffice.org/55189
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
This commit is contained in:
Stephan Bergmann
2018-06-01 16:22:53 +02:00
parent 29dbb86409
commit e1ab044401
4 changed files with 61 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
compilerplugins/clang/unreffun.cxx
View File

@@ -58,7 +58,18 @@ public:
void run() override
{ TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); }
bool TraverseFriendDecl(FriendDecl * decl) {
auto const old = friendFunction_;
friendFunction_ = dyn_cast_or_null<FunctionDecl>(decl->getFriendDecl());
auto const ret = RecursiveASTVisitor::TraverseFriendDecl(decl);
friendFunction_ = old;
return ret;
}
bool VisitFunctionDecl(FunctionDecl const * decl);
private:
FunctionDecl const * friendFunction_ = nullptr;
};
bool UnrefFun::VisitFunctionDecl(FunctionDecl const * decl) {
@@ -74,6 +85,13 @@ bool UnrefFun::VisitFunctionDecl(FunctionDecl const * decl) {
{
return true;
}
if (decl == friendFunction_) {
if (auto const lex = dyn_cast<CXXRecordDecl>(decl->getLexicalDeclContext())) {
if (lex->isDependentContext()) {
return true;
}
}
}
if (!(decl->isThisDeclarationADefinition() || isFriendDecl(decl)
|| decl->isFunctionTemplateSpecialization()))