mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

coverity#1325250 Unchecked dynamic_cast

Browse Source 
Change-Id: Id52cad11d2ca4ef42a31c0905ee123ccd53e0677
This commit is contained in:
Caolán McNamara
2015-10-01 14:12:06 +01:00
parent 792d507eec
commit e31cd8f3ae
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
basic/source/classes/sbunoobj.cxx
View File

@@ -135,15 +135,14 @@ SbxVariable* getDefaultProp( SbxVariable* pRef )
SbxVariable* pDefaultProp = NULL; SbxVariable* pDefaultProp = NULL;
if ( pRef->GetType() == SbxOBJECT ) if ( pRef->GetType() == SbxOBJECT )
{ {
SbxObject* pObj = dynamic_cast<SbxObject*>( pRef ); SbxObject* pObj = dynamic_cast<SbxObject*>(pRef);
if ( !pObj ) if (!pObj)
{ {
SbxBase* pObjVarObj = pRef->GetObject(); SbxBase* pObjVarObj = pRef->GetObject();
pObj = dynamic_cast<SbxObject*>( pObjVarObj ); pObj = dynamic_cast<SbxObject*>( pObjVarObj );
} }
if ( pObj && 0 != dynamic_cast<const SbUnoObject*>( pObj) ) if (SbUnoObject* pUnoObj = dynamic_cast<SbUnoObject*>(pObj))
{ {
SbUnoObject* pUnoObj = dynamic_cast<SbUnoObject*>( pObj );
pDefaultProp = pUnoObj->GetDfltProperty(); pDefaultProp = pUnoObj->GetDfltProperty();
} }
} }