Adapt loplugin:nullptr to RecursiveASTVisitior::TraverseInitListExpr change

...<https://github.com/llvm/llvm-project/commit/
0a42fe70a566f22599e04a6f1344ca2dc5565e17> "[AST] Treat semantic form of
InitListExpr as implicit code in traversals"

Change-Id: Ifd17009fcc6933abf0e9178dbe47fb9c14b274b7
Reviewed-on: https://gerrit.libreoffice.org/77595
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
This commit is contained in:
Stephan Bergmann
2019-08-16 16:25:48 +02:00
parent 91e213f58f
commit e380e35348
3 changed files with 32 additions and 0 deletions

View File

@@ -75,6 +75,8 @@ public:
bool TraverseLinkageSpecDecl(LinkageSpecDecl * decl); bool TraverseLinkageSpecDecl(LinkageSpecDecl * decl);
bool TraverseInitListExpr(InitListExpr * expr, DataRecursionQueue * queue = nullptr);
// bool shouldVisitTemplateInstantiations() const { return true; } // bool shouldVisitTemplateInstantiations() const { return true; }
private: private:
@@ -231,6 +233,12 @@ bool Nullptr::TraverseLinkageSpecDecl(LinkageSpecDecl * decl) {
return ret; return ret;
} }
bool Nullptr::TraverseInitListExpr(InitListExpr * expr, DataRecursionQueue * queue) {
return WalkUpFromInitListExpr(expr)
&& TraverseSynOrSemInitListExpr(
expr->isSemanticForm() ? expr : expr->getSemanticForm(), queue);
}
bool Nullptr::isInLokIncludeFile(SourceLocation spellingLocation) const { bool Nullptr::isInLokIncludeFile(SourceLocation spellingLocation) const {
return loplugin::hasPathnamePrefix( return loplugin::hasPathnamePrefix(
getFileNameOfSpellingLoc(spellingLocation), getFileNameOfSpellingLoc(spellingLocation),

View File

@@ -0,0 +1,23 @@
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
struct S
{
void* p;
};
int main()
{
S s{
0 // expected-error {{NullToPointer ValueDependentIsNotNull ZeroLiteral -> nullptr [loplugin:nullptr]}}
};
(void)s;
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */

View File

@@ -36,6 +36,7 @@ $(eval $(call gb_CompilerTest_add_exception_objects,compilerplugins_clang, \
compilerplugins/clang/test/indentation \ compilerplugins/clang/test/indentation \
compilerplugins/clang/test/logexceptionnicely \ compilerplugins/clang/test/logexceptionnicely \
compilerplugins/clang/test/loopvartoosmall \ compilerplugins/clang/test/loopvartoosmall \
compilerplugins/clang/test/nullptr \
compilerplugins/clang/test/mapindex \ compilerplugins/clang/test/mapindex \
compilerplugins/clang/test/oncevar \ compilerplugins/clang/test/oncevar \
compilerplugins/clang/test/oslendian-1 \ compilerplugins/clang/test/oslendian-1 \