mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Minor improvements of loplugin:staticaccess

Browse Source 
Change-Id: I731aab418fb42922208afdaa60d98ccd76377dab
This commit is contained in:
Stephan Bergmann
2016-08-26 12:35:24 +02:00
parent aa67fed597
commit e3e66f7b07
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
compilerplugins/clang/staticaccess.cxx
View File

@@ -18,7 +18,9 @@ bool isStatic(ValueDecl const * decl, bool * memberEnumerator) {
// clang::MemberExpr::getMemberDecl is documented to return either a // clang::MemberExpr::getMemberDecl is documented to return either a
// FieldDecl or a CXXMethodDecl, but can apparently also return a VarDecl // FieldDecl or a CXXMethodDecl, but can apparently also return a VarDecl
// (as C++ static data members are modeled by VarDecl, not FieldDecl) or an // (as C++ static data members are modeled by VarDecl, not FieldDecl) or an
// EnumConstantDecl (struct { enum {E}; } s; s.E;): // EnumConstantDecl (struct { enum {E}; } s; s.E;), see
// <https://reviews.llvm.org/D23907> "Fix documentation of
// MemberExpr::getMemberDecl":
auto fd = dyn_cast<FieldDecl>(decl); auto fd = dyn_cast<FieldDecl>(decl);
if (fd != nullptr) { if (fd != nullptr) {
*memberEnumerator = false; *memberEnumerator = false;
@@ -27,7 +29,8 @@ bool isStatic(ValueDecl const * decl, bool * memberEnumerator) {
auto vd = dyn_cast<VarDecl>(decl); auto vd = dyn_cast<VarDecl>(decl);
if (vd != nullptr) { if (vd != nullptr) {
*memberEnumerator = false; *memberEnumerator = false;
return vd->isStaticDataMember(); assert(vd->isStaticDataMember());
return true;
} }
auto md = dyn_cast<CXXMethodDecl>(decl); auto md = dyn_cast<CXXMethodDecl>(decl);
if (md != nullptr) { if (md != nullptr) {