mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

sd_export_tests-ooxml2: don't use try/catch in this test

Browse Source 
In general, try/catch shouldn't be used in unittests
Follow-up of 9564747d2f
"tdf#53970 PPTX: fix import of linked media files"

Change-Id: Ibde31d033b0225ab47522eff01e156cbb2751f18
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133468
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
This commit is contained in:
Xisco Fauli
2022-04-27 09:50:29 +02:00
parent 42eeddb2e6
commit e678e013a9
1 changed files with 4 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
sd/qa/unit/export-tests-ooxml2.cxx
View File

@@ -1832,16 +1832,10 @@ void SdOOXMLExportTest2::testTdf53970()
CPPUNIT_ASSERT(xShape.is()); CPPUNIT_ASSERT(xShape.is());
OUString sVideoURL; OUString sVideoURL;
// Without fix in place, the media shape was imported as an image after export. // Without fix in place, the media shape was imported as an image after export
try // and this test would have failed with exception of type com.sun.star.beans.UnknownPropertyException
{ CPPUNIT_ASSERT_MESSAGE("MediaURL property is not set",
CPPUNIT_ASSERT_MESSAGE("MediaURL property is not set", xShape->getPropertyValue("MediaURL") >>= sVideoURL);
xShape->getPropertyValue("MediaURL") >>= sVideoURL);
}
catch (const beans::UnknownPropertyException&)
{
CPPUNIT_FAIL("Error: MediaURL is unknown property");
}
CPPUNIT_ASSERT_MESSAGE("MediaURL is empty", !sVideoURL.isEmpty()); CPPUNIT_ASSERT_MESSAGE("MediaURL is empty", !sVideoURL.isEmpty());
xDocShRef->DoClose(); xDocShRef->DoClose();