mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cid#1607892 COPY_INSTEAD_OF_MOVE

Browse Source 
and

cid#1607910 COPY_INSTEAD_OF_MOVE
cid#1607818 COPY_INSTEAD_OF_MOVE
cid#1557402 COPY_INSTEAD_OF_MOVE
cid#1556530 COPY_INSTEAD_OF_MOVE
cid#1557396 COPY_INSTEAD_OF_MOVE
cid#1556522 COPY_INSTEAD_OF_MOVE
cid#1555628 COPY_INSTEAD_OF_MOVE
cid#1554705 COPY_INSTEAD_OF_MOVE

Change-Id: Iae3fbf4a04bf3714f416995640b9d70fe204cf73
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170321
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
This commit is contained in:
Caolán McNamara
2024-07-10 17:12:06 +01:00
parent 3aac0f9b37
commit e68f28ec9f
9 changed files with 16 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
chart2/source/controller/main/ChartController_Insert.cxx
View File

@@ -101,7 +101,8 @@ void ChartController::executeDispatch_InsertAxes()
SolarMutexGuard aGuard; SolarMutexGuard aGuard;
auto aDlg = std::make_shared<SchAxisDlg>(GetChartFrame(), *aDialogInput); auto aDlg = std::make_shared<SchAxisDlg>(GetChartFrame(), *aDialogInput);
weld::DialogController::runAsync(aDlg, [this, aDlg, aDialogInput, xUndoGuard=std::move(xUndoGuard)](int nResult) { weld::DialogController::runAsync(aDlg, [this, aDlg, aDialogInput=std::move(aDialogInput),
xUndoGuard=std::move(xUndoGuard)](int nResult) {
if ( nResult == RET_OK ) if ( nResult == RET_OK )
{ {
// lock controllers till end of block // lock controllers till end of block

2
chart2/source/model/main/Diagram.cxx
View File

@@ -1230,7 +1230,7 @@ static std::vector< rtl::Reference< Axis > > lcl_getAxisHoldingCategoriesFromDia
aRet.push_back(xAxis); aRet.push_back(xAxis);
} }
if( (nN == 0) && !xFallBack.is()) if( (nN == 0) && !xFallBack.is())
xFallBack = xAxis; xFallBack = std::move(xAxis);
} }
} }
} }

2
dbaccess/source/core/api/RowSetCache.cxx
View File

@@ -605,7 +605,7 @@ void ORowSetCache::updateObject( sal_Int32 columnIndex, const Any& x
if ( rInsert[columnIndex] != aTemp ) if ( rInsert[columnIndex] != aTemp )
{ {
rInsert[columnIndex].setBound(true); rInsert[columnIndex].setBound(true);
rInsert[columnIndex] = aTemp; rInsert[columnIndex] = std::move(aTemp);
rInsert[columnIndex].setModified(true); rInsert[columnIndex].setModified(true);
io_aRow[columnIndex] = rInsert[columnIndex]; io_aRow[columnIndex] = rInsert[columnIndex];

2
editeng/source/accessibility/AccessibleEditableTextPara.cxx
View File

@@ -2372,7 +2372,7 @@ namespace accessibility
{ {
continue; continue;
} }
pProperties[ nCurLen++ ] = aProp; pProperties[nCurLen++] = std::move(aProp);
} }
aProperties.realloc( nCurLen ); aProperties.realloc( nCurLen );
} }

4
pyuno/source/module/pyuno_callable.cxx
View File

@@ -128,11 +128,11 @@ static PyObject* PyUNO_callable_call(
PyRef ref = runtime.any2PyObject( aOutParam[i] ); PyRef ref = runtime.any2PyObject( aOutParam[i] );
PyTuple_SetItem (return_list.get(), 1+i, ref.getAcquired()); PyTuple_SetItem (return_list.get(), 1+i, ref.getAcquired());
} }
ret = return_list; ret = std::move(return_list);
} }
else else
{ {
ret = temp; ret = std::move(temp);
} }
} }
catch( const css::reflection::InvocationTargetException & e ) catch( const css::reflection::InvocationTargetException & e )

5
sc/source/filter/excel/excel.cxx
View File

@@ -185,9 +185,8 @@ ErrCode ScFormatFilterPluginImpl::ScImportExcel( SfxMedium& rMedium, ScDocument*
rtl::Reference<SotStorageStream> xDRMStrm = ScfTools::OpenStorageStreamRead(xRootStrg, u"\011DRMContent"_ustr); rtl::Reference<SotStorageStream> xDRMStrm = ScfTools::OpenStorageStreamRead(xRootStrg, u"\011DRMContent"_ustr);
if (xDRMStrm.is()) if (xDRMStrm.is())
{ {
auto pDecryptedStorage = lcl_DRMDecrypt(rMedium, xRootStrg, aNewStorageStrm); if (auto xDecryptedStorage = lcl_DRMDecrypt(rMedium, xRootStrg, aNewStorageStrm))
if (pDecryptedStorage) xRootStrg = std::move(xDecryptedStorage);
xRootStrg = pDecryptedStorage;
else else
{ {
bUnableToDecryptContent = true; bUnableToDecryptContent = true;

6
sd/source/filter/eppt/pptx-text.cxx
View File

@@ -356,9 +356,9 @@ void PortionObj::ImplGetPortionValues( FontCollection& rFontCollection, bool bGe
} }
if ( GetPropertyValue( mAny, mXPropSet, aCharLocaleName ) ) if ( GetPropertyValue( mAny, mXPropSet, aCharLocaleName ) )
{ {
css::lang::Locale eLocale; css::lang::Locale aLocale;
if ( mAny >>= eLocale ) if ( mAny >>= aLocale )
meCharLocale = eLocale; meCharLocale = std::move(aLocale);
} }
if ( GetPropertyValue( mAny, mXPropSet, aCharPostureName ) ) if ( GetPropertyValue( mAny, mXPropSet, aCharPostureName ) )
{ {

6
svgio/source/svgreader/svgnode.cxx
View File

@@ -527,10 +527,8 @@ namespace {
{ {
SvgStringVector aSvgStringVector; SvgStringVector aSvgStringVector;
if(readSvgStringVector(aContent, aSvgStringVector, ',')) if (readSvgStringVector(aContent, aSvgStringVector, ','))
{ maSystemLanguage = std::move(aSvgStringVector);
maSystemLanguage = aSvgStringVector;
}
break; break;
} }
case SVGToken::XmlSpace: case SVGToken::XmlSpace:

4
sw/source/filter/html/htmltab.cxx
View File

@@ -775,8 +775,8 @@ std::unique_ptr<SwHTMLTableLayoutCell> HTMLTableCell::CreateLayoutInfo()
std::shared_ptr<SwHTMLTableLayoutCnts> xCntInfo; std::shared_ptr<SwHTMLTableLayoutCnts> xCntInfo;
if (m_xContents) if (m_xContents)
xCntInfo = m_xContents->CreateLayoutInfo(); xCntInfo = m_xContents->CreateLayoutInfo();
return std::unique_ptr<SwHTMLTableLayoutCell>(new SwHTMLTableLayoutCell(xCntInfo, m_nRowSpan, m_nColSpan, m_nWidth, return std::unique_ptr<SwHTMLTableLayoutCell>(new SwHTMLTableLayoutCell(std::move(xCntInfo),
m_bRelWidth, m_bNoWrap)); m_nRowSpan, m_nColSpan, m_nWidth, m_bRelWidth, m_bNoWrap));
} }
HTMLTableRow::HTMLTableRow(sal_uInt16 const nCells) HTMLTableRow::HTMLTableRow(sal_uInt16 const nCells)