cid#1607892 COPY_INSTEAD_OF_MOVE

and

cid#1607910 COPY_INSTEAD_OF_MOVE
cid#1607818 COPY_INSTEAD_OF_MOVE
cid#1557402 COPY_INSTEAD_OF_MOVE
cid#1556530 COPY_INSTEAD_OF_MOVE
cid#1557396 COPY_INSTEAD_OF_MOVE
cid#1556522 COPY_INSTEAD_OF_MOVE
cid#1555628 COPY_INSTEAD_OF_MOVE
cid#1554705 COPY_INSTEAD_OF_MOVE

Change-Id: Iae3fbf4a04bf3714f416995640b9d70fe204cf73
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170321
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

chart2/source/controller/main/ChartController_Insert.cxx

@@ -101,7 +101,8 @@ void ChartController::executeDispatch_InsertAxes()
 
         SolarMutexGuard aGuard;
         auto aDlg = std::make_shared<SchAxisDlg>(GetChartFrame(), *aDialogInput);
-        weld::DialogController::runAsync(aDlg, [this, aDlg, aDialogInput, xUndoGuard=std::move(xUndoGuard)](int nResult) {
+        weld::DialogController::runAsync(aDlg, [this, aDlg, aDialogInput=std::move(aDialogInput),
+                                                xUndoGuard=std::move(xUndoGuard)](int nResult) {
             if ( nResult == RET_OK )
             {
                 // lock controllers till end of block

chart2/source/model/main/Diagram.cxx

@@ -1230,7 +1230,7 @@ static std::vector< rtl::Reference< Axis > > lcl_getAxisHoldingCategoriesFromDia
                             aRet.push_back(xAxis);
                         }
                         if( (nN == 0) && !xFallBack.is())
-                            xFallBack = xAxis;
+                            xFallBack = std::move(xAxis);
                     }
                 }
             }

dbaccess/source/core/api/RowSetCache.cxx

@@ -605,7 +605,7 @@ void ORowSetCache::updateObject( sal_Int32 columnIndex, const Any& x
     if ( rInsert[columnIndex] != aTemp )
     {
         rInsert[columnIndex].setBound(true);
-        rInsert[columnIndex] = aTemp;
+        rInsert[columnIndex] = std::move(aTemp);
         rInsert[columnIndex].setModified(true);
         io_aRow[columnIndex] = rInsert[columnIndex];
 

editeng/source/accessibility/AccessibleEditableTextPara.cxx

@@ -2372,7 +2372,7 @@ namespace accessibility
                 {
                     continue;
                 }
-                pProperties[ nCurLen++ ] = aProp;
+                pProperties[nCurLen++] = std::move(aProp);
             }
             aProperties.realloc( nCurLen );
         }

pyuno/source/module/pyuno_callable.cxx

@@ -128,11 +128,11 @@ static PyObject* PyUNO_callable_call(
                 PyRef ref = runtime.any2PyObject( aOutParam[i] );
                 PyTuple_SetItem (return_list.get(), 1+i, ref.getAcquired());
             }
-            ret = return_list;
+            ret = std::move(return_list);
         }
         else
         {
-            ret = temp;
+            ret = std::move(temp);
         }
     }
     catch( const css::reflection::InvocationTargetException & e )

sc/source/filter/excel/excel.cxx

@@ -185,9 +185,8 @@ ErrCode ScFormatFilterPluginImpl::ScImportExcel( SfxMedium& rMedium, ScDocument*
         rtl::Reference<SotStorageStream> xDRMStrm = ScfTools::OpenStorageStreamRead(xRootStrg, u"\011DRMContent"_ustr);
         if (xDRMStrm.is())
         {
-            auto pDecryptedStorage = lcl_DRMDecrypt(rMedium, xRootStrg, aNewStorageStrm);
-            if (pDecryptedStorage)
-                xRootStrg = pDecryptedStorage;
+            if (auto xDecryptedStorage = lcl_DRMDecrypt(rMedium, xRootStrg, aNewStorageStrm))
+                xRootStrg = std::move(xDecryptedStorage);
             else
             {
                 bUnableToDecryptContent = true;

sd/source/filter/eppt/pptx-text.cxx

@@ -356,9 +356,9 @@ void PortionObj::ImplGetPortionValues( FontCollection& rFontCollection, bool bGe
     }
     if ( GetPropertyValue( mAny, mXPropSet, aCharLocaleName ) )
     {
-        css::lang::Locale eLocale;
-        if ( mAny >>= eLocale )
-            meCharLocale = eLocale;
+        css::lang::Locale aLocale;
+        if ( mAny >>= aLocale )
+            meCharLocale = std::move(aLocale);
     }
     if ( GetPropertyValue( mAny, mXPropSet, aCharPostureName ) )
     {

svgio/source/svgreader/svgnode.cxx

@@ -527,10 +527,8 @@ namespace {
                 {
                     SvgStringVector aSvgStringVector;
 
-                    if(readSvgStringVector(aContent, aSvgStringVector, ','))
-                    {
-                        maSystemLanguage = aSvgStringVector;
-                    }
+                    if (readSvgStringVector(aContent, aSvgStringVector, ','))
+                        maSystemLanguage = std::move(aSvgStringVector);
                     break;
                 }
                 case SVGToken::XmlSpace:

sw/source/filter/html/htmltab.cxx

@@ -775,8 +775,8 @@ std::unique_ptr<SwHTMLTableLayoutCell> HTMLTableCell::CreateLayoutInfo()
     std::shared_ptr<SwHTMLTableLayoutCnts> xCntInfo;
     if (m_xContents)
         xCntInfo = m_xContents->CreateLayoutInfo();
-    return std::unique_ptr<SwHTMLTableLayoutCell>(new SwHTMLTableLayoutCell(xCntInfo, m_nRowSpan, m_nColSpan, m_nWidth,
-                                      m_bRelWidth, m_bNoWrap));
+    return std::unique_ptr<SwHTMLTableLayoutCell>(new SwHTMLTableLayoutCell(std::move(xCntInfo),
+                                      m_nRowSpan, m_nColSpan, m_nWidth, m_bRelWidth, m_bNoWrap));
 }
 
 HTMLTableRow::HTMLTableRow(sal_uInt16 const nCells)