mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

lopluign:staticmethods: Improve diagnostics

Browse Source 
Change-Id: I6079f387a697c5fe794655e455a19d0cb44b96bc
This commit is contained in:
Stephan Bergmann
2015-05-08 18:55:30 +02:00
parent 127625e8ef
commit e6fa865b4d
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
compilerplugins/clang/staticmethods.cxx
View File

@@ -201,8 +201,15 @@ bool StaticMethods::TraverseCXXMethodDecl(const CXXMethodDecl * pCXXMethodDecl)
report( report(
DiagnosticsEngine::Warning, DiagnosticsEngine::Warning,
"this method can be declared static " + fqn, "this method can be declared static " + fqn,
pCXXMethodDecl->getCanonicalDecl()->getLocStart()) pCXXMethodDecl->getCanonicalDecl()->getLocation())
<< pCXXMethodDecl->getCanonicalDecl()->getSourceRange(); << pCXXMethodDecl->getCanonicalDecl()->getSourceRange();
FunctionDecl const * def;
if (pCXXMethodDecl->isDefined(def)
&& def != pCXXMethodDecl->getCanonicalDecl())
{
report(DiagnosticsEngine::Note, "defined here:", def->getLocation())
<< def->getSourceRange();
}
return true; return true;
} }