mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

The svError case is probably not worth a SAL_WARN

Browse Source 
Also, sort the cases of that block in order of the enumerators.

Change-Id: If46a4ff73d6f7d22bd54b74610eb6eebecd5aff0
This commit is contained in:
Tor Lillqvist
2017-03-30 12:22:49 +03:00
parent 1c2dd8dc14
commit e86d604dc4
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
sc/source/ui/unoobj/tokenuno.cxx
View File

@@ -468,9 +468,10 @@ bool ScTokenConversion::ConvertToTokenSequence( const ScDocument& rDoc,
default: default:
SAL_WARN("sc", "ScTokenConversion::ConvertToTokenSequence: unhandled token type " << StackVarEnumToString(rToken.GetType())); SAL_WARN("sc", "ScTokenConversion::ConvertToTokenSequence: unhandled token type " << StackVarEnumToString(rToken.GetType()));
SAL_FALLTHROUGH; SAL_FALLTHROUGH;
case svSep: // occurs with ocSep, ocOpen, ocClose, ocArray*
case svJump: // occurs with ocIf, ocChoose case svJump: // occurs with ocIf, ocChoose
case svError: // seems to be fairly common, and probably not exceptional and not worth a warning?
case svMissing: // occurs with ocMissing case svMissing: // occurs with ocMissing
case svSep: // occurs with ocSep, ocOpen, ocClose, ocArray*
rAPI.Data.clear(); // no data rAPI.Data.clear(); // no data
} }
rAPI.OpCode = static_cast<sal_Int32>(eOpCode); //! assuming equal values for the moment rAPI.OpCode = static_cast<sal_Int32>(eOpCode); //! assuming equal values for the moment