mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:unusedfields, fix var taking ref

Browse Source 
Change-Id: I0ea1f0c7488c140fca9f64de326c6ac588ece925
This commit is contained in:
Noel Grandin 2017-09-20 16:22:27 +02:00
parent d6e8e522a3
commit e8b5ec6590
3 changed files with 28 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
compilerplugins/clang/test/unusedfields.cxx
View File

@ -116,16 +116,19 @@ struct ReadOnlyAnalysis
// expected-error@-2 {{read m_f3 [loplugin:unusedfields]}} // expected-error@-2 {{read m_f3 [loplugin:unusedfields]}}
// expected-error@-3 {{read m_f4 [loplugin:unusedfields]}} // expected-error@-3 {{read m_f4 [loplugin:unusedfields]}}
// expected-error@-4 {{read m_f5 [loplugin:unusedfields]}} // expected-error@-4 {{read m_f5 [loplugin:unusedfields]}}
// expected-error@-5 {{write m_f2 [loplugin:unusedfields]}} // expected-error@-5 {{read m_f6 [loplugin:unusedfields]}}
// expected-error@-6 {{write m_f3 [loplugin:unusedfields]}} // expected-error@-6 {{write m_f2 [loplugin:unusedfields]}}
// expected-error@-7 {{write m_f4 [loplugin:unusedfields]}} // expected-error@-7 {{write m_f3 [loplugin:unusedfields]}}
// expected-error@-8 {{write m_f5 [loplugin:unusedfields]}} // expected-error@-8 {{write m_f4 [loplugin:unusedfields]}}
// expected-error@-9 {{write m_f5 [loplugin:unusedfields]}}
// expected-error@-10 {{write m_f6 [loplugin:unusedfields]}}
{ {
int m_f1; int m_f1;
int m_f2; int m_f2;
int m_f3; int m_f3;
std::vector<int> m_f4; std::vector<int> m_f4;
int m_f5; int m_f5;
int m_f6;
// check that we dont see a write of m_f1 // check that we dont see a write of m_f1
ReadOnlyAnalysis() : m_f1(0) {} ReadOnlyAnalysis() : m_f1(0) {}
@ -141,6 +144,13 @@ struct ReadOnlyAnalysis
// check that we see a write when we pass by non-const ref // check that we see a write when we pass by non-const ref
void method5() { ReadOnly1 a(m_f5); } void method5() { ReadOnly1 a(m_f5); }
// check that we see a write when we pass by non-const ref
void method6()
{
int& r = m_f6;
r = 1;
}
}; };
struct ReadOnlyAnalysis2 struct ReadOnlyAnalysis2

13
compilerplugins/clang/unusedfields.cxx
View File

@ -611,6 +611,19 @@ void UnusedFields::checkReadOnly(const FieldDecl* fieldDecl, const Expr* memberE
{ {
if (!parent) if (!parent)
{ {
// check if we have an expression like
// int& r = m_field;
auto parentsRange = compiler.getASTContext().getParents(*child);
if (parentsRange.begin() != parentsRange.end())
{
auto varDecl = dyn_cast_or_null<VarDecl>(parentsRange.begin()->get<Decl>());
// The isImplicit() call is to avoid triggering when we see the vardecl which is part of a for-range statement,
// which is of type 'T&&' and also an l-value-ref ?
if (varDecl && !varDecl->isImplicit() && loplugin::TypeCheck(varDecl->getType()).LvalueReference().NonConst())
{
bPotentiallyWrittenTo = true;
}
}
break; break;
} }
if (isa<CXXReinterpretCastExpr>(parent)) if (isa<CXXReinterpretCastExpr>(parent))

4
solenv/CompilerTest_compilerplugins_clang.mk
View File

@ -38,13 +38,11 @@ $(eval $(call gb_CompilerTest_add_exception_objects,compilerplugins_clang, \
compilerplugins/clang/test/unnecessaryoverride-dtor \ compilerplugins/clang/test/unnecessaryoverride-dtor \
compilerplugins/clang/test/unnecessaryparen \ compilerplugins/clang/test/unnecessaryparen \
compilerplugins/clang/test/unoany \ compilerplugins/clang/test/unoany \
compilerplugins/clang/test/unusedfields \
compilerplugins/clang/test/useuniqueptr \ compilerplugins/clang/test/useuniqueptr \
compilerplugins/clang/test/vclwidgets \ compilerplugins/clang/test/vclwidgets \
)) ))
# FIXME Fails with clang-3.8.
# compilerplugins/clang/test/unusedfields \
$(eval $(call gb_CompilerTest_use_externals,compilerplugins_clang, \ $(eval $(call gb_CompilerTest_use_externals,compilerplugins_clang, \
boost_headers \ boost_headers \
cppunit \ cppunit \