mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

improve the returnbyref loplugin

Browse Source 
Change-Id: I1b510a6194282dfa4a9001d473127c5ebc8b44eb
Reviewed-on: https://gerrit.libreoffice.org/16731
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
This commit is contained in:
Noel Grandin
2015-07-03 11:31:14 +02:00
committed by Noel Grandin
parent 89c77994d4
commit e9c3583c2c
240 changed files with 1644 additions and 1823 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
compilerplugins/clang/returnbyref.cxx
View File

@@ -34,6 +34,8 @@ public:
virtual void run() override { TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); }
bool VisitCXXMethodDecl(const CXXMethodDecl * decl);
private:
std::string getFilename(SourceLocation loc);
};
bool ReturnByRef::VisitCXXMethodDecl(const CXXMethodDecl * functionDecl) {
@@ -64,13 +66,26 @@ bool ReturnByRef::VisitCXXMethodDecl(const CXXMethodDecl * functionDecl) {
return true;
}
std::string aFilename = getFilename(functionDecl->getCanonicalDecl()->getLocStart());
if (aFilename == SRCDIR "/include/o3tl/cow_wrapper.hxx")
{
return true;
}
if ( functionDecl->getNameAsString() == "operator->") {
return true;
}
/*
std::string aParentName = functionDecl->getParent()->getQualifiedNameAsString();
std::string fqn = aParentName + "::" + functionDecl->getNameAsString();
if (aFilename == "TextCharAttribList::GetAttrib") {
return true;
}*/
/*
The AST here looks like:
-CompoundStmt
`-ReturnStmt
`-UnaryOperator
`-MemberExpr
`-CXXThisExpr
*/
const CompoundStmt* compoundStmt = dyn_cast< CompoundStmt >( functionDecl->getBody() );
@@ -87,34 +102,33 @@ bool ReturnByRef::VisitCXXMethodDecl(const CXXMethodDecl * functionDecl) {
if (unaryOperator == nullptr || unaryOperator->getOpcode() != UO_AddrOf) {
return true;
}
nextStmt = dyn_cast<Expr>(*unaryOperator->child_begin())->IgnoreParens();
const MemberExpr* memberExpr = dyn_cast<MemberExpr>(nextStmt);
if (memberExpr == nullptr) {
return true;
}
nextStmt = dyn_cast<Expr>(*memberExpr->child_begin())->IgnoreParens();
const CXXThisExpr* cXXThisExpr = dyn_cast<CXXThisExpr>(nextStmt);
if (cXXThisExpr == nullptr) {
return true;
}
nextStmt->dump();
report(
DiagnosticsEngine::Warning,
"rather return by reference",
"rather return by reference ",
functionDecl->getSourceRange().getBegin())
<< functionDecl->getSourceRange();
// display the location of the class member declaration so I don't have to search for it by hand
report(
DiagnosticsEngine::Note,
"rather return by reference",
functionDecl->getCanonicalDecl()->getSourceRange().getBegin())
<< functionDecl->getCanonicalDecl()->getSourceRange();
auto otherLoc = functionDecl->getCanonicalDecl()->getSourceRange().getBegin();
if (otherLoc != functionDecl->getSourceRange().getBegin())
{
report(
DiagnosticsEngine::Note,
"rather return by reference",
functionDecl->getCanonicalDecl()->getSourceRange().getBegin())
<< functionDecl->getCanonicalDecl()->getSourceRange();
}
return true;
}
std::string ReturnByRef::getFilename(SourceLocation loc)
{
SourceLocation spellingLocation = compiler.getSourceManager().getSpellingLoc(loc);
return compiler.getSourceManager().getFilename(spellingLocation);
}
loplugin::Plugin::Registration< ReturnByRef > X("returnbyref");
}