mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fdo#79151: No need to offset column index by category labels.

Browse Source 
In fact, doing so would lead to a corrupt internal data table.  The
internal data stores category labels separately from the column data, so
there is no reason why we need to offset for category labels here.

Change-Id: I29dd99e53837cba7a1e28d2a1ef39a5384378805
This commit is contained in:
Kohei Yoshida 2014-06-26 14:51:47 -04:00
parent 822d0e9db6
commit ecde8155fe
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
chart2/source/controller/dialogs/DataBrowserModel.cxx
View File

@ -343,10 +343,6 @@ void DataBrowserModel::insertDataSeries( sal_Int32 nAfterColumnIndex )
if (!xChartType.is()) if (!xChartType.is())
return; return;
sal_Int32 nOffset = 0;
if( xDiagram.is() && lcl_ShowCategories( xDiagram ))
nOffset = getCategoryColumnCount();
// Get shared sequences of current series. Normally multiple data series // Get shared sequences of current series. Normally multiple data series
// only share "values-x" sequences. (TODO: simplify this logic). // only share "values-x" sequences. (TODO: simplify this logic).
Reference< chart2::XDataSeriesContainer > xSeriesCnt( xChartType, uno::UNO_QUERY ); Reference< chart2::XDataSeriesContainer > xSeriesCnt( xChartType, uno::UNO_QUERY );
@ -367,7 +363,6 @@ void DataBrowserModel::insertDataSeries( sal_Int32 nAfterColumnIndex )
Sequence<Reference<chart2::data::XLabeledDataSequence> > aLSequences = xSource->getDataSequences(); Sequence<Reference<chart2::data::XLabeledDataSequence> > aLSequences = xSource->getDataSequences();
sal_Int32 nSeqIdx = 0; sal_Int32 nSeqIdx = 0;
sal_Int32 nSeqSize = aLSequences.getLength(); sal_Int32 nSeqSize = aLSequences.getLength();
nStartCol -= (nOffset - 1); // ???
for (sal_Int32 nIndex = nStartCol; nSeqIdx < nSeqSize; ++nSeqIdx) for (sal_Int32 nIndex = nStartCol; nSeqIdx < nSeqSize; ++nSeqIdx)
{ {
lcl_tSharedSeqVec::const_iterator aSharedIt( lcl_tSharedSeqVec::const_iterator aSharedIt(