mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:virtualdead unused params in SvXMLExportItemMapper::handleElementItem

Browse Source 
Change-Id: Ib77a29d23d8a67fab8441d369b2ff4660c1f99bc
Reviewed-on: https://gerrit.libreoffice.org/81009
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2019-10-17 13:17:12 +02:00
parent 933592b201
commit ecfc368932
4 changed files with 7 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
compilerplugins/clang/virtualdead.unusedparams.results
View File

@@ -340,9 +340,6 @@ sw/source/filter/ww8/wrtww8.hxx:798
sw/source/filter/ww8/wrtww8.hxx:863 sw/source/filter/ww8/wrtww8.hxx:863
void MSWordExportBase::OutputGrfNode(const class SwGrfNode &,) void MSWordExportBase::OutputGrfNode(const class SwGrfNode &,)
0 0
sw/source/filter/xml/xmlexpit.hxx:84
void SvXMLExportItemMapper::handleElementItem(class SvXMLExport &,const struct SvXMLItemMapEntry &,const class SfxPoolItem &,const class SvXMLUnitConverter &,const class SfxItemSet &,enum SvXmlExportFlags,)const
011000
vcl/inc/outdev.h:122 vcl/inc/outdev.h:122
_Bool ImplGlyphFallbackFontSubstitution::FindFontSubstitute(class FontSelectPattern &,class LogicalFontInstance *,class rtl::OUString &,)const _Bool ImplGlyphFallbackFontSubstitution::FindFontSubstitute(class FontSelectPattern &,class LogicalFontInstance *,class rtl::OUString &,)const
101 101

14
sw/source/filter/xml/xmlexpit.cxx
View File

@@ -239,9 +239,7 @@ void SvXMLExportItemMapper::exportXML( const SvXMLExport& rExport,
void SvXMLExportItemMapper::exportElementItems( void SvXMLExportItemMapper::exportElementItems(
SvXMLExport& rExport, SvXMLExport& rExport,
const SvXMLUnitConverter& rUnitConverter,
const SfxItemSet &rSet, const SfxItemSet &rSet,
SvXmlExportFlags nFlags,
const std::vector<sal_uInt16> &rIndexArray ) const const std::vector<sal_uInt16> &rIndexArray ) const
{ {
const size_t nCount = rIndexArray.size(); const size_t nCount = rIndexArray.size();
@@ -259,8 +257,7 @@ void SvXMLExportItemMapper::exportElementItems(
if(pItem) if(pItem)
{ {
rExport.IgnorableWhitespace(); rExport.IgnorableWhitespace();
handleElementItem( rExport, rEntry, *pItem, rUnitConverter, handleElementItem( rEntry, *pItem );
rSet, nFlags);
bItemsExported = true; bItemsExported = true;
} }
} }
@@ -314,8 +311,7 @@ void SvXMLExportItemMapper::exportXML( SvXMLExport& rExport,
SvXMLElementExport aElem( rExport, XML_NAMESPACE_STYLE, ePropToken, SvXMLElementExport aElem( rExport, XML_NAMESPACE_STYLE, ePropToken,
false, false ); false, false );
exportElementItems( rExport, rUnitConverter, exportElementItems( rExport, rSet, aIndexArray );
rSet, SvXmlExportFlags::IGN_WS, aIndexArray );
} }
} }
@@ -334,12 +330,8 @@ void SvXMLExportItemMapper::handleSpecialItem( SvXMLAttributeList& /*rAttrList*/
/** this method is called for every item that has the /** this method is called for every item that has the
MID_SW_FLAG_ELEMENT_EXPORT flag set */ MID_SW_FLAG_ELEMENT_EXPORT flag set */
void SvXMLExportItemMapper::handleElementItem( void SvXMLExportItemMapper::handleElementItem(
SvXMLExport& /*rExport*/,
const SvXMLItemMapEntry& /*rEntry*/, const SvXMLItemMapEntry& /*rEntry*/,
const SfxPoolItem& /*rItem*/, const SfxPoolItem& /*rItem*/ ) const
const SvXMLUnitConverter& /*rUnitConverter*/,
const SfxItemSet& /*rSet*/,
SvXmlExportFlags /*nFlags*/ ) const
{ {
OSL_FAIL( "element item not handled in xml export" ); OSL_FAIL( "element item not handled in xml export" );
} }

10
sw/source/filter/xml/xmlexpit.hxx
View File

@@ -53,9 +53,7 @@ protected:
const SfxItemSet *pSet ) const; const SfxItemSet *pSet ) const;
void exportElementItems( SvXMLExport& rExport, void exportElementItems( SvXMLExport& rExport,
const SvXMLUnitConverter& rUnitConverter,
const SfxItemSet &rSet, const SfxItemSet &rSet,
SvXmlExportFlags nFlags,
const std::vector<sal_uInt16> &rIndexArray ) const; const std::vector<sal_uInt16> &rIndexArray ) const;
static const SfxPoolItem* GetItem( const SfxItemSet &rSet, static const SfxPoolItem* GetItem( const SfxItemSet &rSet,
@@ -81,12 +79,8 @@ public:
/** this method is called for every item that has the /** this method is called for every item that has the
MID_SW_FLAG_ELEMENT_EXPORT flag set */ MID_SW_FLAG_ELEMENT_EXPORT flag set */
virtual void handleElementItem( SvXMLExport& rExport, virtual void handleElementItem( const SvXMLItemMapEntry& rEntry,
const SvXMLItemMapEntry& rEntry, const SfxPoolItem& rItem ) const;
const SfxPoolItem& rItem,
const SvXMLUnitConverter& rUnitConverter,
const SfxItemSet& rSet,
SvXmlExportFlags nFlags ) const;
inline void setMapEntries( SvXMLItemMapEntriesRef rMapEntries ); inline void setMapEntries( SvXMLItemMapEntriesRef rMapEntries );

12
sw/source/filter/xml/xmliteme.cxx
View File

@@ -73,12 +73,8 @@ public:
const SfxItemSet *pSet ) const override; const SfxItemSet *pSet ) const override;
virtual void handleElementItem( virtual void handleElementItem(
SvXMLExport& rExport,
const SvXMLItemMapEntry& rEntry, const SvXMLItemMapEntry& rEntry,
const SfxPoolItem& rItem, const SfxPoolItem& rItem ) const override;
const SvXMLUnitConverter& rUnitConverter,
const SfxItemSet& rSet,
SvXmlExportFlags nFlags ) const override;
inline void SetAbsWidth( sal_uInt32 nAbs ); inline void SetAbsWidth( sal_uInt32 nAbs );
}; };
@@ -182,12 +178,8 @@ void SwXMLTableItemMapper_Impl::handleSpecialItem(
/** this method is called for every item that has the /** this method is called for every item that has the
MID_SW_FLAG_ELEMENT_EXPORT flag set */ MID_SW_FLAG_ELEMENT_EXPORT flag set */
void SwXMLTableItemMapper_Impl::handleElementItem( void SwXMLTableItemMapper_Impl::handleElementItem(
SvXMLExport& /*rExport*/,
const SvXMLItemMapEntry& rEntry, const SvXMLItemMapEntry& rEntry,
const SfxPoolItem& rItem, const SfxPoolItem& rItem ) const
const SvXMLUnitConverter& /*rUnitConverter*/,
const SfxItemSet&,
SvXmlExportFlags ) const
{ {
switch( rEntry.nWhichId ) switch( rEntry.nWhichId )
{ {