mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:expandablemethodds in basctl..chart2

Browse Source 
Change-Id: I96f565a974fe3e316ae2ab04f8731b8bbfb87993
Reviewed-on: https://gerrit.libreoffice.org/29998
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2016-10-18 11:55:32 +02:00
parent 9e54e0708d
commit f019ee7cf9
15 changed files with 16 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
basic/source/inc/expr.hxx
View File

@@ -109,10 +109,6 @@ class SbiExprNode final { // operators (and operands)
void CollectBits(); // converting numbers to strings
bool IsOperand()
{ return eNodeType != SbxNODE && eNodeType != SbxTYPEOF && eNodeType != SbxNEW; }
bool IsTypeOf()
{ return eNodeType == SbxTYPEOF; }
bool IsNew()
{ return eNodeType == SbxNEW; }
bool IsNumber();
bool IsLvalue(); // true, if usable as Lvalue
void GenElement( SbiCodeGen&, SbiOpcode );
@@ -132,12 +128,7 @@ public:
{ return eNodeType == SbxSTRVAL || eNodeType == SbxNUMVAL; }
void ConvertToIntConstIfPossible();
bool IsVariable();
bool IsUnary()
{ return pLeft && !pRight; }
bool IsBinary()
{ return pLeft && pRight; }
SbiExprNode* GetWithParent() { return pWithParent; }
void SetWithParent( SbiExprNode* p ) { pWithParent = p; }
SbxDataType GetType() { return eType; }