New loplugin:externvar: filter

Change-Id: I2f800da9b61f33c801e1bc2809378ac19f22171b

filter/source/flash/swfexporter.cxx

@@ -386,7 +386,7 @@ sal_uInt16 FlashExporter::exportBackgrounds( Reference< XDrawPage > const & xDra
 }
 
 
-sal_Int32 nPlaceDepth;
+static sal_Int32 nPlaceDepth;
 // AS: A Slide can have a private background or use its masterpage's background.
 //  We use the checksums on the metafiles to tell if backgrounds are the same and
 //  should be reused.  The return value indicates which slide's background to use.

filter/source/graphic/Services.cxx

@@ -24,13 +24,13 @@
 #define GRAPHIC_EXPORT_FILTER_SERVICE "com.sun.star.comp.GraphicExportFilter"
 #define GRAPHIC_EXPORT_DIALOG_SERVICE "com.sun.star.comp.GraphicExportDialog"
 
-comphelper::service_decl::class_<GraphicExportFilter> serviceGraphicExportFilter;
+comphelper::service_decl::class_<GraphicExportFilter> const serviceGraphicExportFilter;
 const comphelper::service_decl::ServiceDecl graphicExportFilter(
     serviceGraphicExportFilter,
     GRAPHIC_EXPORT_FILTER_SERVICE,
     "com.sun.star.document.ExportFilter" );
 
-comphelper::service_decl::class_<GraphicExportDialog> serviceGraphicExportDialog;
+comphelper::service_decl::class_<GraphicExportDialog> const serviceGraphicExportDialog;
 const comphelper::service_decl::ServiceDecl graphicExportDialog(
     serviceGraphicExportDialog,
     GRAPHIC_EXPORT_DIALOG_SERVICE,

filter/source/msfilter/msocximex.cxx

@@ -30,7 +30,7 @@
 
 using namespace ::com::sun::star;
 
-OUString sWW8_form( "WW-Standard" );
+OUString const sWW8_form( "WW-Standard" );
 
 SvxMSConvertOCXControls::SvxMSConvertOCXControls( const uno::Reference< frame::XModel >& rxModel) : mxModel(rxModel)
 {

filter/source/msfilter/msvbahelper.cxx

@@ -642,7 +642,7 @@ struct KeyCodeEntry
    sal_uInt16 nCode;
 };
 
-KeyCodeEntry aMSKeyCodesData[] = {
+KeyCodeEntry const aMSKeyCodesData[] = {
     { "BACKSPACE", KEY_BACKSPACE },
     { "BS", KEY_BACKSPACE },
     { "DELETE", KEY_DELETE },
@@ -684,7 +684,7 @@ awt::KeyEvent parseKeyEvent( const OUString& Key ) throw ( uno::RuntimeException
     static std::map< OUString, sal_uInt16 > s_KeyCodes;
     if ( s_KeyCodes.empty() )
     {
-        for (KeyCodeEntry & i : aMSKeyCodesData)
+        for (KeyCodeEntry const & i : aMSKeyCodesData)
         {
             s_KeyCodes[ OUString::createFromAscii( i.sName ) ] = i.nCode;
         }

filter/source/svg/svgfilter.cxx

@@ -387,7 +387,7 @@ OUString SAL_CALL SVGFilter::detect(Sequence<PropertyValue>& rDescriptor) throw
 #define SVG_WRITER_IMPL_NAME "com.sun.star.comp.Draw.SVGWriter"
 
 namespace sdecl = comphelper::service_decl;
- sdecl::class_<SVGFilter> serviceFilterImpl;
+ sdecl::class_<SVGFilter> const serviceFilterImpl;
  const sdecl::ServiceDecl svgFilter(
      serviceFilterImpl,
      SVG_FILTER_IMPL_NAME,
@@ -395,7 +395,7 @@ namespace sdecl = comphelper::service_decl;
      "com.sun.star.document.ExportFilter;"
      "com.sun.star.document.ExtendedTypeDetection" );
 
- sdecl::class_<SVGWriter, sdecl::with_args<true> > serviceWriterImpl;
+ sdecl::class_<SVGWriter, sdecl::with_args<true> > const serviceWriterImpl;
  const sdecl::ServiceDecl svgWriter(
      serviceWriterImpl,
      SVG_WRITER_IMPL_NAME,

filter/source/t602/t602filter.cxx

@@ -55,7 +55,7 @@ using com::sun::star::io::XInputStream;
 
 namespace T602ImportFilter {
 
-    unsigned char kam2lat[129] =
+    unsigned char const kam2lat[129] =
         //    0   1   2   3   4   5   6   7   8   9   A   B   C   D   E   F
         "\xAC\x81\x82\xD4\x84\xD2\x9B\x9F\xD8\xB7\x91\xD6\x96\x92\x8E\xB5"  // 8
         "\x90\xA7\xA6\x93\x94\xE0\x85\xE9\xEC\x99\x9A\xE6\x95\xED\xFC\x9C"  // 9
@@ -66,7 +66,7 @@ namespace T602ImportFilter {
         "\xD0\xD1\xD3\xD7\xAA\xAB\xDD\xB0\xE3\xE4\xEB\xEE\xEF\xF0\xF2\xF4"  // E
         "\xBC\xBD\xBE\xC6\xC7\xC8\xF6\xC9\xCA\xFA\xFB\xCB\xF1\xCC\xFE\xFF"; // F
 
-    unsigned char koi2lat[129] =
+    unsigned char const koi2lat[129] =
         //    0   1   2   3   4   5   6   7   8   9   A   B   C   D   E   F
         "\x80\x83\x86\xF5\xE1\x87\x88\x89\x8A\x8B\x8C\x8F\x97\xCF\xCF\x98"  // 8
         "\x9D\x9E\xA4\xA5\xA8\xA9\xDB\xDC\xDF\xB1\xB2\xB6\xB8\xB9\xBA\xBB"  // 9
@@ -77,7 +77,7 @@ namespace T602ImportFilter {
         "\xBF\xB5\xD9\xAC\xD2\xB7\xE8\xB3\x9A\xD6\xDE\x91\x95\x99\xD5\xE0"  // E
         "\xE2\x8E\xFC\xE6\x9B\xE9\xB4\x90\xFA\xED\xA6\xC1\xF1\xFB\xFE\xFF"; // F
 
-    unsigned char lat2UNC[257] =
+    unsigned char const lat2UNC[257] =
         //    0       1       2       3       4       5       6       7
         //    8       9       A       B       C       D       E       F
         "\x00\xe7\x00\xfc\x00\xe9\x00\xf9\x00\xe4\x01\x6f\x00\xe8\x00\xa3"  // 8
@@ -97,7 +97,7 @@ namespace T602ImportFilter {
         "\x00\xf8\x02\xdd\x03\xb5\x02\xc7\x22\x29\x00\xa7\x00\xf7\x00\xe0"  // F
         "\x00\xb4\x00\xb0\x00\xc0\x02\xc6\x01\x58\x01\x59\x00\x20\x00\x20";
 
-    unsigned char rus2UNC[257] =
+    unsigned char const rus2UNC[257] =
         //    0       1       2       3       4       5       6       7
         //    8       9       A       B       C       D       E       F
         "\x04\x11\x00\xfc\x00\xe9\x04\x12\x00\xe4\x01\x6f\x04\x13\x04\x14"  // 8
@@ -131,7 +131,7 @@ namespace T602ImportFilter {
         mxHandler->endElement(_nam); \
     }
 
-inistruct ini;
+static inistruct ini;
 
 T602ImportFilter::T602ImportFilter(const css::uno::Reference<css::lang::XMultiServiceFactory > &r )
     : mxMSF(r)