mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

check for field being returned by non-const ref

Browse Source 
Change-Id: I660c98dcbfa6052628ff667886981d075f34b2b7
This commit is contained in:
Noel Grandin
2016-06-27 08:38:38 +02:00
parent e4b3323587
commit f9889a69b9
1 changed files with 17 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
compilerplugins/clang/singlevalfields.cxx
View File

@@ -190,7 +190,8 @@ bool SingleValFields::VisitMemberExpr( const MemberExpr* memberExpr )
if (ignoreLocation(memberExpr) || !isInterestingType(fieldDecl->getType())) if (ignoreLocation(memberExpr) || !isInterestingType(fieldDecl->getType()))
return true; return true;
const CXXMethodDecl* methodDecl = dyn_cast_or_null<CXXMethodDecl>(get_top_FunctionDecl_from_Stmt(*memberExpr)); const FunctionDecl* parentFunctionDecl = get_top_FunctionDecl_from_Stmt(*memberExpr);
const CXXMethodDecl* methodDecl = dyn_cast_or_null<CXXMethodDecl>(parentFunctionDecl);
if (methodDecl && (methodDecl->isCopyAssignmentOperator() || methodDecl->isMoveAssignmentOperator())) if (methodDecl && (methodDecl->isCopyAssignmentOperator() || methodDecl->isMoveAssignmentOperator()))
return true; return true;
@@ -200,7 +201,20 @@ bool SingleValFields::VisitMemberExpr( const MemberExpr* memberExpr )
bool bPotentiallyAssignedTo = false; bool bPotentiallyAssignedTo = false;
bool bDump = false; bool bDump = false;
std::string assignValue; std::string assignValue;
do {
// check for field being returned by non-const ref eg. Foo& getFoo() { return f; }
if (parent && isa<ReturnStmt>(parent)) {
const Stmt* parent2 = parentStmt(parent);
if (parent2 && isa<CompoundStmt>(parent2)) {
QualType qt = parentFunctionDecl->getReturnType().getDesugaredType(compiler.getASTContext());
if (!qt.isConstQualified() && qt->isReferenceType()) {
assignValue = "?";
bPotentiallyAssignedTo = true;
}
}
}
while (!bPotentiallyAssignedTo) {
// check for field being accessed by a reference variable e.g. Foo& f = m.foo; // check for field being accessed by a reference variable e.g. Foo& f = m.foo;
auto parentsList = compiler.getASTContext().getParents(*child); auto parentsList = compiler.getASTContext().getParents(*child);
auto it = parentsList.begin(); auto it = parentsList.begin();
@@ -303,7 +317,7 @@ bool SingleValFields::VisitMemberExpr( const MemberExpr* memberExpr )
bDump = true; bDump = true;
break; break;
} }
} while (true); }
if (bDump) if (bDump)
{ {
report( report(