From fb3027544fd6ff6bc089d1e24d4f8dd2a0ee1fce Mon Sep 17 00:00:00 2001
From: Stephan Bergmann <sbergman@redhat.com>
Date: Tue, 22 Jun 2021 15:22:51 +0200
Subject: [PATCH] Clarify no loplugin:overridevirtual with templated base class

Change-Id: I4128b43f2a928fa5465991cc92b2d62e54e2cfec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117662
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
---
 .../clang/test/overridevirtual.cxx            | 44 +++++++++++++++++++
 solenv/CompilerTest_compilerplugins_clang.mk  |  1 +
 2 files changed, 45 insertions(+)
 create mode 100644 compilerplugins/clang/test/overridevirtual.cxx

diff --git a/compilerplugins/clang/test/overridevirtual.cxx b/compilerplugins/clang/test/overridevirtual.cxx
new file mode 100644
index 000000000000..0f11d86b105d
--- /dev/null
+++ b/compilerplugins/clang/test/overridevirtual.cxx
@@ -0,0 +1,44 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+struct S1
+{
+    // expected-note@+1 {{overridden declaration is here [loplugin:overridevirtual]}}
+    virtual ~S1();
+};
+
+struct S2 : S1
+{
+    // expected-error@+1 {{overriding virtual function declaration not marked 'override' [loplugin:overridevirtual]}}
+    ~S2();
+};
+
+template <typename> struct T1
+{
+    virtual ~T1();
+};
+
+template <typename T> struct T2 : T1<T>
+{
+    ~T2();
+};
+
+template <typename> struct U1
+{
+    // expected-note@+1 {{overridden declaration is here [loplugin:overridevirtual]}}
+    virtual ~U1();
+};
+
+template <typename T> struct U2 : U1<int>
+{
+    // expected-error@+1 {{overriding virtual function declaration not marked 'override' [loplugin:overridevirtual]}}
+    ~U2();
+};
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */
diff --git a/solenv/CompilerTest_compilerplugins_clang.mk b/solenv/CompilerTest_compilerplugins_clang.mk
index 3a05e8fb2bb3..d3131efd0e7e 100644
--- a/solenv/CompilerTest_compilerplugins_clang.mk
+++ b/solenv/CompilerTest_compilerplugins_clang.mk
@@ -56,6 +56,7 @@ $(eval $(call gb_CompilerTest_add_exception_objects,compilerplugins_clang, \
     compilerplugins/clang/test/oslendian-1 \
     compilerplugins/clang/test/oslendian-2 \
     compilerplugins/clang/test/oslendian-3 \
+    compilerplugins/clang/test/overridevirtual \
     compilerplugins/clang/test/passparamsbyref \
     compilerplugins/clang/test/passstuffbyref \
     compilerplugins/clang/test/pointerbool \