mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

clang-tidy performance-unnecessary-value-param in unotools

Browse Source 
Change-Id: Ife11111b0265da5d5a8a98766a94f3b640b357f5
This commit is contained in:
Noel Grandin
2016-04-11 14:49:04 +02:00
parent b76c2ea81d
commit fb42d03b5a
5 changed files with 25 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
include/unotools/ucbhelper.hxx
View File

@@ -61,8 +61,8 @@ UNOTOOLS_DLLPUBLIC bool MakeFolder(
/// like mkdir -p /// like mkdir -p
UNOTOOLS_DLLPUBLIC bool ensureFolder( UNOTOOLS_DLLPUBLIC bool ensureFolder(
css::uno::Reference< css::uno::XComponentContext > xCtx, const css::uno::Reference< css::uno::XComponentContext >& xCtx,
css::uno::Reference< css::ucb::XCommandEnvironment > xEnv, const css::uno::Reference< css::ucb::XCommandEnvironment >& xEnv,
const OUString& rFolder, ucbhelper::Content & result) throw(); const OUString& rFolder, ucbhelper::Content & result) throw();
/// @return the value of the "Size" property of the given content, or zero if /// @return the value of the "Size" property of the given content, or zero if

10
include/unotools/ucbstreamhelper.hxx
View File

@@ -54,13 +54,13 @@ namespace utl
public: public:
static SvStream* CreateStream( const OUString& rFileName, StreamMode eOpenMode ); static SvStream* CreateStream( const OUString& rFileName, StreamMode eOpenMode );
static SvStream* CreateStream( const OUString& rFileName, StreamMode eOpenMode, static SvStream* CreateStream( const OUString& rFileName, StreamMode eOpenMode,
css::uno::Reference < css::task::XInteractionHandler > ); const css::uno::Reference < css::task::XInteractionHandler >& );
static SvStream* CreateStream( const OUString& rFileName, StreamMode eOpenMode, static SvStream* CreateStream( const OUString& rFileName, StreamMode eOpenMode,
bool bFileExists ); bool bFileExists );
static SvStream* CreateStream( css::uno::Reference < css::io::XInputStream > xStream ); static SvStream* CreateStream( const css::uno::Reference < css::io::XInputStream >& xStream );
static SvStream* CreateStream( css::uno::Reference < css::io::XStream > xStream ); static SvStream* CreateStream( const css::uno::Reference < css::io::XStream >& xStream );
static SvStream* CreateStream( css::uno::Reference < css::io::XInputStream > xStream, bool bCloseStream ); static SvStream* CreateStream( const css::uno::Reference < css::io::XInputStream >& xStream, bool bCloseStream );
static SvStream* CreateStream( css::uno::Reference < css::io::XStream > xStream, bool bCloseStream ); static SvStream* CreateStream( const css::uno::Reference < css::io::XStream >& xStream, bool bCloseStream );
}; };
} }

4
unotools/source/ucbhelper/ucbhelper.cxx
View File

@@ -449,8 +449,8 @@ bool utl::UCBContentHelper::EqualURLs(
} }
bool utl::UCBContentHelper::ensureFolder( bool utl::UCBContentHelper::ensureFolder(
css::uno::Reference< css::uno::XComponentContext > xCtx, const css::uno::Reference< css::uno::XComponentContext >& xCtx,
css::uno::Reference< css::ucb::XCommandEnvironment > xEnv, const css::uno::Reference< css::ucb::XCommandEnvironment >& xEnv,
const OUString& rFolder, ucbhelper::Content & result) throw() const OUString& rFolder, ucbhelper::Content & result) throw()
{ {
try try

20
unotools/source/ucbhelper/ucblockbytes.cxx
View File

@@ -712,17 +712,17 @@ void SAL_CALL Moderator::onTerminated()
but with handled timeout; but with handled timeout;
*/ */
static bool UCBOpenContentSync_( static bool UCBOpenContentSync_(
UcbLockBytesRef xLockBytes, const UcbLockBytesRef& xLockBytes,
Reference < XContent > xContent, const Reference < XContent >& xContent,
const Command& rArg, const Command& rArg,
Reference < XInterface > xSink, const Reference < XInterface >& xSink,
Reference < XInteractionHandler > xInteract ); const Reference < XInteractionHandler >& xInteract );
static bool UCBOpenContentSync( static bool UCBOpenContentSync(
UcbLockBytesRef xLockBytes, const UcbLockBytesRef& xLockBytes,
Reference < XContent > xContent, Reference < XContent > xContent,
const Command& rArg, const Command& rArg,
Reference < XInterface > xSink, const Reference < XInterface >& xSink,
Reference < XInteractionHandler > xInteract ) Reference < XInteractionHandler > xInteract )
{ {
// http protocol must be handled in a special way: // http protocol must be handled in a special way:
@@ -957,11 +957,11 @@ static bool UCBOpenContentSync(
Function for opening UCB contents synchronously Function for opening UCB contents synchronously
*/ */
static bool UCBOpenContentSync_( static bool UCBOpenContentSync_(
UcbLockBytesRef xLockBytes, const UcbLockBytesRef& xLockBytes,
Reference < XContent > xContent, const Reference < XContent >& xContent,
const Command& rArg, const Command& rArg,
Reference < XInterface > xSink, const Reference < XInterface >& xSink,
Reference < XInteractionHandler > xInteract ) const Reference < XInteractionHandler >& xInteract )
{ {
::ucbhelper::Content aContent( ::ucbhelper::Content aContent(
xContent, new UcbTaskEnvironment( xInteract, nullptr ), xContent, new UcbTaskEnvironment( xInteract, nullptr ),

12
unotools/source/ucbhelper/ucbstreamhelper.cxx
View File

@@ -41,7 +41,7 @@ namespace utl
{ {
static SvStream* lcl_CreateStream( const OUString& rFileName, StreamMode eOpenMode, static SvStream* lcl_CreateStream( const OUString& rFileName, StreamMode eOpenMode,
Reference < XInteractionHandler > xInteractionHandler, const Reference < XInteractionHandler >& xInteractionHandler,
UcbLockBytesHandler* pHandler, bool bEnsureFileExists ) UcbLockBytesHandler* pHandler, bool bEnsureFileExists )
{ {
SvStream* pStream = nullptr; SvStream* pStream = nullptr;
@@ -144,7 +144,7 @@ SvStream* UcbStreamHelper::CreateStream( const OUString& rFileName, StreamMode e
} }
SvStream* UcbStreamHelper::CreateStream( const OUString& rFileName, StreamMode eOpenMode, SvStream* UcbStreamHelper::CreateStream( const OUString& rFileName, StreamMode eOpenMode,
Reference < XInteractionHandler > xInteractionHandler ) const Reference < XInteractionHandler >& xInteractionHandler )
{ {
return lcl_CreateStream( rFileName, eOpenMode, xInteractionHandler, nullptr, true /* bEnsureFileExists */ ); return lcl_CreateStream( rFileName, eOpenMode, xInteractionHandler, nullptr, true /* bEnsureFileExists */ );
} }
@@ -155,7 +155,7 @@ SvStream* UcbStreamHelper::CreateStream( const OUString& rFileName, StreamMode e
return lcl_CreateStream( rFileName, eOpenMode, Reference < XInteractionHandler >(), nullptr, !bFileExists ); return lcl_CreateStream( rFileName, eOpenMode, Reference < XInteractionHandler >(), nullptr, !bFileExists );
} }
SvStream* UcbStreamHelper::CreateStream( Reference < XInputStream > xStream ) SvStream* UcbStreamHelper::CreateStream( const Reference < XInputStream >& xStream )
{ {
SvStream* pStream = nullptr; SvStream* pStream = nullptr;
UcbLockBytesRef xLockBytes = UcbLockBytes::CreateInputLockBytes( xStream ); UcbLockBytesRef xLockBytes = UcbLockBytes::CreateInputLockBytes( xStream );
@@ -169,7 +169,7 @@ SvStream* UcbStreamHelper::CreateStream( Reference < XInputStream > xStream )
return pStream; return pStream;
} }
SvStream* UcbStreamHelper::CreateStream( Reference < XStream > xStream ) SvStream* UcbStreamHelper::CreateStream( const Reference < XStream >& xStream )
{ {
SvStream* pStream = nullptr; SvStream* pStream = nullptr;
if ( xStream->getOutputStream().is() ) if ( xStream->getOutputStream().is() )
@@ -188,7 +188,7 @@ SvStream* UcbStreamHelper::CreateStream( Reference < XStream > xStream )
return pStream; return pStream;
} }
SvStream* UcbStreamHelper::CreateStream( Reference < XInputStream > xStream, bool bCloseStream ) SvStream* UcbStreamHelper::CreateStream( const Reference < XInputStream >& xStream, bool bCloseStream )
{ {
SvStream* pStream = nullptr; SvStream* pStream = nullptr;
UcbLockBytesRef xLockBytes = UcbLockBytes::CreateInputLockBytes( xStream ); UcbLockBytesRef xLockBytes = UcbLockBytes::CreateInputLockBytes( xStream );
@@ -205,7 +205,7 @@ SvStream* UcbStreamHelper::CreateStream( Reference < XInputStream > xStream, boo
return pStream; return pStream;
}; };
SvStream* UcbStreamHelper::CreateStream( Reference < XStream > xStream, bool bCloseStream ) SvStream* UcbStreamHelper::CreateStream( const Reference < XStream >& xStream, bool bCloseStream )
{ {
SvStream* pStream = nullptr; SvStream* pStream = nullptr;
if ( xStream->getOutputStream().is() ) if ( xStream->getOutputStream().is() )