mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[API CHANGE] return unsigned 64-bit value from GetSystemTicks in basic code

Browse Source 
instead of 32-bit value.

looks like this has been incorrect since

   commit 9f2104e1f3
   Author: Jens-Heiner Rechtien <hr@openoffice.org>
   Date:   Mon Jun 19 16:46:13 2006 +0000
   INTEGRATION: CWS warnings01 (1.23.26); FILE MERGED

but nobody cared, since the values would previously fit into a 32-bit
number.

Change-Id: I4c121085977b5e7ff3e33c8ad57749b925ad31b9
Reviewed-on: https://gerrit.libreoffice.org/32879
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2017-01-09 11:20:48 +02:00
parent 4df12fe523
commit fce604c8ae
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
basic/source/runtime/methods1.cxx
View File

@@ -1415,7 +1415,7 @@ RTLFUNC(GetSystemTicks)
StarBASIC::Error( ERRCODE_BASIC_BAD_ARGUMENT ); StarBASIC::Error( ERRCODE_BASIC_BAD_ARGUMENT );
return; return;
} }
rPar.Get(0)->PutLong( tools::Time::GetSystemTicks() ); rPar.Get(0)->PutUInt64( tools::Time::GetSystemTicks() );
} }
RTLFUNC(GetPathSeparator) RTLFUNC(GetPathSeparator)

2
basic/source/runtime/stdobj.cxx
View File

@@ -307,7 +307,7 @@ static Methods aMethods[] = {
{ "GetPathSeparator", SbxSTRING, FUNCTION_,RTLNAME(GetPathSeparator),0 }, { "GetPathSeparator", SbxSTRING, FUNCTION_,RTLNAME(GetPathSeparator),0 },
{ "GetProcessServiceManager", SbxOBJECT, 0 | FUNCTION_, RTLNAME(GetProcessServiceManager),0 }, { "GetProcessServiceManager", SbxOBJECT, 0 | FUNCTION_, RTLNAME(GetProcessServiceManager),0 },
{ "GetSolarVersion", SbxLONG, FUNCTION_,RTLNAME(GetSolarVersion),0 }, { "GetSolarVersion", SbxLONG, FUNCTION_,RTLNAME(GetSolarVersion),0 },
{ "GetSystemTicks", SbxLONG, FUNCTION_,RTLNAME(GetSystemTicks),0 }, { "GetSystemTicks", SbxSALUINT64,FUNCTION_,RTLNAME(GetSystemTicks),0 },
{ "GetSystemType", SbxINTEGER, FUNCTION_,RTLNAME(GetSystemType),0 }, { "GetSystemType", SbxINTEGER, FUNCTION_,RTLNAME(GetSystemType),0 },
{ "GlobalScope", SbxOBJECT, FUNCTION_,RTLNAME(GlobalScope),0 }, { "GlobalScope", SbxOBJECT, FUNCTION_,RTLNAME(GlobalScope),0 },
{ "Green", SbxINTEGER, 1 | FUNCTION_ | NORMONLY_, RTLNAME(Green),0 }, { "Green", SbxINTEGER, 1 | FUNCTION_ | NORMONLY_, RTLNAME(Green),0 },