From fceee9237c583f8d95396845a1c1606000df26fb Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Fri, 14 Aug 2015 11:09:40 +0200 Subject: [PATCH] loplugin: defaultparams Change-Id: I4080aece6fec2778a2a8646ddedd280337303591 --- filter/source/graphicfilter/eps/eps.cxx | 8 ++++---- filter/source/graphicfilter/icgm/class4.cxx | 2 +- filter/source/graphicfilter/idxf/dxf2mtf.cxx | 2 +- filter/source/msfilter/msvbahelper.cxx | 2 +- filter/source/pdf/impdialog.cxx | 6 +++--- filter/source/xsltfilter/OleHandler.cxx | 2 +- forms/source/component/DatabaseForm.cxx | 2 +- forms/source/component/ListBox.cxx | 4 ++-- forms/source/xforms/binding.cxx | 10 +++++----- forms/source/xforms/datatyperepository.cxx | 2 +- formula/source/core/api/FormulaCompiler.cxx | 4 ++-- 11 files changed, 22 insertions(+), 22 deletions(-) diff --git a/filter/source/graphicfilter/eps/eps.cxx b/filter/source/graphicfilter/eps/eps.cxx index 38460b92b68d..bcbb526d109d 100644 --- a/filter/source/graphicfilter/eps/eps.cxx +++ b/filter/source/graphicfilter/eps/eps.cxx @@ -1649,7 +1649,7 @@ void PSWriter::ImplPolyPoly( const tools::PolyPolygon & rPolyPoly, bool bTextOut ImplWriteLineColor( PS_SPACE ); for ( i = 0; i < nPolyCount; i++ ) ImplAddPath( rPolyPoly.GetObject( i ) ); - ImplClosePathDraw( PS_RET ); + ImplClosePathDraw(); } } } @@ -1685,7 +1685,7 @@ void PSWriter::ImplPolyLine( const Polygon & rPoly ) // #104645# explicitly close path if polygon is closed if( rPoly[ 0 ] == rPoly[ nPointCount-1 ] ) - ImplClosePathDraw( PS_RET ); + ImplClosePathDraw(); else ImplPathDraw(); } @@ -2438,13 +2438,13 @@ void PSWriter::ImplWriteLineInfo( double fLWidth, double fMLimit, if ( eLineCap != eLCap ) { eLineCap = eLCap; - ImplWriteLong( (sal_Int32)eLineCap, PS_SPACE ); + ImplWriteLong( (sal_Int32)eLineCap ); ImplWriteLine( "lc", PS_SPACE ); } if ( eJoinType != eJoin ) { eJoinType = eJoin; - ImplWriteLong( (sal_Int32)eJoinType, PS_SPACE ); + ImplWriteLong( (sal_Int32)eJoinType ); ImplWriteLine( "lj", PS_SPACE ); } if ( eJoinType == SvtGraphicStroke::joinMiter ) diff --git a/filter/source/graphicfilter/icgm/class4.cxx b/filter/source/graphicfilter/icgm/class4.cxx index e484e52d739f..0523ada023ba 100644 --- a/filter/source/graphicfilter/icgm/class4.cxx +++ b/filter/source/graphicfilter/icgm/class4.cxx @@ -288,7 +288,7 @@ void CGM::ImplDoClass4() { aPolygon.SetPoint( pPoints[ i ], i ); } - aPolyPolygon.Insert( aPolygon, POLYPOLY_APPEND ); + aPolyPolygon.Insert( aPolygon ); nPoints = 0; } } diff --git a/filter/source/graphicfilter/idxf/dxf2mtf.cxx b/filter/source/graphicfilter/idxf/dxf2mtf.cxx index 29a67f3130a3..613f76f5053f 100644 --- a/filter/source/graphicfilter/idxf/dxf2mtf.cxx +++ b/filter/source/graphicfilter/idxf/dxf2mtf.cxx @@ -614,7 +614,7 @@ void DXF2GDIMetaFile::DrawHatchEntity(const DXFHatchEntity & rE, const DXFTransf Polygon aPoly( nSize ); for ( i = 0; i < nSize; i++ ) aPoly[ i ] = aPtAry[ i ]; - aPolyPoly.Insert( aPoly, POLYPOLY_APPEND ); + aPolyPoly.Insert( aPoly ); } } if ( aPolyPoly.Count() ) diff --git a/filter/source/msfilter/msvbahelper.cxx b/filter/source/msfilter/msvbahelper.cxx index ebf458be2b92..8667270e2f61 100644 --- a/filter/source/msfilter/msvbahelper.cxx +++ b/filter/source/msfilter/msvbahelper.cxx @@ -597,7 +597,7 @@ OUString SAL_CALL VBAMacroResolver::resolveVBAMacroToScriptURL( const OUString& aMacroName = aMacroName.copy( nDotPos + 1 ); // try to find the macro - MacroResolvedInfo aInfo = resolveVBAMacro( mpObjShell, aMacroName, false ); + MacroResolvedInfo aInfo = resolveVBAMacro( mpObjShell, aMacroName ); if( !aInfo.mbFound ) throw lang::IllegalArgumentException(); diff --git a/filter/source/pdf/impdialog.cxx b/filter/source/pdf/impdialog.cxx index 8902b4c8636b..43dbec842cfc 100644 --- a/filter/source/pdf/impdialog.cxx +++ b/filter/source/pdf/impdialog.cxx @@ -305,7 +305,7 @@ ImpPDFTabGeneralPage* ImpPDFTabDialog::getGeneralPage() const IMPL_LINK_NOARG(ImpPDFTabDialog, CancelHdl) { - EndDialog( RET_CANCEL ); + EndDialog(); return 0; } @@ -1121,12 +1121,12 @@ void ImpPDFTabViewerPage::SetFilterConfigItem( const ImpPDFTabDialog* paParent m_pCbTransitionEffects->Enable( mbIsPresentation ); if( paParent->mnOpenBookmarkLevels < 0 ) { - m_pRbAllBookmarkLevels->Check( true ); + m_pRbAllBookmarkLevels->Check(); m_pNumBookmarkLevels->Enable( false ); } else { - m_pRbVisibleBookmarkLevels->Check( true ); + m_pRbVisibleBookmarkLevels->Check(); m_pNumBookmarkLevels->Enable( true ); m_pNumBookmarkLevels->SetValue( paParent->mnOpenBookmarkLevels ); } diff --git a/filter/source/xsltfilter/OleHandler.cxx b/filter/source/xsltfilter/OleHandler.cxx index 74d4ea9bc819..55b89b74a646 100644 --- a/filter/source/xsltfilter/OleHandler.cxx +++ b/filter/source/xsltfilter/OleHandler.cxx @@ -76,7 +76,7 @@ namespace XSLT { Sequence oleData; ::sax::Converter::decodeBase64(oleData, OStringToOUString( - content, RTL_TEXTENCODING_UTF8, OSTRING_TO_OUSTRING_CVTFLAGS)); + content, RTL_TEXTENCODING_UTF8)); m_rootStream = createTempFile(); Reference xOutput = m_rootStream->getOutputStream(); xOutput->writeBytes(oleData); diff --git a/forms/source/component/DatabaseForm.cxx b/forms/source/component/DatabaseForm.cxx index 88ed5623e79e..47488b26cd4e 100644 --- a/forms/source/component/DatabaseForm.cxx +++ b/forms/source/component/DatabaseForm.cxx @@ -1939,7 +1939,7 @@ void SAL_CALL ODatabaseForm::reset() throw( RuntimeException, std::exception ) m_pThread->create(); } EventObject aEvt; - m_pThread->addEvent(&aEvt, false); + m_pThread->addEvent(&aEvt); } else { diff --git a/forms/source/component/ListBox.cxx b/forms/source/component/ListBox.cxx index 724b6c8f54be..752a6181a8b5 100644 --- a/forms/source/component/ListBox.cxx +++ b/forms/source/component/ListBox.cxx @@ -1391,7 +1391,7 @@ namespace frm { // the indexes where the current string appears in our string items Sequence< sal_Int16 > aThisEntryIndexes; - aThisEntryIndexes = findValue( getStringItemList(), *pSelectEntries++, false ); + aThisEntryIndexes = findValue( getStringItemList(), *pSelectEntries++ ); // insert all the indexes of this entry into our set ::std::copy( @@ -1416,7 +1416,7 @@ namespace frm OUString sStringToSelect; OSL_VERIFY( _rExternalValue >>= sStringToSelect ); - aSelectIndexes = findValue( getStringItemList(), sStringToSelect, false ); + aSelectIndexes = findValue( getStringItemList(), sStringToSelect ); } break; } diff --git a/forms/source/xforms/binding.cxx b/forms/source/xforms/binding.cxx index 5c86447281b2..e1454483e550 100644 --- a/forms/source/xforms/binding.cxx +++ b/forms/source/xforms/binding.cxx @@ -170,7 +170,7 @@ css::uno::Reference Binding::getXNodeList() { // first make sure we are bound if( ! maBindingExpression.hasValue() ) - bind( false ); + bind(); return maBindingExpression.getXNodeList(); } @@ -309,7 +309,7 @@ EvaluationContext Binding::getEvaluationContext() const OSL_ENSURE( getModelImpl() != NULL, "need model impl" ); // bind (in case we were not bound before) - bind( false ); + bind(); return _getMIPEvaluationContexts(); } @@ -779,11 +779,11 @@ MIP Binding::getLocalMIP() const MIP aMIP; if( maReadonly.hasValue() ) - aMIP.setReadonly( maReadonly.getBool( false ) ); + aMIP.setReadonly( maReadonly.getBool() ); if( maRelevant.hasValue() ) aMIP.setRelevant( maRelevant.getBool( true ) ); if( maRequired.hasValue() ) - aMIP.setRequired( maRequired.getBool( false ) ); + aMIP.setRequired( maRequired.getBool() ); if( maConstraint.hasValue() ) { aMIP.setConstraint( maConstraint.getBool( true ) ); @@ -1252,7 +1252,7 @@ void Binding::handleEvent( const css::uno::Reference SAL_CALL ODataTypeRepository::getDataType( const OUString& typeName ) throw (NoSuchElementException, RuntimeException, std::exception) { ::osl::MutexGuard aGuard( m_aMutex ); - return implLocate( typeName, false )->second.get(); + return implLocate( typeName )->second.get(); } diff --git a/formula/source/core/api/FormulaCompiler.cxx b/formula/source/core/api/FormulaCompiler.cxx index f0ed8c2724fd..085f1bccd0de 100644 --- a/formula/source/core/api/FormulaCompiler.cxx +++ b/formula/source/core/api/FormulaCompiler.cxx @@ -1068,11 +1068,11 @@ bool FormulaCompiler::GetToken() if ( nWasColRowName ) nWasColRowName++; if ( bAutoCorrect && !pStack ) - CreateStringFromToken( aCorrectedFormula, mpToken.get(), false ); + CreateStringFromToken( aCorrectedFormula, mpToken.get() ); mpToken = pArr->Next(); } if ( bAutoCorrect && !pStack && mpToken ) - CreateStringFromToken( aCorrectedSymbol, mpToken.get(), false ); + CreateStringFromToken( aCorrectedSymbol, mpToken.get() ); if( !mpToken ) { if( pStack )