mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

coverity#1228876 Uninitialized pointer field

Browse Source 
Change-Id: I8de9efc5abfa01225aa6032bf68a32fed17aeb00
This commit is contained in:
Caolán McNamara
2014-07-26 17:49:27 +01:00
parent 6c2c974dd3
commit fe951dc06a
2 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
cui/source/dialogs/hangulhanjadlg.cxx
View File

@@ -1354,12 +1354,12 @@ namespace svx
if( _bUp ) if( _bUp )
{ {
if( !m_pPrev ) if( !m_pPrev )
bRet = m_rScrollBar->GetThumbPos() > m_rScrollBar->GetRangeMin(); bRet = m_pScrollBar->GetThumbPos() > m_pScrollBar->GetRangeMin();
} }
else else
{ {
if( !m_pNext ) if( !m_pNext )
bRet = m_rScrollBar->GetThumbPos() < ( m_rScrollBar->GetRangeMax() - 4 ); bRet = m_pScrollBar->GetThumbPos() < ( m_pScrollBar->GetRangeMax() - 4 );
} }
return bRet; return bRet;
@@ -1370,13 +1370,16 @@ namespace svx
const Link& rLoseFocusHdl = GetLoseFocusHdl(); const Link& rLoseFocusHdl = GetLoseFocusHdl();
if( rLoseFocusHdl.IsSet() ) if( rLoseFocusHdl.IsSet() )
rLoseFocusHdl.Call( this ); rLoseFocusHdl.Call( this );
m_rScrollBar->SetThumbPos( m_rScrollBar->GetThumbPos() + ( _bUp? -1 : 1 ) ); m_pScrollBar->SetThumbPos( m_pScrollBar->GetThumbPos() + ( _bUp? -1 : 1 ) );
( static_cast< HangulHanjaEditDictDialog* >( GetParentDialog() ) )->UpdateScrollbar(); ( static_cast< HangulHanjaEditDictDialog* >( GetParentDialog() ) )->UpdateScrollbar();
} }
SuggestionEdit::SuggestionEdit( Window* pParent, WinBits nBits ) SuggestionEdit::SuggestionEdit( Window* pParent, WinBits nBits )
:Edit( pParent, nBits ) : Edit(pParent, nBits)
, m_pPrev(NULL)
, m_pNext(NULL)
, m_pScrollBar(NULL)
{ {
} }
@@ -1435,7 +1438,7 @@ namespace svx
void SuggestionEdit::init( ScrollBar* pScrollBar, SuggestionEdit* pPrev, SuggestionEdit* pNext) void SuggestionEdit::init( ScrollBar* pScrollBar, SuggestionEdit* pPrev, SuggestionEdit* pNext)
{ {
m_rScrollBar = pScrollBar; m_pScrollBar = pScrollBar;
m_pPrev = pPrev; m_pPrev = pPrev;
m_pNext = pNext; m_pNext = pNext;
} }

2
cui/source/inc/hangulhanjadlg.hxx
View File

@@ -255,7 +255,7 @@ namespace svx
private: private:
SuggestionEdit* m_pPrev; SuggestionEdit* m_pPrev;
SuggestionEdit* m_pNext; SuggestionEdit* m_pNext;
ScrollBar* m_rScrollBar; ScrollBar* m_pScrollBar;
bool ShouldScroll( bool _bUp ) const; bool ShouldScroll( bool _bUp ) const;
void DoJump( bool _bUp ); void DoJump( bool _bUp );