mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
448,250 Commits 1 Branch 0 Tags
01546c005eaf6bce8fe4066dbec92c5655190a2a
Commit Graph

125 Commits

Author SHA1 Message Date
Mike Kaganski
62f3f3d92a SbxArray: drop 16-bit indices 
Change-Id: I43b478187636b9bb53fdf7ab938436ae364bd7a7
Reviewed-on: https://gerrit.libreoffice.org/84733
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2019-12-09 14:18:25 +01:00
Mike Kaganski
0ed214fd8f tdf#59327: two arguments with the same name is an error 
Change-Id: I8d10487d6d6729de749a373feb0a8a349f2986e9
Reviewed-on: https://gerrit.libreoffice.org/84686
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2019-12-07 20:01:16 +01:00
Mike Kaganski
840c3a6620 tdf#59327: DIM should fail in procedures when same-name argument is present 
Change-Id: I0a6828bd0b0c27018dc02c36ee207b8666f88ec0
Reviewed-on: https://gerrit.libreoffice.org/84682
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2019-12-07 17:30:27 +01:00
Gabor Kelemen
7ddedd2594 tdf#42949 Fix IWYU warnings in basic/ 
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I325149be2ea7697b5b4a2ce4a662edd2f8be6e50
Reviewed-on: https://gerrit.libreoffice.org/82312
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
 2019-11-12 09:20:55 +01:00
Andrea Gelmini
9e6ca513ac Fix typo 
Change-Id: I715da280563c7c3f03eb9b521478db4481ae4b2f
Reviewed-on: https://gerrit.libreoffice.org/72322
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2019-05-15 07:07:07 +02:00
Andrea Gelmini
b391088456 Fix typo 
Change-Id: I88a8fb94cb1e7653d63a77bdb63d1303cc848704
Reviewed-on: https://gerrit.libreoffice.org/70361
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2019-04-07 08:04:31 +02:00
Noel Grandin
587ac01f97 loplugin:indentation in basctl..bridges 
Change-Id: Ie4e27466c4258c6f774a3ebb82ec3a88c28fd753
Reviewed-on: https://gerrit.libreoffice.org/67525
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-02-08 10:01:05 +01:00
Jan-Marek Glogowski
2226d69ae3 Make SbiProcDef::Match more readable 
This reverts commit 02caaef29d ("loplugin:useuniqueptr in
SbiProcDef") and is hopefully easier to follow.

Change-Id: I46be2b3c7a933743795d89fe17a2c499c6983382
Reviewed-on: https://gerrit.libreoffice.org/62548
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
 2018-10-30 21:40:26 +01:00
Mike Kaganski
db7e454bf7 tdf#120703 PVS: V668 
V668 There is no sense in testing the 'pProc' pointer against null, as the
     memory was allocated using the 'new' operator. The exception will be
     generated in the case of memory allocation error.

Change-Id: Iec65fd44fa947a2402da33510c29730a46c2e1a4
Reviewed-on: https://gerrit.libreoffice.org/62424
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2018-10-27 18:00:01 +02:00
Noel Grandin
02caaef29d loplugin:useuniqueptr in SbiProcDef 
Change-Id: I31c43f8fe40d90094d550b02c5d6213e59149bad
Reviewed-on: https://gerrit.libreoffice.org/58486
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-08-03 09:08:04 +02:00
Jochen Nitschke
b4d36b5dcf remove some unused comphelper includes 
and fix the fallout

Change-Id: I5d0c2040f57a3ac354a7e277592da31d09a5f359
Reviewed-on: https://gerrit.libreoffice.org/52894
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
 2018-04-15 11:17:24 +02:00
Julien Nabet
359f2035bc Typos: definied->defined 
Change-Id: I052d6a4815372c79b6d62c1c85d303c6272af3df
Reviewed-on: https://gerrit.libreoffice.org/51466
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2018-03-17 19:03:02 +01:00
Mike Kaganski
daf7c3e732 basic: consistently use "" and <> in include directives 
Change-Id: I147c0e9b9b1e09af593f54799e45e1348cd40716
Reviewed-on: https://gerrit.libreoffice.org/43298
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2017-10-10 07:43:46 +02:00
Stephan Bergmann
c8fd385d61 loplugin:casttovoid: basic 
Change-Id: I4e70accf67d4d812b8998b0baa07cd04c27216ad
 2017-07-02 22:35:38 +02:00
Noel Grandin
6ee9f2c188 loplugin:oncevar accessibility..basic 
Change-Id: I8fb41b658ef0f6ad1774ea897eace3dc9bb12de6
Reviewed-on: https://gerrit.libreoffice.org/38969
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-20 07:50:06 +02:00
Takeshi Abe
9425245a87 basic: Remove strange ifdef-guard for SHARED 
Was there any platform predefining it?

Change-Id: I4c155c00272b426c0d2b1b1ec0184cc223f9e38c
Reviewed-on: https://gerrit.libreoffice.org/37461
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
 2017-05-12 03:57:08 +02:00
Justin Luth
51eb2ad7a0 VBA: accept the PtrSafe keyword 
64bit MSOffice VBA7 requires the PtrSafe Declare attribute
 #If Win64 Then
   Declare PtrSafe Function aht_apiGetOpenFileName Lib "comdlg32.dll"
 #Else
   Declare Function aht_apiGetOpenFileName Lib "comdlg32.dll"
 #End If

Accept this new keyword to enable compatibility with macros adjusted
to work in a 64bit MSOffice environment.

Change-Id: I9e64cb5339075cdda2ec91e8128fd0a35d458432
Reviewed-on: https://gerrit.libreoffice.org/34519
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
 2017-02-27 04:25:45 +00:00
Andrea Gelmini
7bc1c43800 Fix typos/translations, following 04644956e5 
No automatic tools

Change-Id: I3a6d18760f90c4ee02b9380758f97f6fca6c4428
Reviewed-on: https://gerrit.libreoffice.org/30874
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2017-02-21 13:34:20 +00:00
Noel Grandin
e5e7475feb loplugin:countusersofdefaultparams in basctl..basic 
Change-Id: I16fac3317ebf55581cb9aaef676a9759de51d695
Reviewed-on: https://gerrit.libreoffice.org/27793
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-08-04 05:46:22 +00:00
Noel Grandin
f107d45381 Convert SbxClassType to scoped enum 
Change-Id: I48afcdd9924d22b52a8db21aa253061e4d38c85b
Reviewed-on: https://gerrit.libreoffice.org/25259
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-23 11:49:32 +00:00
Andrea Gelmini
b0388ef109 Fix typo in code 
Change-Id: Ib1daf257018d5a5da90773dd39086f18666fea9f
Reviewed-on: https://gerrit.libreoffice.org/24533
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2016-05-01 09:46:58 +00:00
Stephan Bergmann
45adae8fd6 Avoid reserved identifiers 
Change-Id: Ibba1a36d4f3744fa68f7e9d0076c997e076262cb
 2016-04-06 08:31:46 +02:00
Stephan Bergmann
f7a3bdf623 Turn SbiOpcode into scoped enum 
Change-Id: I75d808dd3a42e57e7f55bad97e24fef65bb62dc6
 2016-04-06 08:31:46 +02:00
Stephan Bergmann
7beeced463 Avoid reserved identifiers 
Change-Id: I3fbc7cb107bdab770d5ce9ed3ecddb962d2d4666
 2016-04-06 08:31:46 +02:00
Noel Grandin
2d0dab5b15 loplugin:commaoperator in basic/ 
Change-Id: I320a06e50d032a55d8d5e6354959c12327e319ee
 2016-02-22 16:55:11 +02:00
Arnaud Versini
f17a4694b0 BASIC : use std::unique_ptr for storing SbiExprList 
Change-Id: I37f2a1c837c6742cf6d403962d2730b5e80004ec
Reviewed-on: https://gerrit.libreoffice.org/22345
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-02-17 07:08:59 +00:00
Arnaud Versini
7d0e520e22 BASIC : Remove class SbiDimList and SbiParameters 
Change-Id: I039bdc786a65ad534390e7138f584cdb470428af
Reviewed-on: https://gerrit.libreoffice.org/21734
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
 2016-01-24 17:43:15 +00:00
Julien Nabet
36984c75cc cppcheck: false positive deallocuse 
Help cppcheck by returning early and remove a now useless bool var

Change-Id: If4dcb6f64bcfd6c3cb22136163caf3679d6fd5a8
 2015-12-20 22:17:36 +01:00
Stephan Bergmann
08e49fa337 loplugin:nullptr (automatic rewrite) 
Change-Id: I1ec9a671fe3ac838feb36297915e3cdf8749d944
 2015-11-10 10:31:17 +01:00
Stephan Bergmann
a80bab7058 loplugin:stringconstant: elide explicit ctor usage (automatic rewrite) 
Change-Id: I9979100550a86ac3f42d74a5403fb3ffd9d5006b
 2015-11-06 09:34:39 +01:00
Andrea Gelmini
9e4c87be31 Fix typos 
Change-Id: Ie0e941d48457d758525353d6c5cf858652f86fd3
Reviewed-on: https://gerrit.libreoffice.org/18938
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2015-09-30 05:53:57 +00:00
Caolán McNamara
3a00aaef2a boost->std 
Change-Id: Ie490bf2c6921f393bdeed96b1a8815996b701bf0
Reviewed-on: https://gerrit.libreoffice.org/18670
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-09-18 07:59:14 +00:00
Noel Grandin
4f87e9da41 loplugin: defaultparams 
Change-Id: I29ef505ee77965df33677f8051ec39398ef0c74e
 2015-08-11 09:48:17 +02:00
Noel Grandin
b1c25a0d8f inline "old" SbERR constants 
Change-Id: I3e6665351de97692ae70207e8b623ad008ca8c9a
 2015-07-28 08:35:34 +02:00
Noel Grandin
9072c5c855 convert SbxFlagsBits to scoped enum 
Change-Id: I3dd699ca675be2ff4a8bfb7938bd5d43719b304c
 2015-07-28 08:35:34 +02:00
Andrea Gelmini
69c88a32aa Fix typos 
Change-Id: Ifd126a535f18db79a18aaec61b76cdf26ab33dff
Reviewed-on: https://gerrit.libreoffice.org/16522
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2015-06-28 12:28:31 +00:00
Noel Grandin
623445aa0e convert PropertyMode to scoped enum 
Change-Id: I9b0bbf6273aa18ae918d1d69af5dcc7652181f5c
 2015-06-04 08:30:24 +02:00
Noel Grandin
539ba642d7 remove unnecessary header file 
Change-Id: I3b86a54a773341be7e7e69e88c59dc531ea49c5b
 2015-05-17 10:08:59 +02:00
Michaël Lefèvre
c3cd100556 CppCheck cleanlyness : reduce variable's scope 
Change-Id: I5bd18b1a93f7197121eb42f6b82d2d8d87e7671f
Reviewed-on: https://gerrit.libreoffice.org/14843
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2015-03-12 22:28:38 +00:00
Stephan Bergmann
39ddeb53c0 basic: Use appropriate OUString functions on string constants 
Change-Id: I43f99ba6759b0f8f633af784beaec583dbab0b9e
 2014-12-18 14:12:23 +01:00
Michael Stahl
6a0fe37dec sal: clean up public headers with include-what-you-use 
Sadly cannot forward declare "struct {...} TimeValue;".

rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...

Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
 2014-11-17 11:06:53 +01:00
Noel Grandin
37b9ea92ba convert SBX flag bits to type-safe enum 
Change-Id: I18d5d6a27f06ee60a5cb3dc393bf05b51bba4817
Reviewed-on: https://gerrit.libreoffice.org/11070
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-08-26 04:30:03 -05:00
Alexandre Vicenzi
ae7ca8b957 fdo#46037: remove unused comphelper/configurationhelper.hxx 
Change-Id: I66f9d2912202ba1393d0c65189f8a945bca4fcaa
Reviewed-on: https://gerrit.libreoffice.org/10603
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2014-07-29 15:40:41 +00:00
Takeshi Abe
d97b5e420f Avoid possible memory leaks in case of exceptions 
Change-Id: Icecc2cce52d7f27c030270639e6b85877e3aa620
 2014-07-16 18:01:39 +09:00
Noel Grandin
dac4ca5f68 new loplugin: externalandnotdefined 
Find "missing headers," where a function is declared directly in the
.cxx (as extern) and not defined, and should arguably instead be declared
in an include file.

Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
 2014-07-11 14:12:25 +02:00
Caolán McNamara
5ace3f3b4f clang scan-build: various warnings 
Change-Id: I4bdfb074b3cf6fcb49765322308dfa4b9ed67713
 2014-07-01 10:56:14 +01:00
Takeshi Abe
a71ae24a23 Avoid possible memory leaks in case of exceptions 
Change-Id: Iac63a5d60478e5cd8e2b77c889c7b312d3d15f67
 2014-05-29 09:29:15 +09:00
Noel Grandin
4f9b21248f simplify ternary conditions "xxx ? yyy : false" 
Look for code like:
   xxx ? yyy : false;
Which can be simplified to:
   xxx && yyy

Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
 2014-05-05 12:47:48 +02:00
Stephan Bergmann
bd20500cf3 Simplify access to theCoreReflection singleton 
Change-Id: I9901991a320b87895230a92095c9c7d3109380a6
 2014-02-07 12:03:03 +01:00
Stephan Bergmann
f96f38f8f8 bool improvements 
Change-Id: I571354540f1ab108c55d32c20786d34a799c3bed
 2014-01-28 20:26:30 +01:00