Commit Graph

356 Commits

Author SHA1 Message Date
Stephan Bergmann
be06f3433f Some more loplugin:cstylecast: xmlscript
Change-Id: I6c13ff51c32e0fded35d8f9124981fee1cce80ad
2015-01-20 09:06:55 +01:00
Michael Weghorn
bfe79b50bc fdo#39440 reduce scope of local variables
This addresses some cppcheck warnings.

Change-Id: If7ad3584b3124ed0b337836071af1a5bd0451d85
Reviewed-on: https://gerrit.libreoffice.org/13972
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-19 08:39:32 +00:00
Caolán McNamara
fd1372ba8b boost::unordered_map->std::unordered_map
you can get debug stl this way

Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2015-01-02 16:14:36 +00:00
Stephan Bergmann
eabf036cfe xmlscript: Use appropriate OUString functions on string constants
Change-Id: I1fafba17c590d4485f2138e2dda877344c573df1
2014-12-18 14:12:39 +01:00
Michael Stahl
15b4ab8d19 cppuhelper: clean up public headers with include-what-you-use
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-18 18:51:49 +01:00
Michael Stahl
6a0fe37dec sal: clean up public headers with include-what-you-use
Sadly cannot forward declare "struct {...} TimeValue;".

rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...

Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-17 11:06:53 +01:00
Brij Mohan Lal Srivastava
d32be3ace8 fdo#86023 - O[U]String needs a 'clear' method
Added clear() method to OString and OUString class, Updated appropriate call-sites.

Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-14 09:20:38 +01:00
Noel Grandin
705c48d32e fdo#38835 strip out OUString globals
they are largely unnecessary these days, since our OUString infrastructure
gained optimised handling for static char constants.

Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-05 08:44:19 +02:00
Andrea Gelmini
0c0e3e7539 Fixed typos. No automatic tools (sed, and so on).
Change-Id: Ia43976d84eede6f699381bc4f3daf89b95e4cb4f
Reviewed-on: https://gerrit.libreoffice.org/12150
Reviewed-by: Bryan Quigley <gquigs@gmail.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-10-30 17:16:02 +00:00
Noel Grandin
0371a63365 remove unnecessary 'using namespace rtl' declarations
It turns out that almost none of them were necessary.

Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83
Reviewed-on: https://gerrit.libreoffice.org/12133
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-29 11:28:54 +00:00
Stephan Bergmann
389beae2ff xmlscript: std::auto_ptr -> std::unique_ptr
Change-Id: I203b84180d3614a440b37af87223bbf5a6a0f21a
2014-10-01 17:35:15 +02:00
Noel Grandin
fc04f76336 fdo#82577: Handle Time
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.

Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-01 07:34:23 +00:00
Norbert Thiebaud
0439f66742 xmlscript: avoid accessing [0] of an emptry string
Change-Id: I2ad756b07418d3eb93f48374cd7de3bc3db9ce29
2014-09-12 01:45:29 +02:00
Michael Stahl
2d4b87f0c1 ODF export: don't write invalid "group-name" attribute
Radio buttons are grouped via their "form:name" attribute already.

Change-Id: I9f8b27a2904d947c3d4665495d36961e3e41d2c6
2014-08-20 16:40:14 +02:00
Noel Grandin
e2080e70fe new compilerplugin returnbyref
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
   class A {
     struct X x;
     public X* getX() { return &x; }
   }
which can be:
     public X& getX() { return x; }

Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-24 11:34:21 +02:00
Noel Grandin
dfd44d0b12 xmlscript: remove SAL_THROW macro
Change-Id: Ic830c23d8696fde323dcf67697248a84658be2bf
2014-06-05 08:17:48 +02:00
Jens Carl
626a428367 fdo#68849: Add header guards to all include files
Added header guards to files in directories xml*/*

Change-Id: Ia5dfb9ab494bfbfae7537f2d54ff11331dc8c922
Reviewed-on: https://gerrit.libreoffice.org/9539
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-05-29 09:02:51 -05:00
Julien Nabet
ac76cc7e60 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part20
Change-Id: If87cdfb2c605254f6d69baa4ca5aec09091caa68
2014-05-23 22:11:52 +02:00
Noel Grandin
e7bc3cab01 remove boilerplate in UNO Exception constructor calls
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.

Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
2014-05-23 15:06:00 +02:00
Thomas Arnhold
debe137b46 xmlscript: remove using namespace from headers
Change-Id: Ic3b355e732bcbecf020720752aadd70e0722b6f0
2014-05-22 12:50:46 +02:00
Thomas Arnhold
2bd7767d01 Resolves fdo#70681: fixincludeguards.pl: all that's left
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-15 12:50:46 +00:00
Thomas Arnhold
63dc7b1ce8 SCROLLABLEFRAME never defined 2014-04-14 12:31:47 +02:00
Stephan Bergmann
115b295812 Clean up function declarations
Change-Id: If482545f87a9b0c066f91639c55b73bee4d01b5c
2014-04-11 23:29:36 +02:00
Noel Grandin
62a4722a0d xmlscript: sal_Bool->bool
Change-Id: Ib784d23aa613dce80b786ecadb98cc2c3c278e33
2014-04-07 13:53:50 +02:00
Noel Grandin
21dcef5388 xmlscript: sal_Bool->bool
Change-Id: I5d0041283637dddeac86c50917d77c7e3d005b20
2014-03-27 13:45:07 +02:00
Stephan Bergmann
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
Caolán McNamara
1f22471174 coverity#708728 Uninitialized scalar field
Change-Id: Ic5e22da988f762641daf4cc07f3b2bd0caba36f9
2014-03-21 11:13:47 +00:00
Caolán McNamara
1287c3cd6e coverity#708730 Uninitialized scalar field
Change-Id: I464774697703b7143c3a6b0df88aa32745824394
2014-03-21 11:13:46 +00:00
Caolán McNamara
920560b6b0 coverity#708732 Uninitialized scalar field
Change-Id: I0e76926d25491f54b6552c5bc1d55c77e39318b0
2014-03-21 11:13:45 +00:00
Caolán McNamara
297183a9e4 coverity#708733 Uninitialized scalar field
Change-Id: I751be405978cfc4c13047033a71504353439145d
2014-03-21 11:13:44 +00:00
Caolán McNamara
625b276311 coverity#708734 Uninitialized scalar field
Change-Id: Icea7902268a362f35c16a22597f2c55d67eaa83e
2014-03-21 11:13:42 +00:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
Alexander Wilms
a22ae26668 Remove visual noise from xmlscript
Change-Id: Id984fe846f28eba50f0fd480dca235482d150dd9
Reviewed-on: https://gerrit.libreoffice.org/8347
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 04:28:36 -06:00
Caolán McNamara
6c594bcf6a coverity#984352 Uninitialized scalar field
Change-Id: I871fcd02f461c798520a033217e14b3caa78876e
2014-02-18 10:10:02 +00:00
Alexandre Vicenzi
f139c10fd3 fdo#54938 Convert oox, sc, vcl, svtools... to cppu::supportsService
Change-Id: I6268bc57417d53b9810c81071fbcd604e2a19507
Reviewed-on: https://gerrit.libreoffice.org/7886
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com>
2014-02-06 15:47:54 +00:00
Stephan Bergmann
ff4e258ba2 bool improvements
Change-Id: I6caec041ce671aeeb9de86ea620774fb2e28f765
2014-01-28 20:26:18 +01:00
Norbert Thiebaud
7ef3b651d0 xmlscript: include <> for external includes
Change-Id: I3921f93a5ec2d043ed25d7569297131c020c4e83
2013-11-11 22:37:26 -06:00
Marcos Paulo de Souza
ee5661ecd3 fdo#54938: Adapt supportsService implementations..
to cppu::supportsService

Change-Id: I0b03d3910f094f2183bf9859db9d5bcaf35d1f14
Reviewed-on: https://gerrit.libreoffice.org/6370
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-22 10:28:10 +00:00
Caolán McNamara
77b6b4a9c2 CID#1103755 unint members
Change-Id: Ic6961e3f18aed2f271f80c69d17a5c34a0c9fa8e
2013-10-19 19:16:32 +01:00
Takeshi Abe
c5c4ab6c54 sal_Bool to bool
Change-Id: I390b6b0d8e1c143a0d2e8f4f0a1ec80c2924942c
2013-09-25 09:05:39 +09:00
Luboš Luňák
64b993e046 finish deprecation of O(U)String::valueOf()
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.

Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21 15:10:35 +02:00
Jelle van der Waa
d812281f96 fdo#57950: Remove some chained appends in xmlscript
Change-Id: I7061f59077a75b879ad42179b839894747f5ba5b
Reviewed-on: https://gerrit.libreoffice.org/5377
Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>
2013-08-16 11:07:48 +00:00
Jelle van der Waa
4eb1232fbc fdo#62475 removed pointless comments
Change-Id: I13e7eedaa5f0f116bd01834fc6db576c39350163
Reviewed-on: https://gerrit.libreoffice.org/5348
Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>
2013-08-12 06:59:10 +00:00
Lionel Elie Mamane
3b388abc1e Adapt Dialog XML import/export code
to:
 commit 8ee69b0ba1

 fdo#67235 adapt form control code to time nanosecond API change, step 3.

Change-Id: I57b549c9c1379154173bb50463171a60ce35ca0c
2013-08-05 19:27:40 +02:00
Takeshi Abe
bddd4d4598 Mark as const
Change-Id: I2746b92b1360c3c181879a81f653c44ef609f351
2013-07-22 21:03:55 +09:00
Eike Rathke
358d1a9948 use static LanguageTag::convertTo...() for standalone conversions
If no LanguageTag instance is at hand use the static methods to convert
between BCP 47 string, Locale and MS-LangID instead of creating
temporary instances.

Change-Id: I9597f768078eb81c840e84a5db5617f26bb7dc09
2013-07-13 11:55:16 +02:00
Eike Rathke
6c88ebe9aa write bcp47 format-locale if necessary and read both
Change-Id: I82cfdd8652d1c86b701ccb0b913928c860a360d2
2013-07-12 12:32:34 +02:00
Stephan Bergmann
3af0114a29 Introduce O[U]String::toUInt32
...which has become necessary since bd60d41176
"Handle oveflow in O(U)String::toInt() functions" reduces values in the range
(SAL_MAX_INT32 .. SAL_MAX_UINT32] to zero, but some calls of toInt32(16) relied
on getting a correct (unsigned) value for the whole input range ["0" ..
"FFFFFFFF"] (see libreoffice-4-1 commit 9bf6c83367cedb7be81bf67f30d2147d26c7a8c3
"Revert overflow checks in O[U]String::toInt{32,64} again").

Audited all uses of toInt32/64 with non-decimal radix.  (There is still a TODO
comment in oox/source/helper/attributelist.cxx, and
stoc/source/typeconv/convert.cxx will still need some love and test code.)

Change-Id: Iadaca1c0e41dab553687d0ce41c20c10cd657a95
2013-06-13 17:08:36 +02:00
Noel Grandin
dcbaf7c253 remove unused componentcontext.hxx includes
Change-Id: I598926b72c5540b472f9607e2f3df134a8c50048
2013-06-05 08:13:21 +02:00
Noel Grandin
9a49980efa fdo#46808, Convert various comphelper::ComponentContext
..to regular XComponenContext

Change-Id: I08f9092ae818db5c1e37880625b83607c860680b
2013-06-05 08:13:21 +02:00