Commit Graph

182 Commits

Author SHA1 Message Date
Stephan Bergmann
b997705c07 loplugin:cstylecast: deal with remaining pointer casts
Change-Id: I2828f5fe78efffaa5dee19a3d56592d12878d956
2015-06-08 16:22:58 +02:00
Noel Grandin
d5129a9dd6 new clang plugin: loopvartoosmall
Idea from bubli - look for loops where the index variable is of such
size that it cannot cover the range revealed by examining the length
part of the condition.

So far, I have only run the plugin up till the VCL module.

Also the plugin deliberately excludes anything more complicated than a
straightforward incrementing for loop.

Change-Id: Ifced18b01c03ea537c64168465ce0b8287a42015
2015-05-28 12:49:54 +02:00
Michael Stahl
cbaca2c1ce remove unused #include awt/InvalidateStyle.hpp
Change-Id: I7ea52365157fc642401db64c3b4a40d4643d16ae
2015-05-05 15:51:09 +02:00
Michael Meeks
5d5f447e73 UnoControls, toolkit, uuoi, xmlsecurity: convert new to ::Create.
Change-Id: I7b8c7ece656589c50fb066e9fa1565fd59f930da
2015-04-16 22:21:04 +01:00
Stephan Bergmann
d246f47422 Replace remaining getCppuType et al with cppu::UnoType
Change-Id: I61a85caf1587291eaa6b999050a52c92d9e416e3
2015-04-01 08:35:13 +02:00
Noel Grandin
44790193a7 loplugin:staticfunction
Change-Id: I982ba552579019e4902ae59fddf14a6b34ba5954
2015-03-27 10:51:08 +02:00
Stephan Bergmann
3099c70b11 Fix various XServiceInfo implementations
...to match what is recorded in the .component files

Change-Id: Ie548cd37872d3b8540222201afaac73040e65c8f
2015-03-17 12:25:11 +01:00
Caolán McNamara
556373c41f V668 no sense in testing the result of new against null
Change-Id: I4a33bd92fc8448638a4bfe1eab7e5041a4c5cc39
2015-03-11 09:58:36 +00:00
Julien Nabet
5f6fcb4e7c Typos
Change-Id: Ibc378fa5f515de61bb768b4ef082638b40c94e00
2015-03-08 16:45:30 +01:00
Julien Nabet
c1b9402d49 Typos
Change-Id: I151957e415eff793e3d054050526b7d6892d28d4
2015-02-28 14:54:12 +01:00
Noel Grandin
ba233e87ef remove unnecessary parenthesis in return statements
found with
$ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;'

Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2015-02-23 09:26:58 +02:00
Andrea Gelmini
81cb993127 Fix of a few typos
Change-Id: Ib2a311f0341d165a8f9d3f7a11ec36378fd69519
Reviewed-on: https://gerrit.libreoffice.org/14373
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-02-09 16:20:09 +00:00
Noel Grandin
45ec1d9b56 brute-force find-and-remove of unused #define constants.
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
2015-01-08 10:39:36 +02:00
Stephan Bergmann
1990c75175 Daft += "\0" triggers assert
...try

GetProcessServiceManager().createInstance("stardiv.UnoControls.ProgressMonitor").addText("foo", "bar", false)

in Basic...

Change-Id: I30318c3e8e671a97b6a3fe2dd9ec03add21794ab
2014-12-16 13:31:48 +01:00
Stephan Bergmann
8502d64878 Daft "\0" triggers assert in OUString literal ctor
...try

GetProcessServiceManager().createInstance("stardiv.UnoControls.StatusIndicator")

in Basic...

Change-Id: Iafc22188feb8a1d3f1b19ac4f6e209be62a44d17
2014-12-16 13:23:19 +01:00
Michael Stahl
15b4ab8d19 cppuhelper: clean up public headers with include-what-you-use
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-18 18:51:49 +01:00
Noel Grandin
0371a63365 remove unnecessary 'using namespace rtl' declarations
It turns out that almost none of them were necessary.

Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83
Reviewed-on: https://gerrit.libreoffice.org/12133
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-29 11:28:54 +00:00
Noel Grandin
a2320eaf39 loplugin: cstylecast
Change-Id: I28443b688f8ab752162846e5cea661f26d269cad
2014-09-29 12:50:36 +02:00
Stephan Bergmann
15652daf08 UnoControls: sal_False/True -> false/true
Change-Id: If30d43a2693c6df2d483ec135efa54ccb643fdb0
2014-09-15 17:23:23 +02:00
Takeshi Abe
9bac4d413e typo: more then -> more than
Change-Id: I2e477d66f25bde7256938ccb1f95ab26add24922
2014-08-01 23:40:12 +09:00
Noel Grandin
3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
Stephan Bergmann
dc0b96639f -Werror,-Wtautological-undefined-compare
Change-Id: If546680f4c16ccd733188a65d82129ec2358017b
2014-06-10 10:53:46 +02:00
Noel Grandin
184a00b962 loplugin: inlinesimplememberfunctions
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
Julien Nabet
ac76cc7e60 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part20
Change-Id: If87cdfb2c605254f6d69baa4ca5aec09091caa68
2014-05-23 22:11:52 +02:00
Pedro Giffuni
4d878a0809 Many spelling fixes: some more files.
Attempt to clean up most but certainly not all the spelling
mistakes that found home in OpenOffice through decades.

(cherry picked from commit e62c0f54ef18a5a79b76e934834b148523c69847)

Conflicts:
	LICENSE
	NOTICE_category_b
	UnoControls/source/base/basecontainercontrol.cxx
	UnoControls/source/base/registercontrols.cxx
	UnoControls/source/controls/OConnectionPointContainerHelper.cxx
	UnoControls/source/controls/progressbar.cxx
	UnoControls/source/controls/progressmonitor.cxx
	UnoControls/source/controls/statusindicator.cxx
	UnoControls/source/inc/framecontrol.hxx

Change-Id: I882a1d640d931b4e89b2d19f3585fd35fdd320ca
2014-04-30 13:30:20 +01:00
Jan Holesovsky
e6ac6cbccf automaticly -> automatically.
Change-Id: Iae55083160eee86ac8301f272634dd3ae65fd847
2014-04-27 01:28:55 +02:00
Thomas Arnhold
8bb2ce61c0 fixincludeguards.sh: some smaller dirs
Change-Id: Ic25bd678dc299627299b22145efd7bebcf2b39d0
2014-04-19 11:10:13 +02:00
Tor Lillqvist
1e0fae45a6 Bin empty @seealso, @param, @return and @onerror metacomments
Change-Id: I6517028670a953954b31599fa3e23f4c8ee8cfc9
2014-04-06 20:00:28 +03:00
Tor Lillqvist
fdecbd4a41 Kill superfluous spacing before semicolons
Change-Id: I2c5c2c2e8c57796d147141748fb57a4c5645a96a
2014-04-06 20:00:28 +03:00
Tor Lillqvist
5814e76432 Kill superfluous vertical whitespace
Change-Id: Ieb7956acdc24d6b18939e916e33eb12dc268e778
2014-04-06 20:00:27 +03:00
Stephan Bergmann
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
Stephan Bergmann
af4b38d6e7 Remove dead code
Change-Id: I59fb7843d5c9a6cf2873b6d668d0e9dccff316d2
2014-03-25 09:15:39 +01:00
Stephan Bergmann
6303605297 UnoControls: simplify deprecated XTypeProvider.getImplementationId
Change-Id: I6ad8bb98f967d7bfa062ae24d9ff35837620a77a
2014-03-10 17:39:51 +01:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
Alexander Wilms
b06820d74c Remove visual noise from UnoControls
Change-Id: I0ffbc08cf769e39e8c3b7519e8d2e13ccbe6e3d8
Reviewed-on: https://gerrit.libreoffice.org/8331
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 06:02:19 -06:00
Alexander Wilms
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
Stephan Bergmann
8bcb8b187e UnoControls: sal_Bool -> bool
Change-Id: Ic548cf07fe115c101771999a0dc8d370e57cd3ab
2014-02-18 08:18:29 +01:00
Alexandre Vicenzi
064c628842 fdo#63154 Remove unused solar.h ref in vcl, basctl, desktop..
Change-Id: Ic0187495d8f7f64ddf9d3c202ec41201c9ac3a8c
Reviewed-on: https://gerrit.libreoffice.org/8001
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com>
2014-02-12 07:23:09 +00:00
Stephan Bergmann
612dac063a bool improvements
Change-Id: I0dc09b7a6ee2849bd0c2ffc31be45f81cd2c15ee
2014-01-29 11:08:32 +01:00
Stephan Bergmann
bbd9668d5f bool improvements (related to mixing bool/sal_Bool in &=, |=, ^=)
Change-Id: I9869d9709f28b68ef7b518527175589d80644668
2014-01-22 15:00:54 +01:00
Stephan Bergmann
d706527fd8 bool improvements
Change-Id: I24fae431d9e2b99cd6ac937956bb401ecfebc943
2014-01-21 18:24:04 +01:00
Stephan Bergmann
2dde51e172 Remove odd service names (that duplicate type names)
Looks like no code instantiated these via those odd service names (except for
ProgressMonitor/StatusIndicator instantiating ProgressBar via odd
"com.sun.star.awt.XProgressBar" service name until that got cleaned up in the
previous commit).

Also looks like no code instantiates them via their implementation names either
(in which case ProgressBar/ProgressMonitor/StatusIndicator would be dead code),
but maybe there is code that dynamically constructs those implemenation names
and calls creeateInstance on them?  So best leave the implementations in for
now...

Change-Id: I20b92345e343b1f776387f63d9b02a5b0a47fe21
2013-12-19 18:00:36 +01:00
Stephan Bergmann
f8db395a8a Clean up UnoControls/source/controls/ further
...and create ProgressBar directly in ProgressMonitor/StatusIndicator, instead
of going via service manager.

Change-Id: I798e0c415c113cfc65d70ed17cb16aafded41a6d
2013-12-19 18:00:35 +01:00
Stephan Bergmann
914a00a13c Clean up macro madness
Change-Id: I353a161fdc274a3da5ac965df12379c0d65681a4
2013-12-19 16:34:54 +01:00
Caolán McNamara
669c282fea embedded nulls in literals
these used to be used with OUString::createFromAscii so a blank
string is fine here

Change-Id: I744d2be5471fad2675741f908e1ad78f0d5eefbc
2013-12-17 20:28:18 +00:00
Stephan Bergmann
8233226fe4 No need for implbase1.hxx to include XComponentContext.hpp
...which it did unlike all the other implbaseN.hxx.  Required lots of downstream clean-up,
of course.

Change-Id: Ib720e7a0a43410dcd7e6338b84a3973dfbb20866
2013-12-17 17:32:58 +01:00
Thomas Arnhold
f762dad2e7 fdo#46374 replace stardiv in comments where applicable
Change-Id: Icd07fba84735325408741ad10864c63ea32a6481
2013-10-04 15:06:23 +02:00
Noel Grandin
96bd18f692 fdo#67213 - crash on opening AutoText dialog (Ctrl+F3
Revert "fdo#46808, Convert frame::FrameControl service to new style"
This reverts commit 32eaa77db3.
Conflicts:
	UnoControls/source/controls/framecontrol.cxx
	UnoControls/source/inc/framecontrol.hxx

.. because I can't work out how it causes fdo#67213 - I suspect my
changes might be interacting with UNO aggregation, which
is always tricky.

Change-Id: Icd14f9a7df98585393c5527a3817e05c26246de9
2013-07-24 14:44:57 +02:00
Noel Grandin
a25778abd8 fix warning
"-Werror=unused-macros" was firing on non-debug builds, fix by inlining
the relevant warning message macro.

Change-Id: If2fba2410bf985ec51faaa94c61b2e224fc65328
2013-07-18 13:08:53 +02:00
Noel Grandin
214a4ec9ce fix windows build
which I broke in 32eaa77
"fdo#46808, Convert frame::FrameControl service to new style"

Change-Id: Ie7cd26714f2d6cb0e767439a2b1d4832cfc74a4a
2013-07-18 11:38:31 +02:00