mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
376,254 Commits 1 Branch 0 Tags
07d85c44998f42545175ee77c192b901b52a30ca
Commit Graph

111 Commits

Author SHA1 Message Date
Julien Nabet
b226928c6d cppcheck: redundantCondition [part1] 
Change-Id: I21c5340e7b5ec09248b08aa76f43acf883c56cd8
 2015-06-14 12:17:55 +02:00
Noel Grandin
e0b2e6e3f7 loplugin:loopvartoosmall 
Change-Id: Icbe68b31d4ab04ca3cd9f572e3598413946a75c7
 2015-05-29 08:48:41 +02:00
Philippe Jung
1379e2feaa Rewrite all calls like Dialog(params).Execute() 
Replace all calls looking like
  ADialog(some params).Execute()
by
  ScopedVclPtrInstance<ADialog>::Create(some parms)->Execute()

Change-Id: I0b6f0a9ea5ef0a749ffa30ce131e9dc989604639
Reviewed-on: https://gerrit.libreoffice.org/15915
Tested-by: Jenkins <ci@libreoffice.org>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
 2015-05-28 08:44:31 +00:00
Stephan Bergmann
9bb254fc85 NOINSTANCE is implied now in IMPL_STATIC_LINK... 
Change-Id: Ifb032457d6c1b279c4183282ef2b271c706dd71a
 2015-05-10 11:25:47 +02:00
Stephan Bergmann
4a760a8d0b Replace IMPL_STATIC_LINK[_TYPED] with more useful variants 
Change-Id: Ic59c2c9079dce37ad76b6a1396a719d372253674
 2015-05-10 11:25:42 +02:00
Stephan Bergmann
e6c08b6b30 Remove unnecessary STATIC_LINK macro 
Change-Id: I4788824667c8e0d1d4e0717b7ae7737bb0fd2c90
 2015-04-29 18:29:59 +02:00
Noel Grandin
d320bc8a6f calling static member function through member call syntax 
Change-Id: I29e8faa03f668a7471b47e7aca3c2400f034c3b6
 2015-04-14 15:14:36 +02:00
Michael Meeks
e985155bc5 Misc. other fixing. 
Change-Id: Iffdb9951daaf38489f6b788e07d9b14256459fd4
 2015-04-10 19:33:50 +01:00
Michael Meeks
cf13f78703 Lost more cleanup and fixing post re-basing. 
Change-Id: Ia5317b93484d31af978a5276bc6697848130225d
 2015-04-10 18:36:40 +01:00
Noel Grandin
3bf4ada33f dialogs lifetimes should be wrapped in ScopedVclPtr 
Change-Id: Ica8467af599fb3f9313bfa916fec8b7792a6000f
 2015-04-10 15:51:48 +02:00
Michael Meeks
8a65284fe3 Automated conversion of VclPtr construction to use Instance template. 
Change-Id: I8be9141b9653e73ebd23a5a3d810f240c376f97e
 2015-04-10 13:40:25 +01:00
Noel Grandin
61b224f392 vclwidget: fixup locally allocated vcl::Window objects 
They need to be wrapped in ScopedVclPtr in order to be disposed properly.

Change-Id: Ib64dba353774f54711e4de7f5d15d859c6a4dc7e
 2015-04-10 12:37:44 +01:00
Noel Grandin
6d0c89123f vclwidget: fix more places that should be wrapping in VclPtr 
Change-Id: I31c9115662da2f81e1b22be91ee58e2862076b8e
 2015-04-10 11:40:50 +01:00
Noel Grandin
00f2787a4a vclwidgets: wrap all vcl::Window subclasses allocated on stack in VclPtr 
Change-Id: Ia8b0d84bbf69f9d8f85505d019acdded14e25133

Conflicts:
	sw/qa/tiledrendering/tiledrendering.cxx
 2015-04-09 22:17:00 +01:00
Noel Grandin
4e6410ba01 loplugin:constantfunction: unotools 
Change-Id: Icf543973dc9edde270016c8af7e4c08c57eff650
 2015-03-19 10:45:00 +02:00
Caolán McNamara
938caeaf58 cppcheck: cstyleCast 
Change-Id: I3a1aaafe30f13f2eb388f7db3d78ecafaf0a4a2d
 2015-03-09 16:27:47 +00:00
Michael Weghorn
3338f47918 reduce scope of local variables 
This eliminates some of the warnings from Cppcheck report of
2014-11-29.

Change-Id: Id5bf885de12a6de262d2cca9fa71627ac67f50d9
Reviewed-on: https://gerrit.libreoffice.org/13330
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-12-08 08:01:58 +00:00
Andrea Gelmini
4758ab313d Removed useless includes in basctl/source/basicide/ tree 
It compiles on Windows and Linux, here, with flags:
   --with-help --with-java --with-lang="it"
Made with the ignorant brute force of removing each include
one by one.
The tree with each commit (used to bisect) it's here:
https://github.com/Gelma/core/commits/gr_push_brute_force_slot_2

Conflicts:
	basctl/source/basicide/bastype2.cxx

Change-Id: If88eebb6ecba6ae7ab1e98713b66b10f1ad57dca
Reviewed-on: https://gerrit.libreoffice.org/12963
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-12-05 09:12:26 +00:00
Noel Grandin
50a8c89f36 loplugin: cstylecast 
Change-Id: I9134aff4f2e6bff43ebb78c605e0ff521eac6ffc
 2014-10-23 12:36:14 +02:00
Noel Grandin
827c46e7d7 fdo#82577: Handle Window 
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.

Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
 2014-09-23 14:11:39 +03:00
Noel Grandin
37b9ea92ba convert SBX flag bits to type-safe enum 
Change-Id: I18d5d6a27f06ee60a5cb3dc393bf05b51bba4817
Reviewed-on: https://gerrit.libreoffice.org/11070
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-08-26 04:30:03 -05:00
Caolán McNamara
a107bdfdfc ErrorBox->MessageDialog 
Change-Id: I57d4e43460e40d3aff54873280eddbb18c12446b
 2014-08-18 10:57:21 +01:00
Caolán McNamara
2d4c90e82e coverity#736990 Uncaught exception 
Change-Id: I3b7f4c732a5a3369c05c75ede1580b32837be671
 2014-04-25 20:19:11 +01:00
Alexander Wilms
0ce0c369aa Remove unneccessary comments 
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-23 03:38:49 +00:00
Stephan Bergmann
aef614d093 auto_ptr -> scoped_ptr 
Change-Id: I19fbc4f6e0fb0d53a72759e5faf9c86c595e8e17
 2014-02-07 18:43:31 +01:00
Norbert Thiebaud
cde4fdb2d0 basctl: include <> for external includes 
Change-Id: I1897c587c02c5b50e6e8a7bf70467233be871878
 2013-11-11 22:37:25 -06:00
Noel Grandin
9a5997374f convert basctl module from String to OUString 
Change-Id: Iac38d4fd5d1d8b5c305bbb20eb1b40a7c7dec9bf
 2013-10-01 10:08:40 +02:00
Caolán McNamara
81202ae748 Related: fdo#38838 remove UniString::CompareIgnoreCaseToAscii 
Change-Id: I4a9b34d63d2534a35aa9a878b8c2bec15262c2be
 2013-09-22 20:32:02 +01:00
Noel Grandin
6f2adb1a04 convert basctl/source/inc/basobj.hxx from String to OUString 
Change-Id: Ied011ae19ef850826f52f4ebd5a22dba0caf5d2b
 2013-09-17 09:06:16 +02:00
Caolán McNamara
5efc15f000 reduce use of UniString from ResID ctor 
Change-Id: I8d7619e7807ff2d400ec5c7fd181375130245728
 2013-07-28 16:45:48 +01:00
Noel Power
61027ca6eb improve performance switching modules in large Libraries fdo#66148 
object catalog when updated, updates ( all ) entries and was parsing
the source for every method in every module

Change-Id: Id68e3c24d597d29a86d3507a7dc20745c96dd2a2
 2013-06-27 16:39:09 +01:00
Noel Power
eebf0a6dfa Revert "tweak object catalog to improve switching modules in large Libraries" 
This reverts commit 21eeeccfa6.
 2013-06-27 16:39:09 +01:00
Noel Power
21eeeccfa6 tweak object catalog to improve switching modules in large Libraries 
object catalog when updated updates ( all ) entries and was parsing
the source for every method in every module

Change-Id: Id68e3c24d597d29a86d3507a7dc20745c96dd2a2
 2013-06-27 15:53:01 +01:00
Thomas Arnhold
c4cc63badc sal: update log areas 
Change-Id: Id7b2c7e871abf19b70f427095371c6a6c0208607
 2013-02-23 13:31:09 +01:00
Radu Ioan
e4429d43f5 fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT 
Changed some OSL_ and DBG_ to SAL_

Change-Id: I192994238b949ffc51697a356a2f49072d5cedb2
Reviewed-on: https://gerrit.libreoffice.org/1519
Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>
 2012-12-31 12:22:42 +00:00
Ricardo Montania
b29ecc914b More ::rtl::OUString cleanup in basctl 
Change-Id: If7cefe8d2e188e65a465a25a5d5f77e6daebcd17
Reviewed-on: https://gerrit.libreoffice.org/760
Reviewed-by: Olivier Hallot <olivier.hallot@alta.org.br>
Tested-by: Olivier Hallot <olivier.hallot@alta.org.br>
 2012-10-05 00:58:00 +00:00
Uray M. János
81f72a3c3a Cleanup in basctl (raw pointers) 
Lots of raw pointers have been converted to boost::scoped_ptr to reduce
the number of 'delete's and the possibility of memory leaks.
Some pointers have been converted to references, to reduce the needless
checking for nullptrs, and so simplifying the code.
Also some #define-s have been converted to C++ constants or enumerations.

Change-Id: Ifbeb78f744bac7a96c8a446ff4db90dedf85fe26
 2012-09-07 11:20:48 +02:00
Uray M. János
c20f15c1eb Basic IDE: namespace basctl 
Now all names in basctl are in namespace 'basctl'.
There were lots of names that included the word 'Basic' or 'BasicIDE' in
it, e.g. BasicIDEData, BasicDocumentEntry, BasicTreeListBox,
BasicIDEModule, IDEBaseWindow etc. This information is now stored in the
namespace name, so the names could be shortened: basctl::DocumentEntry,
basctl::TreeListBox, basctl::Module, basctl::BaseWindow etc.
Some other minor changes:
* LibInfos, LibInfoItem, LibInfoKey ->
  LibInfos, LibInfos::Item, LibInfos::Key
* The header guards are now uniformly BASCTL_FILENAME_HXX, instead of
  e.g. _FILENAME_HXX, which is undefined behaviour because of the '_'.
* namespace BasicIDE, BasicIDEGlobals, basicide -> namespace basctl
* BASICIDE_TYPE_MODULE, ... -> basctl::TYPE_MODULE, ...

Change-Id: I2a9b493562d0d8a2510d569798fbe9e1161b7c9b
Reviewed-on: https://gerrit.libreoffice.org/501
Reviewed-by: Andras Timar <atimar@suse.com>
Tested-by: Andras Timar <atimar@suse.com>
 2012-08-29 20:48:28 +00:00
Uray M. János
44861f2435 Object Catalog in Dialog Editor 
Change-Id: Ia74faa1452a4200c28fbd7c63130700df0a70b24

Object Catalog in Dialog Editor

Change-Id: I97f2e0497b0e87cf630bba16dd98f9f7d0bb86e7
 2012-08-17 13:10:15 +01:00
Uray M. János
13b9c05133 IDE: sal_Bool to bool 
Convert all occurences of sal_Bool, sal_True and sal_False in basctl
to bool, true and false -- except in prototypes of virtual function
overrides. (The virtual functions that are internal to basctl can be
and was converted.) Note that since sal_Bool and bool are implicitly
convertible to each other, for functions that take a sal_Bool (by
value), true and false can be given too.

Change-Id: Ie44740fa87f89e9fedd913840ca2b38e95e6b957
 2012-08-07 11:01:01 +03:00
Takeshi Abe
d73ef723a2 sal_Bool -> bool 
Change-Id: Id2addfc6e0c4e0b30281c9f3d22ec0624a61dab1
 2012-08-02 10:25:28 +09:00
Takeshi Abe
6e6564e606 sal_Bool -> bool 
Change-Id: Ic982c4da144ecdf7198b84b98d672ced8f1f70b6
 2012-07-31 10:18:38 +09:00
Takeshi Abe
9e65cab1e7 sal_Bool -> bool 
Change-Id: I32f56e8577264eb9d125dbe3fcba2af7a4361713
 2012-07-26 10:07:45 +09:00
Caolán McNamara
bccf34c19a ditch String::CreateFromAscii 
Change-Id: I2b482bd323ac510629c5ee31868010b7cd6ce691
 2012-07-03 21:24:35 +01:00
Thomas Arnhold
1e322b7f26 Remove last PCH traces 
Change-Id: I6b5d7422eecb90c612e76fd59a6316a4ea7a8698
 2012-06-29 09:25:12 +02:00
Michael Meeks
39669162e0 re-base on ALv2 code. 2012-06-12 17:03:23 +01:00
Caolán McNamara
8a0685d49f make ResId::toString a non-static member 
Change-Id: I756c0a19bea7b1cc0e290d9f382a04d655819bfb
 2012-04-30 11:22:09 +01:00
Takeshi Abe
b1bee56af9 calling GetChar() only once suffices 2012-04-18 00:24:17 +09:00
Noel Grandin
000bb6af72 Convert tools/table.hxx usage to std::map in Basic IDE module 2012-03-22 06:39:52 +01:00
Marcel Metz
f9e6d195db Replaced diagnore ENSURE_OR_BREAK with regular code. 2012-01-23 23:28:46 +01:00