Commit Graph

1835 Commits

Author SHA1 Message Date
Andrea Gelmini
aade27554d Fix typos
Change-Id: I60ed5eb658d50cbc7dc572facb5463b7527b4d9b
Reviewed-on: https://gerrit.libreoffice.org/16408
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-22 12:36:21 +00:00
Andrea Gelmini
9ed033917b Fix typos
Change-Id: I2297bf392a405f02be2450f4624f1c9fc0b512ce
Reviewed-on: https://gerrit.libreoffice.org/16373
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-21 19:56:13 +00:00
Stephan Bergmann
9fc05ce275 Simplify uses of OUString::replaceAll with literal arguments
Change-Id: I769cc6e11909c7f4c6394fdc4dec8a12b9a67af8
2015-06-19 11:04:17 +02:00
Stephan Bergmann
2e488d7bd3 All uses of LINE_SEP are fine with a char literal
Change-Id: I057c2d346be6a6775f01a3a32edd4fc8224271a5
2015-06-19 11:04:15 +02:00
Andrea Gelmini
ae150c6a54 Fix typos
Change-Id: Ibfa971952cd330ddf430e7e951c5c235d2ae6bd8
Reviewed-on: https://gerrit.libreoffice.org/16314
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-18 11:44:56 +00:00
Lionel Elie Mamane
ecaf1cb386 seems to be what was meant
Change-Id: Ia7b784d820249c3d75915761dac34a2aaa190c0b
Reviewed-on: https://gerrit.libreoffice.org/16358
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-18 11:35:19 +00:00
Takeshi Abe
0980095619 Replace boost::scoped_array<T> with std::unique_ptr<T[]>
This may reduce some degree of dependency on boost.
Done by running a script like:

git grep -l '#include  *.boost/scoped_array.hpp.' \
 | xargs sed -i -e 's@#include  *.boost/scoped_array.hpp.@#include <memory>@'
git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \
 | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/'

... and then killing duplicate or unnecessary includes,
while changing manually
m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx,
extensions/source/ole/unoconversionutilities.hxx, and
extensions/source/ole/oleobjw.cxx.

Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd
Reviewed-on: https://gerrit.libreoffice.org/16289
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-17 15:50:45 +00:00
Andrea Gelmini
3fa7b0b70f Fix typos
Change-Id: Id8c7cf460cba5af89891c470e1aaa61b227d356e
Reviewed-on: https://gerrit.libreoffice.org/16310
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16 11:25:13 +00:00
Andrea Gelmini
f378e723d2 Fix typos
Change-Id: I528752dfabeb31d14c350f79819b521537ab9b56
Reviewed-on: https://gerrit.libreoffice.org/16300
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16 11:14:55 +00:00
Noel Grandin
4729774b24 remove unnecessary check for null when calling delete
Idea originally from caolan.
Found using the following command:
find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;'

Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-15 14:46:41 +02:00
Noel Grandin
5a2e09989a cppcheck:redundantCondition
Change-Id: Ib8b6342d1da526df6104125ded546b3f053c448b
2015-06-15 11:56:55 +02:00
Julien Nabet
b226928c6d cppcheck: redundantCondition [part1]
Change-Id: I21c5340e7b5ec09248b08aa76f43acf883c56cd8
2015-06-14 12:17:55 +02:00
Stephan Bergmann
5041d1548a minor clean up
Change-Id: Ib4fb12e187eb4bad7da04425328d1f5cdf851654
2015-06-11 09:39:51 +02:00
Stephan Bergmann
f222de1de0 Remove unnecessary Bool2Any
(It feels better to use explicitly bool-typed css::uno::makeAny<bool>(x) rather
than implicitly typed css::uno::makeAny(x) or css::uno::Any(x), in case x is not
already of type bool.)

Change-Id: I282b3764bb207aeae9f13cc981e68e8ef2b8ab93
2015-06-10 22:40:41 +02:00
Katarina Behrens
72c7b9829d Bool2Any wants to get bool instead of sal_uInt8
which is what GetTransparency() returns. Iow, do what SvxBrushItem
does :)

Change-Id: Ief65ab75d8c0955c1ec264611a70dcc693412170
2015-06-10 17:00:55 +02:00
Katarina Behrens
321f4925a7 tdf#88055: Don't export transparent background colour as white
The fix is twofold:
1. retrieve transparency from colour in SvxBackgroundColorItem
(add QueryValue, PutValue methods, use additional memberID to
retrieve alpha channel as a bool property)
2. add CharBackTransparent bool property to Draw [text] shapes,
xmloff needs it to be able to output 'transparent' string instead of
'#XXYYZZ' colour code in ODF format

Change-Id: Id830bd18fd6da5d9a46e2a94aa254d5d2a6b7ebb
Reviewed-on: https://gerrit.libreoffice.org/16182
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-10 14:29:09 +00:00
Caolán McNamara
3d47d9d9b9 cppcheck: unreadVariable
Change-Id: Ia16c1ba6052e8cf86762be095930b7e748f4493d
2015-06-09 10:34:00 +01:00
Stephan Bergmann
cec7d0a908 loplugin:cstylecast: deal with remaining pointer casts
Change-Id: I0d15a14209768ef0292d9abdf00e8fa571cf90da
2015-06-08 16:24:44 +02:00
Andras Timar
7f4230675c tdf#90804 remove SfxFieldUnit enum
b78d881520 removed unused values
from SfxFieldUnit enum. This broke the mapping between SfxFieldUnit
and FieldUnit. In fact SfxFieldUnit was redundant.

Change-Id: I13c7e7d708c6eeab0de192f4cd110b0a23989a31
Reviewed-on: https://gerrit.libreoffice.org/16150
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-06-08 13:44:11 +00:00
Julien Nabet
c27798b200 Typo: emty->empty
Change-Id: I495ae28194da449ab1b31b2b5ec0d9e08fbcc291
2015-06-06 00:04:47 +02:00
Katarina Behrens
c1b9d61bac tdf#88276: Add slot and handlers for toolbar|sidebar buttons
those changes make getting/setting of text background colour
possible from toolbar and sidebar buttons, but likely more
handlers needs to be added to various other places in the code

Change-Id: I698ca2304399befdd63317eb8872aa3129f27637
Reviewed-on: https://gerrit.libreoffice.org/15909
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2015-06-01 17:12:21 +00:00
Matteo Casalin
69a8d81b48 sal_uInt16 to sal_Int32, and use -1 as a special case
Change-Id: Iaf90f96665781d3aa43f1f71802538f54409bd4a
2015-06-01 13:04:13 +02:00
Michael Meeks
ba81e5c6bd tdf#91702 - fix stack-based MessBox allocation.
Change-Id: I62dd164e281911d9db3de453789a5badc7cd5fd7
Reviewed-on: https://gerrit.libreoffice.org/15954
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-05-29 12:16:28 +00:00
Noel Grandin
6140ca9f1d loplugin:loopvartoosmall
Change-Id: Icb31e51575f7fffd36be73bbd87a3c5e56c3aa26
2015-05-29 08:48:41 +02:00
Michael Meeks
f849d96463 tdf#91416 - fix some incorrectly allocated VirtualDevices.
Change-Id: I9ebed313827986473c60e77b7e218b4c1b2487fe
2015-05-26 17:54:27 +01:00
Markus Mohrhard
cd2ba31246 unbreak calc again
Change-Id: I13e80fc04cb35aff9efbe63cd0096bff5d177ffa
2015-05-26 13:39:32 +02:00
Jan Holesovsky
9fadc1dc47 Global CptlSttWrd and CptlSttWord -> CapitalStartWord
Change-Id: I550456ae319a6a865f2ee951a1ddf70384ce33ef
2015-05-26 12:20:27 +02:00
Jan Holesovsky
42f0f1397a Global CptlSttSntnc -> CapitalStartSentence
Change-Id: Id428332201f14b172af1590baed6aa2a67e0557a
2015-05-26 12:20:26 +02:00
Miklos Vajna
6365469272 bCptlSttSntnc -> bCapitalStartSentence
Change-Id: Ie22198837257163fd7211e93d97d97be2bca4b64
2015-05-26 09:08:03 +02:00
Noel Grandin
204d147b8a convert SCROLL constants to scoped enum
Change-Id: I5696fa39b2d032735cea7abe039349d4f83cf68d
2015-05-26 08:30:19 +02:00
László Németh
86782d5dfc AutoCorrect: direct replacement of keywords surrounded by colons
Replacing immediately (without pressing space or enter) and
inside words, too. For example, fixing tdf#55292 – complete input
method for n-dash, m-dash – is possible now by  :--: -> n-dash,
:---: -> m-dash AutoCorrect replacements.

Change-Id: I54462d7482838523a47b844da6a84f08a1518b07
2015-05-25 05:21:30 +02:00
Noel Grandin
83eb114394 convert constants in include/vcl/settings.hxx to scoped enums
Change-Id: I2a110c017f13eca6ddbd70ef3ed195d24adef0a3
Reviewed-on: https://gerrit.libreoffice.org/15828
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-22 06:33:12 +00:00
Noel Grandin
e929194317 convert POINTER constants to scoped enum
Change-Id: Iea29ce5fd6c620535197d3ca8538335078430e19
Reviewed-on: https://gerrit.libreoffice.org/15825
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-22 06:32:35 +00:00
Takeshi Abe
7fa3d4db1d editeng: simplify code by std::none_of
Change-Id: I6fb427b4e3d1179cf9291daa7204f3892a8e271f
Reviewed-on: https://gerrit.libreoffice.org/15838
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-05-21 10:09:09 +00:00
Miklos Vajna
c6f03d6fc2 ImpEditView::SetCursorAtPoint tiled rendering: avoid partial selections
Same problem as in the previous commit, just for mouse move. Previously
when selecting "abc" with the mouse only one or zero letter got selected
as the mouse moved, now it's properly the whole afffected string.

Change-Id: I025dbd71fc02a0c93a532ca188836ffb957d6b35
2015-05-20 15:30:15 +02:00
Miklos Vajna
18e08580b6 ImpEditEngine::MoveCursor tiled rendering: avoid partial selections
Tiled rendering assumes that the whole list of selection rectangles is
sent, i.e. the information is not incremental.

With this, if the text is "abc" and you are before "a" with the cursor,
then pressing shift-rightarrow two times will result in "ab" being
selected, not just "b".

Change-Id: I70c043575d3c68d78342af0a6b78659d83b4f5f4
2015-05-20 15:30:14 +02:00
Christian Lohmaier
ab465b90f6 bin/rename-sw-abbreviations.sh
renames the most annoying abbreviations in Writer (and partially
in the shared code too).

Change-Id: I9a62759138126c1537cc5c985ba05cf54d6132d9
2015-05-20 13:05:49 +02:00
Noel Grandin
23b439a664 convert DEFAULTCONSTANT constant to scoped enum
Change-Id: I5ebd77edfa29d6c6c7acea37e826ef1d625916c3
2015-05-20 09:52:09 +02:00
Noel Grandin
3cbdf64ad5 convert DRAWMODE constants to scoped enum
Change-Id: I36cbe8057d09226f8b302963bdd94dc5600b686f
2015-05-20 09:52:08 +02:00
Katarina Behrens
b5e16d8dab Related tdf#88056: use better-fitting <text:page-name>
Implemented Regina's suggestions:
* this is a text field, therefore it belongs to text namespace
* page-name (evtl. slide-name) describes much better what this
  field really contains

This (among other changes) reverts commit 6609de8856

Change-Id: Idab3b7c291839a9137f80d325a7d3f5ef0ff2636
2015-05-18 16:51:59 +02:00
Andrea Gelmini
5b1337f7b2 tdf#62475: partial handmade fixes
Change-Id: Ib9af202c43b916b9af4b4e18db35d470a8692fe4
Reviewed-on: https://gerrit.libreoffice.org/15712
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-05-15 17:55:15 +00:00
Noel Grandin
d93915b2ae conver MENU_FLAG_ constants to scoped enum
Change-Id: I969d99fa8881cc89601696a2d8621905a82b147b
2015-05-15 10:05:02 +02:00
Noel Grandin
4f4cff08aa convert POPUPMENU_ constants to scoped enum
Change-Id: I4cdaf36581d1e1daa39929e621070d18a9996852
2015-05-15 10:05:02 +02:00
Noel Grandin
68041a0546 convert INPUTCONTEXT_ constants to scoped enum
Change-Id: I5b99e42a3e85527b27d515c468d2ed66386fc9df
2015-05-14 12:00:41 +02:00
Noel Grandin
741d9990bf convert QUICKHELP constants to scoped enum
Change-Id: Ie7302c909feb2e83b8b5e62a5e6a1f901783fb49
2015-05-14 12:00:40 +02:00
Noel Grandin
f30ce25c3c convert GRFILTER_I_FLAGS to scoped enum
Change-Id: Ic1cb9b32fe252706cd607abb2ae1fd5a00999901
2015-05-14 12:00:40 +02:00
Noel Grandin
19a32ddfd2 convert KERNING_ constants to scoped enum
Change-Id: I58031485aaa9ebdeb986a3ee0376f36a9f667947
2015-05-14 12:00:40 +02:00
Noel Grandin
3fd5f8919e convert CURSOR_DIRECTION constants to scoped enum
Change-Id: I444c61d0073b12740b55e316b2bb6e34f59dfe21
Reviewed-on: https://gerrit.libreoffice.org/15675
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-12 06:13:30 +00:00
Noel Grandin
82d68f9cbc convert COMMAND_ constants to scoped enum
Change-Id: I88e67f89dbbab0646e8f106dfeb32c6ee1bb0b95
Reviewed-on: https://gerrit.libreoffice.org/15671
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-11 12:17:42 +00:00
Stephan Bergmann
b5b73ed868 loplugin:cstylecast: nop between pointer types of exactly same spelling
Change-Id: I94230f5d0838f26173eb17401f7bf22ab126e7ef
2015-05-11 12:49:32 +02:00