Commit Graph

5054 Commits

Author SHA1 Message Date
Andrea Gelmini
ae150c6a54 Fix typos
Change-Id: Ibfa971952cd330ddf430e7e951c5c235d2ae6bd8
Reviewed-on: https://gerrit.libreoffice.org/16314
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-18 11:44:56 +00:00
Takeshi Abe
0980095619 Replace boost::scoped_array<T> with std::unique_ptr<T[]>
This may reduce some degree of dependency on boost.
Done by running a script like:

git grep -l '#include  *.boost/scoped_array.hpp.' \
 | xargs sed -i -e 's@#include  *.boost/scoped_array.hpp.@#include <memory>@'
git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \
 | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/'

... and then killing duplicate or unnecessary includes,
while changing manually
m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx,
extensions/source/ole/unoconversionutilities.hxx, and
extensions/source/ole/oleobjw.cxx.

Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd
Reviewed-on: https://gerrit.libreoffice.org/16289
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-17 15:50:45 +00:00
Andrea Gelmini
814af9f1e5 Fix typos
Change-Id: Icfb885b72d51edc886851cf503c56fa12b8f559f
Reviewed-on: https://gerrit.libreoffice.org/16309
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16 11:21:07 +00:00
Andras Timar
814867c75c more untranslatable UI strings
Change-Id: I4c02d7613743a1b11594fd96f6131219afd102ef
2015-06-15 16:40:00 +02:00
Noel Grandin
4729774b24 remove unnecessary check for null when calling delete
Idea originally from caolan.
Found using the following command:
find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;'

Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-15 14:46:41 +02:00
Noel Grandin
4ea281a3cc cppcheck:redundantAssignment
Change-Id: I1167d0ce6b6f6e48309d0551c1d2a283d79546a7
2015-06-15 13:34:14 +02:00
David Tardon
8b4b1d502c use VclPtr<>::Create
Change-Id: I4b3abbd390e7b6cb449ccd7f0fb956266fd0b5c8
2015-06-13 10:41:16 +02:00
Miklos Vajna
9eee43a887 dbaccess: gcc-4.7 error: '<::' cannot begin a template-argument list
Change-Id: I27547009862b50a1cb0244c144c46c0aadef65f3
2015-06-09 14:29:17 +02:00
Miklos Vajna
6d122985da extensions: gcc-4.7 error: '<::' cannot begin a template-argument list
Change-Id: I005d398c1c9bdcf84815340e83e826740c1fc651
2015-06-09 14:15:29 +02:00
Noel Grandin
81b954718f loplugin:unnecessaryvirtuals
Improve the plugin a little.
Create a python script to process the output.
Run it again.

Change-Id: I05c21d8a21c8f4243af739c412fda0a521f9b5f0
2015-06-09 10:06:57 +02:00
Stephan Bergmann
c278518819 loplugin:cstylecast: deal with remaining pointer casts
Change-Id: I4c3c6bfce836ddc35ba6b277e240f5ed7e652e57
2015-06-08 16:25:04 +02:00
Noel Grandin
3f72218069 Apply new VclPtr clang plugin to catch potential problems.
Omit the plugin, and sw's FrameControlsManager for now.

Change-Id: Ifb98a2e6e03a9d099efc1668305b96bd9142ca5f
Reviewed-on: https://gerrit.libreoffice.org/16117
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-06 20:26:54 +00:00
Miklos Vajna
621ab8571e abpilot: fix relative reference of embedded data source
With this, not only the MM wizard, but the address book data source
wizard can create relative references correctly.

Change-Id: Id7357dbcc4503ca69595992ee7ebd6b1234d386a
2015-06-05 16:42:04 +02:00
Miklos Vajna
3705cf8212 abpilot: refer embedded data source from doc settings
So that even if the address book data source wizard creates the embedded
data source, next time the document is loaded, we can find it.

Change-Id: Ibb11fa119fb27976437e54bed1d590cfd9863236
2015-06-04 17:49:43 +02:00
Miklos Vajna
b3f5ab7765 abpilot: embed the data source definition, if possible + requested
Change-Id: I0e70459e331995388b36c77c351bff89ece004a6
2015-06-04 15:14:23 +02:00
Miklos Vajna
b2117c98ed abpilot: store embedding preference in AddressSettings
Change-Id: I83235f79d30e5f573fee95a525b4cfe1211a24b7
2015-06-04 15:14:22 +02:00
Miklos Vajna
ef0217f24e abpilot: add checkbox to embed data source in datasourcepage
Change-Id: Iea9984af3f08ed214815b9477019695f2339a7f3
2015-06-04 15:14:22 +02:00
Noel Grandin
81610561ed uno::Sequence provides now begin and end
use begin() and end() when calling std::copy on an uno::Sequence

Inspired by commit b34b648fc3
"uno::Sequence provides now begin and end"

Change-Id: I08e8c3fd6144e77b95a26f85bc0daf6a9edeeb0b
Reviewed-on: https://gerrit.libreoffice.org/16057
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-04 06:35:44 +00:00
Stephan Bergmann
5e2fe8f2a0 loplugin:cstylecast: deal with those that are (technically) const_cast
Change-Id: I636c05a34afc857c75a35e4c6fefedbce3e99c06
2015-06-02 11:26:25 +02:00
Michael Meeks
ba81e5c6bd tdf#91702 - fix stack-based MessBox allocation.
Change-Id: I62dd164e281911d9db3de453789a5badc7cd5fd7
Reviewed-on: https://gerrit.libreoffice.org/15954
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-05-29 12:16:28 +00:00
Stephan Bergmann
f9a8dd3bbb loplugin:redundantcast: const_cast to same type
Change-Id: Ifdb1c4174b89b273dd240d3d0f542ec4a871c7e0
2015-05-29 12:04:25 +02:00
Stephan Bergmann
9155210d0a Fix Windows 64-bit build
Change-Id: Ie02b1b51463aa9d6c5e80001eb089909995d5b5b
2015-05-29 11:37:43 +02:00
Noel Grandin
49ea2258d4 loplugin:loopvartoosmall
Change-Id: I5518e40a30bdad53470cc52b59eff04ab6d873d4
2015-05-29 08:48:41 +02:00
Philippe Jung
1379e2feaa Rewrite all calls like Dialog(params).Execute()
Replace all calls looking like
  ADialog(some params).Execute()
by
  ScopedVclPtrInstance<ADialog>::Create(some parms)->Execute()

Change-Id: I0b6f0a9ea5ef0a749ffa30ce131e9dc989604639
Reviewed-on: https://gerrit.libreoffice.org/15915
Tested-by: Jenkins <ci@libreoffice.org>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-05-28 08:44:31 +00:00
David Tardon
a14d7e3b41 tdf#91671 avoid use of already disposed control
Change-Id: I9cf5feeb2fc0ea91c7684aaf8adc2809907fa5d7
2015-05-28 10:06:45 +02:00
Noel Grandin
204d147b8a convert SCROLL constants to scoped enum
Change-Id: I5696fa39b2d032735cea7abe039349d4f83cf68d
2015-05-26 08:30:19 +02:00
Noel Grandin
bb7ce3137d convert INVALIDATE constants to scoped enum
fixing a bug in Window::ImplMoveAllInvalidateRegions, and improving the
IDL docs for XWindowPeer

Change-Id: Idb774ac913945db2ac7c492c11cf86c370624c3d
2015-05-26 08:30:18 +02:00
Michael Meeks
e4097762dd Audit all PostUserEvent calls and instrument for VclPtr.
Hold a reference on the VclPtr while we're waiting for the UserEvent.

Change-Id: I55c2671ca12eb14761c6a7dffd551af71547ecbd
2015-05-25 21:38:08 +01:00
Noel Grandin
65be8fd0f7 convert WINDOW_ZORDER constants to scoped enum
Change-Id: I91a583fe7d4195ee6bc73b4854f757517b38408b
2015-05-25 10:31:35 +02:00
Noel Grandin
b419da0f53 convert SHOW constants to scoped enum
Change-Id: I2712a0901049885502cade31f9757f712048bb33
2015-05-25 10:31:35 +02:00
Noel Grandin
ac3802da9a convert WINDOW_POSSIZE constants to scoped enum
Change-Id: Id85137ffc7309a66b04132d588d289db136117b9
2015-05-22 10:37:59 +02:00
Noel Grandin
e929194317 convert POINTER constants to scoped enum
Change-Id: Iea29ce5fd6c620535197d3ca8538335078430e19
Reviewed-on: https://gerrit.libreoffice.org/15825
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-22 06:32:35 +00:00
Noel Grandin
cf991bf352 convert SWIB constants to scoped enum
Change-Id: If64368f22e748cc646a726cb962e60ad29a66df9
Reviewed-on: https://gerrit.libreoffice.org/15840
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-21 12:57:55 +00:00
Noel Grandin
25a47c5cd5 convert TEXT_DRAW constants to scoped enum
Change-Id: Ic0f7f8fa236bb478b3598ae3fd3c1b30ebbf1a01
2015-05-20 09:52:08 +02:00
Stephan Bergmann
f457f9b985 loplugin:staticmethods
Change-Id: I11dfc42c11c4a689e4bde6f511751e5fb89471ca
2015-05-18 10:42:48 +02:00
Tomaž Vajngerl
a97fc29f72 refactor scanner ext. to use RenderContext
Change-Id: I31e4ea09b3a7bd65e589481c4c128275a8a7c1b7
2015-05-18 11:22:49 +09:00
Andrea Gelmini
5b1337f7b2 tdf#62475: partial handmade fixes
Change-Id: Ib9af202c43b916b9af4b4e18db35d470a8692fe4
Reviewed-on: https://gerrit.libreoffice.org/15712
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-05-15 17:55:15 +00:00
Michael Meeks
7a7a908263 tdf#91240 - cope with state-change after dispose and dispose fixedtext.
Change-Id: Iba204fbeebbc4ea0982036159507b755cedd544e
2015-05-14 21:15:14 +01:00
Noel Grandin
facc91ab4a convert FLOATWIN_POPUPMODE constants to scoped enum
Change-Id: I744d430ef6a506977eb10b892582c8969ec27524
2015-05-13 09:25:50 +02:00
Michael Meeks
936a496467 Switch VclBuilder constructors to use VclPtr.
Change-Id: Id35a86eb52bbde6ca09a5e61a0b1a79b23be8faf
2015-05-12 09:40:38 +01:00
Michael Meeks
667910530d Revert "Switch VclBuilder constructors to use VclPtr."
Behaves oddly; not ready yet.

This reverts commit 9f016bd694.

Change-Id: I30d746eac29d1dbe78d3072b10d2e22c051e3f4e
2015-05-11 16:28:22 +01:00
Michael Meeks
9f016bd694 Switch VclBuilder constructors to use VclPtr.
Change-Id: Id35a86eb52bbde6ca09a5e61a0b1a79b23be8faf
2015-05-11 15:12:08 +01:00
Noel Grandin
82d68f9cbc convert COMMAND_ constants to scoped enum
Change-Id: I88e67f89dbbab0646e8f106dfeb32c6ee1bb0b95
Reviewed-on: https://gerrit.libreoffice.org/15671
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-11 12:17:42 +00:00
Stephan Bergmann
6dc42c82ba Use IMPL_LINK_NOARG[_TYPED] where applicable
Change-Id: I70598072c1d492e360ef46dd7b5ef5a2fa4be495
2015-05-10 12:06:16 +02:00
Stephan Bergmann
67e82c48e1 No more need for EMPTYARG in C++11
Change-Id: I8a6abc563fa80a801d1907100d0b1138d260c36e
2015-05-10 11:25:48 +02:00
Stephan Bergmann
a5e8f26a9e Replace IMPL_STATIC_LINK[_TYPED] with more useful variants
Change-Id: I1a8a07623c264154451d36b55db1986be4a6f54c
2015-05-10 11:25:43 +02:00
Michael Meeks
266ce1cd53 tdf#91052 - more macros for 'make' constructors.
Change-Id: Id05266810760f73db2daba10d1efa14aa9f88dd9
2015-05-09 21:39:57 +01:00
Stephan Bergmann
5eb6bd4db7 lopluign:staticmethods: Handle DECL_LINK
Change-Id: Ib27854a8470f3ff5b208cb949a7bd02f2a86c969
2015-05-08 19:15:32 +02:00
Stephan Bergmann
f9290d3011 Clean up checks of sal_Bool values
Change-Id: Ia05565077823d6efaeaeb35d3d80b51dd9a10d4c
2015-05-08 09:49:03 +02:00
Noel Grandin
b35828ba7d convert CONFIG_MODE constants to scoped enum
Change-Id: I1b0fb976e7bf8d7de06da0c30012e8bba1320498
2015-05-06 09:01:26 +02:00