mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
376,254 Commits 1 Branch 0 Tags
07d85c44998f42545175ee77c192b901b52a30ca
Commit Graph

3911 Commits

Author SHA1 Message Date
Andrea Gelmini
aade27554d Fix typos 
Change-Id: I60ed5eb658d50cbc7dc572facb5463b7527b4d9b
Reviewed-on: https://gerrit.libreoffice.org/16408
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2015-06-22 12:36:21 +00:00
Stephan Bergmann
9cc52266bd Try make JunitTest_chart2_unoapi sch.ChXChartAxis more robust 
...setting a new StepHelp value sometimes did not change the old value at all,
for whatever reason.

Change-Id: Id859091679bff96c1a3337bf32da42e7054cc166
 2015-06-17 16:59:26 +02:00
Noel Grandin
0c18bedb73 java: 'final static' to 'static final' 
this is the canonical order, and it makes the code easier to read

Change-Id: I272e7f1e140296e582702b6dbf77a03eefb65470
Reviewed-on: https://gerrit.libreoffice.org/16242
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Ostrovsky <david@ostrovsky.org>
 2015-06-15 08:45:19 +00:00
Noel Grandin
8b85838611 java: remove unnecessary threading 
there is no point in spawning a thread to load a document and then
waiting for the thread to finish

Change-Id: Icd5d5452471b0a50a8e3525ab2b5f32a500ebdf4
 2015-06-15 10:44:42 +02:00
Andrea Gelmini
c3c45ff7ef Fix typos 
Change-Id: Id05ea8cf8aed878bedfe73c274df3c67b64bad37
Reviewed-on: https://gerrit.libreoffice.org/16263
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-06-15 06:53:19 +00:00
Antoine Cœur
fd29a623e7 spelling 
Change-Id: I5ccbb5a2b31192cea96fbb0f4ab926af86e94c9d
Reviewed-on: https://gerrit.libreoffice.org/16223
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Philippe Jung <phil.jung@free.fr>
 2015-06-12 15:41:17 +00:00
Noel Grandin
3bd57cc2c0 java:remove more unnecessary catch/re-throw 
Change-Id: Id9a13c7f4ae0fd53c95c551544e60af44bb3fb95
Reviewed-on: https://gerrit.libreoffice.org/16203
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-06-11 12:52:06 +00:00
Noel Grandin
efd4bfa818 java:regulatize the order of 'final' and public/private 
Make the order be 'public static' or 'private static'
Just makes the code nicer to read.

Change-Id: I182424bda45a2d68642e5d04c6091d268ace1fe2
Reviewed-on: https://gerrit.libreoffice.org/16202
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-06-11 09:34:00 +00:00
Noel Grandin
754ade38dd speed up Java unit tests by removing sleeps 
and replacing them with a call to XToolkitExperimental::
processEventsToIdle

Change-Id: I9fd6cb8af43d902587186310aebe78b5a5ee6932
Reviewed-on: https://gerrit.libreoffice.org/16201
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-06-11 06:47:23 +00:00
Noel Grandin
a0ff85afd7 java:simplify boolean return expressions 
Change-Id: I18c1573b7237aab88999877eec3cea41ca211c1d
 2015-06-09 13:10:46 +02:00
Noel Grandin
12d343b0cb java:remove unused imports 
Change-Id: I47be43c4ac50ee3938dc09d0206132fa7452017c
 2015-06-09 13:10:45 +02:00
Noel Grandin
26b4f5be81 java:use System.arrayCopy to copy arrays 
instead of a for loop

Change-Id: I3fbd92c5f96970543c2da3843e54a733bf811e72
 2015-06-09 13:10:44 +02:00
Noel Grandin
9a54161189 java:Return statement in a finally block 
Change-Id: I57d9a38cbb7672033ff204567bfb2b58093db490
 2015-06-09 13:10:44 +02:00
Noel Grandin
0f2007b11b more exception handling cleanup in Java unit tests 
Change-Id: I8a826c1b31f99e8d1592f284094ff921ddac74ad
 2015-06-09 13:10:42 +02:00
Noel Grandin
cc190ef25f there is no need to synchronize createTestEnvironment 
the only caller of these methods is already synchronized

Change-Id: Icea587d71acba1eca2a97ae0138a69fa98063f50
 2015-06-09 13:10:42 +02:00
Noel Grandin
2a0dda3dfb remove some unnecessary exception wrapping in the Java tests 
Modify createTestEnvironment so that it throws Exception. This
is appropriate for unit testing.
The wrapping adds no value and the calling method already has
a catch(Exception) to handle anything.

Change-Id: I430a414f63d2cbfc3b65ecfde0285509265e5192
 2015-06-09 11:34:31 +02:00
Noel Grandin
b9dd51782c some spelling fixes, mostly in Java code 
Change-Id: Ib9d0522a1f371404ee990348712e2d196049f69f
 2015-06-08 14:06:54 +02:00
Stephan Bergmann
e19cd71556 Improve test failure diagnostics 
Change-Id: I42d5d56b3f01ef49eb62d784c1a80fbc9972f7d8
 2015-06-02 11:21:04 +02:00
Michael Stahl
deb50a2a8a remove some @author tags from suspiciously unidiomatic code 
Change-Id: I3930420fe502978f8e14a688f2eb99c74d185f7b
 2015-04-25 22:45:51 +02:00
Noel Grandin
14bc818895 java: some random small cleanups 
Change-Id: I22a5b9fa29d465a21e682279e6e88d37bd8adf93
 2015-04-20 11:18:22 +02:00
Bjoern Michaelsen
4c28e293fc also test get/setData for labelless tables 
Change-Id: I61f7eaaad92b2a7b543fbb8f16f5b695700e8073
 2015-04-14 14:21:54 +02:00
Julien Nabet
f25cae2e18 Typo: creat->create 
Change-Id: I5e57e6d506504933096f4c8e371b0ddc93c04cbd
 2015-04-04 23:08:44 +02:00
Bjoern Michaelsen
d867ab4be9 add some helpful log messages 
Change-Id: I58762fdd6efafbd4ec164f190d9aeadb9cb09f76
 2015-03-30 23:20:16 +02:00
Julien Nabet
5584d73f2d Typos 
Change-Id: I434be0034b26ac4719590238817538ecd90b8923
 2015-03-25 20:42:37 +01:00
Julien Nabet
41c99ab630 Typos 
Change-Id: Ie08a26a569b83bfe3ef4351dbb7b6e928745b95d
 2015-03-23 20:08:36 +01:00
Julien Nabet
2b347972fc Typos 
Change-Id: I64995f15e8367412f345c6505668a1c560eef1ef
 2015-03-03 22:07:23 +01:00
Julien Nabet
45aaec8206 Typo: ocured->occured 
Change-Id: Ic99caa7fc5189228b95b1f776dbc8c7ee835242e
 2015-03-01 13:38:00 +01:00
Julien Nabet
ca7f62c826 Typos 
Change-Id: Ic03fb2ee6470eac6034be13908dd9ec92cf175b6
 2015-02-26 23:03:14 +01:00
Julien Nabet
4be55ffca0 Typo: queriing->querying 
Change-Id: I9bb56396f263c73fbb22a556da32a5da7f94c3fd
 2015-02-21 14:47:18 +01:00
Julien Nabet
ffb2be24b2 Typo: curor/cusor(s)->cursor(s) 
Change-Id: I5bcb2f1a05cef4a914b20f04a1ca1d8054e14542
 2015-02-21 10:56:22 +01:00
Andrea Gelmini
81cb993127 Fix of a few typos 
Change-Id: Ib2a311f0341d165a8f9d3f7a11ec36378fd69519
Reviewed-on: https://gerrit.libreoffice.org/14373
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2015-02-09 16:20:09 +00:00
Stephan Bergmann
48f704c3e1 Revert "fdo#55997: Work around slight offset causing sc_unoapi failure" 
This reverts commit ed851f1316, the underlying
problem causing JunitTest_sc_unoapi's

> checking: [sc.ScModelObj::com::sun:⭐:sheet::XDocumentAuditing] is iface: [com.sun.star.sheet.XDocumentAuditing] testcode: [ifc.sheet._XDocumentAuditing]
> Shape Type: com.sun.star.drawing.LineShape
> LOG> Execute: refreshArrows()
> Shape Type: com.sun.star.drawing.LineShape
> Shape Type: com.sun.star.drawing.LineShape
> Method refreshArrows() finished with state OK

to fail appears to be fixed meanwhile.
 2015-02-02 16:33:20 +01:00
Stephan Bergmann
7ca657e5ee css.form.component.{CheckBox,RadioButton} DefaultState property values 
...must be in the range 0--2; avoid setting bad values from generic qadevOOo
property set tests, and throw an IllegalArgumentException if bad values do
get set.

Change-Id: Ia4a97d0fac326b3ca2ce254946dc4d418e9dd5a7
 2015-01-13 15:17:18 +01:00
Noel Grandin
c55f945e4b java: move DEFAULT_SHORT_WAIT_MS to util.utils 
so I can turn PopertyNames into an enum

Change-Id: I939a83c0962813302a3653e75976147b2300cb18
 2015-01-13 08:42:55 +02:00
Noel Grandin
b82cc80e84 java: NO_CWS_ATTACH parameter is unused 
Change-Id: I3e465987ef3dd502faecaf3c5ce151013a5bf314
 2015-01-13 08:42:55 +02:00
Noel Grandin
09330056a0 java: simplify sleeping and waiting in tests 
- remove the SHORT_WAIT test parameter, no-one is using it
- inline the various independent shortWait() methods
- use the util.utils.shortWait() utility method everywhere

Change-Id: I93cd4a2580172a1441d2ff3d390f52b9505e2721
 2015-01-12 08:36:17 +02:00
Noel Grandin
4bf4e3d407 java: no need to instantiate the AccessibilityTools object 
since all of it's methods and fields are static.

Change-Id: Ia2b652969489c5a21e01a35cda65c6e84346aac0
 2015-01-12 08:36:17 +02:00
Noel Grandin
40e48e81af java: no need to sleep quite so often 
Change-Id: I9746158dfdffafd138160c2491e57b269d04e22b
 2015-01-12 08:36:15 +02:00
Noel Grandin
3757c03fc8 java: simplify array creation 
and remove the need to worry about keeping indexes correct

Change-Id: I9a5fc00f7e28f305279b41099274c96daebebb95
 2015-01-09 15:10:51 +02:00
Noel Grandin
822b4fdee7 java: unnecessary method overrides 
these methods did nothing but call their super implementation.
found by CodePro

Change-Id: Iba40d10ca1db0b4a3b4b971cacc2f299c4d5f389
 2015-01-05 10:15:25 +02:00
Noel Grandin
93a85df24f java: simplify if statement 
found by CodePro

Change-Id: I5f7e5b75b0345a1d917638e57a7d8ad60efb1475
 2015-01-05 10:15:18 +02:00
Noel Grandin
566f16a2fd java: unnecessary imports 
found by CodePro

Change-Id: If1b75e43f81d70984422e437147048a491395b66
 2015-01-05 10:15:13 +02:00
Noel Grandin
5c7d33ade6 java: more efficient float parsing 
found by CodePro

Change-Id: I01c18ddc842fd89105fa95daaa482fba8fcb7bec
 2015-01-05 10:15:07 +02:00
Noel Grandin
8f2935a6d4 java: avoid octal literals 
found by CodePro

Change-Id: Idf67521a46d73afe2f7656bb1a9f81e755eabbdb
 2015-01-05 10:15:01 +02:00
Noel Grandin
e28151d579 java: use brackets to make difference between concat and plus 
.. more obvious
found by CodePro

Change-Id: I60b05b01819a756a07d2358e3cfe8b0d7d4436a6
 2015-01-05 10:14:55 +02:00
Noel Grandin
10039462df java: remove more dead code 
found by looking for unused parameters (in Eclipse)

Change-Id: I03cf9bc8312e59747b2d0ac153ee2fc8d76be893
 2015-01-05 09:59:03 +02:00
Noel Grandin
82257e9087 java: static fields that should be instance fields 
found by FindBugs.

Change-Id: I4f457cd8f6f28f0429fc50529c8d38d80b80c560
 2015-01-05 09:58:50 +02:00
Noel Grandin
08e8bd4eaf java: compare Strings using equals() 
not ==
Found by FindBugs.

Change-Id: I74805f1187bd623433ad097dec1015a3cf5f45ac
 2015-01-05 09:58:43 +02:00
Noel Grandin
2d82619a52 java: static fields that should not be static 
Found by FindBugs.

Change-Id: I223841f7bb8c515c9612322abc0b13e134385abd
 2014-12-19 10:41:58 +02:00
Noel Grandin
35da4ec559 java: unused imports 
Change-Id: I7866959b9ea36c81003259cd387a001e9f34f26a
 2014-12-19 10:41:57 +02:00