Takeshi Abe
0655f98565
Drop duplicate #includes
...
Change-Id: I4db77ea1de42676d9d2df70db3f2e1665a3fd983
Reviewed-on: https://gerrit.libreoffice.org/16419
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2015-06-23 10:40:00 +00:00
Jan Holesovsky
5ca1936975
rendercontext: Mass fix of using the wrong size.
...
In the paints, we must use the size of the Window for the computations, not of
the RenderContext - the RenderContext can be much bigger than the Window in
the double-buffering case.
Fixes for example the list boxes, and many others.
Change-Id: I4c7607569f88b2d097587140858d0862e54b5ea6
2015-06-23 10:32:28 +02:00
Caolán McNamara
e915c1cc1e
coverity#1307698 Uninitialized scalar field
...
Change-Id: I1229b4cdfcc741899b3ae8694e7db5d7e506ce0c
2015-06-18 16:31:01 +01:00
Andras Timar
814867c75c
more untranslatable UI strings
...
Change-Id: I4c02d7613743a1b11594fd96f6131219afd102ef
2015-06-15 16:40:00 +02:00
Noel Grandin
4729774b24
remove unnecessary check for null when calling delete
...
Idea originally from caolan.
Found using the following command:
find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;'
Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-15 14:46:41 +02:00
Zolnai Tamás
3588a04f43
tdf#89830: Ambiguous naming of character background
...
Use 'Highlighting' also on Character Dialog.
Change-Id: Ie81d25651e5998a35b4e2646089b8f2c590cfb98
2015-06-14 18:50:01 +02:00
Caolán McNamara
19053e62d1
cppcheck: noExplicitConstructor
...
Change-Id: I2d629c48b6526fa5f37174921c068e1201a897ef
2015-06-11 17:10:04 +01:00
Stephan Bergmann
f61f7609db
loplugin:cstylecast: deal with remaining pointer casts
...
Change-Id: I6449dc2ada17dbf07bba179091e9990520868a00
2015-06-08 16:27:08 +02:00
Caolán McNamara
43cc6fa1fa
Resolves: tdf#91672 Crash in base report - right click in page header section
...
Change-Id: Ie7f9abc16e07c9ef44916e0cebe67486f3583449
2015-06-08 15:20:31 +01:00
Noel Grandin
6ef9f7e202
loplugin:loopvartoosmall
...
Change-Id: Ib4def3435eab4625645c5afe3b151f9f430564ac
2015-06-02 12:09:56 +02:00
Noel Grandin
f3331f7694
convert PARENTCLIPMODE constants to scoped enum
...
Change-Id: I36a53112e75fca9208b2f91e224a7c671695509b
2015-05-28 12:47:08 +02:00
Noel Grandin
2704d45a58
tdf#91577 - CRASH: when "Report Builder" closed
...
audited commit 6d0c89123f
"vclwidget: fix more places that should be wrapping in VclPtr"
and fixed up the one place that needed it.
Change-Id: Iedb56353e6a967367f38fa847efb950acc869a93
2015-05-26 08:54:02 +02:00
Noel Grandin
204d147b8a
convert SCROLL constants to scoped enum
...
Change-Id: I5696fa39b2d032735cea7abe039349d4f83cf68d
2015-05-26 08:30:19 +02:00
Noel Grandin
bb7ce3137d
convert INVALIDATE constants to scoped enum
...
fixing a bug in Window::ImplMoveAllInvalidateRegions, and improving the
IDL docs for XWindowPeer
Change-Id: Idb774ac913945db2ac7c492c11cf86c370624c3d
2015-05-26 08:30:18 +02:00
Michael Meeks
0618863375
tdf#91577 - fix unique_ptr conversion bugs in reportdesign.
...
Change-Id: Icc94ce266d567e7aad5afb5eacf0e85699ef4107
2015-05-25 21:38:09 +01:00
Michael Meeks
e4097762dd
Audit all PostUserEvent calls and instrument for VclPtr.
...
Hold a reference on the VclPtr while we're waiting for the UserEvent.
Change-Id: I55c2671ca12eb14761c6a7dffd551af71547ecbd
2015-05-25 21:38:08 +01:00
Julien Nabet
33732900bf
Typo: m_pReportDefintionMultiPlexer -> m_pReportDefinitionMultiPlexer
...
Change-Id: I90f2119d5b43e5d6efa18561a1b04d1c0178950e
2015-05-24 23:05:59 +02:00
Noel Grandin
24600dcf31
loplugin:constantfunction
...
Change-Id: I7cb5b0c2cf9ade557173ca596ea5d42d853ff448
2015-05-22 09:59:46 +02:00
Noel Grandin
83eb114394
convert constants in include/vcl/settings.hxx to scoped enums
...
Change-Id: I2a110c017f13eca6ddbd70ef3ed195d24adef0a3
Reviewed-on: https://gerrit.libreoffice.org/15828
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-05-22 06:33:12 +00:00
Noel Grandin
e929194317
convert POINTER constants to scoped enum
...
Change-Id: Iea29ce5fd6c620535197d3ca8538335078430e19
Reviewed-on: https://gerrit.libreoffice.org/15825
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-05-22 06:32:35 +00:00
Noel Grandin
cf991bf352
convert SWIB constants to scoped enum
...
Change-Id: If64368f22e748cc646a726cb962e60ad29a66df9
Reviewed-on: https://gerrit.libreoffice.org/15840
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-05-21 12:57:55 +00:00
Noel Grandin
23b439a664
convert DEFAULTCONSTANT constant to scoped enum
...
Change-Id: I5ebd77edfa29d6c6c7acea37e826ef1d625916c3
2015-05-20 09:52:09 +02:00
Noel Grandin
10749bbf82
remove the last of the OUString #defines in header files
...
Change-Id: Id9e8ce7987e055e83b52c7024413570f262e6e8d
2015-05-19 09:42:41 +02:00
Tomaž Vajngerl
4257f4db06
fix Wundefined-bool-conversion
...
Change-Id: I99e57e3f4b3f5b9fa21cdf6bfbda4b15ce83eaac
2015-05-18 17:27:38 +09:00
Tomaž Vajngerl
e7a3eb5864
refactor remaining reportdesign classes to use RenderContext
...
Change-Id: I23d7a2153bfc0446a972651a892eba8f6dc2bc54
2015-05-18 15:55:00 +09:00
Tomaž Vajngerl
3047de0f92
refactor ViewsWindow of reportdesign to use RenderContext
...
Change-Id: I0c1c2df38894f250aa2bec6ab6532ccaca090fa9
2015-05-15 08:56:25 +09:00
Noel Grandin
82d68f9cbc
convert COMMAND_ constants to scoped enum
...
Change-Id: I88e67f89dbbab0646e8f106dfeb32c6ee1bb0b95
Reviewed-on: https://gerrit.libreoffice.org/15671
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-05-11 12:17:42 +00:00
Tomaž Vajngerl
25a0bd7b90
refactor TreeListBox to use RenderContext
...
Change-Id: I901a1f1f9732fb66718dca34c698a851e5b0d87f
2015-05-11 10:03:29 +09:00
Stephan Bergmann
6dc42c82ba
Use IMPL_LINK_NOARG[_TYPED] where applicable
...
Change-Id: I70598072c1d492e360ef46dd7b5ef5a2fa4be495
2015-05-10 12:06:16 +02:00
Stephan Bergmann
9bb254fc85
NOINSTANCE is implied now in IMPL_STATIC_LINK...
...
Change-Id: Ifb032457d6c1b279c4183282ef2b271c706dd71a
2015-05-10 11:25:47 +02:00
Caolán McNamara
b307609b18
coverity#1297234 Uncaught exception
...
Change-Id: I6ce09d3a7c77c5501608a2d1b0812c3c22ef16af
2015-05-09 17:18:35 +01:00
Stephan Bergmann
5eb6bd4db7
lopluign:staticmethods: Handle DECL_LINK
...
Change-Id: Ib27854a8470f3ff5b208cb949a7bd02f2a86c969
2015-05-08 19:15:32 +02:00
Stephan Bergmann
7df89ec7a2
Remove unnecessary includes of sot/storage.hxx from include/
...
Change-Id: I242cd126814bbebdb99ea38d9e66513189c313d9
2015-05-07 11:05:05 +02:00
Noel Grandin
bfcb2a1a75
convert DEFAULTFONT_ constants to scoped enum
...
Change-Id: Ia33e957f6cf530e2639b3c86d9482f642652cb46
2015-05-06 09:01:29 +02:00
Stephan Bergmann
b515d1f36f
Use various typed ToolBox::Set*Hdl Links
...
Change-Id: Iddfd36ae0de86fdd2d4febb2c05d1fe0c02801f0
2015-05-06 08:20:55 +02:00
Michael Stahl
cbaca2c1ce
remove unused #include awt/InvalidateStyle.hpp
...
Change-Id: I7ea52365157fc642401db64c3b4a40d4643d16ae
2015-05-05 15:51:09 +02:00
Noel Grandin
9bbfb78de4
loplugin:staticmethods
...
Change-Id: I5d02ba0db00e11af3c17eaf77ce19c635a52077f
2015-05-05 14:05:21 +02:00
Stephan Bergmann
c9b4c56811
Use typed Idle::SetIdleHdl Link
...
Change-Id: I189937950325dc4ef663f7f49cb45f38f8537de9
2015-05-05 12:05:38 +02:00
Stephan Bergmann
8cafd08278
Use typed Timer::SetTimeoutHdl Link
...
Change-Id: Iaaf0c93e5b28c0f7dbe4f02eda8beeae30708100
2015-05-05 10:21:54 +02:00
Michael Meeks
393c51cee8
Audit LoseFocus - forms, reportdesign, sc, starmath, svtools.
...
Change-Id: If7068e59c88e8c3c3bafc70f64899a26d739e331
2015-05-02 00:50:06 +02:00
Stephan Bergmann
3ead3ad52f
Gradually typed Link
...
Turn the Link class into a template abstracting over the link's argument and
return types, but provide default template arguments that keep the generic,
unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the
Link class can be updated over time.
All the related macros are duplicated with ..._TYPED counterparts, that
additionally take the RetType (except for LINK_TYPED, which manages to infer the
relevant types from the supplied Member).
(It would have been attractive to change the "untyped" LinkStubs from taking a
void* to a properly typed ArgType parameter, too, but that would cause
-fsanitize=function to flag uses of "untyped" Link::Call.)
Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
2015-04-30 10:20:00 +02:00
Tor Lillqvist
c07a3b0396
Get rid of initial :: for the svx namespace
...
Change-Id: I03e428a749bca409ebac9c142acaddafcbfeca23
2015-04-30 09:11:40 +03:00
Tor Lillqvist
d883c12556
Get rid of the initial :: for the vcl namespace
...
We used it all over the place without leading :: already anyway, even
in many files in include. So let's be consistent. In the majority of
cases, prefer the easier-on-the-eyes choice, not the "safe" one.
In those files in include where *all* existing uses of ::vcl:: indeed
used the :: prefix, there let's keep it for consistency.
Change-Id: If99cb41d3bf290d38c601d91125c3c8d935e61d0
2015-04-30 07:27:52 +03:00
Tor Lillqvist
d1ca0f4ed0
Bin some pointless comments and reduce some vertical whitespace
...
Bin pointless '// predeclarations' or '// forward declarations' comments. If
a programmer doesn't know what a forward declaration is, well, why read C++
source code?
Also bin some pointless '// end of namespace foo' comments after namespace
blocks just a handful of lines long, and some superfluous vertical whitespace.
Change-Id: I2a31c5d73d9b4de8825fb8eb9e7559dbd7303ef9
2015-04-30 06:14:12 +03:00
Noel Grandin
0a9f331de4
convert SDRMOUSE constants to scoped enum
...
Change-Id: Ia5389095683a1c012a988ed71bf769a1f25d80fb
2015-04-29 10:41:40 +02:00
Noel Grandin
1f1b9b9ff5
convert SDRINSERT constants to scoped enum
...
Change-Id: I6335e00cae161cea7ece922ecfa845c205626cd9
2015-04-29 10:41:39 +02:00
Noel Grandin
c97b81ea13
convert CTF_ constants to scoped enum
...
Change-Id: I1c8149e9fccde761bb2a5fd2cf3cddcd2d9748dd
2015-04-29 10:41:37 +02:00
Tomaž Vajngerl
6cea2e61cf
fix compile: delegate RenderContext parameter to super
...
Change-Id: I1c08e29c45d8334db52b129a957098481f3e57a4
2015-04-29 09:27:54 +09:00
Tomaž Vajngerl
f50fd9692e
mass rewrite Paint(Rect&) to Paint(RenderContext&, Rect&)
...
Change-Id: Ia1667246064d11827dbd149def15e5bf08b119b8
2015-04-29 09:19:47 +09:00
Miklos Vajna
40a7169c9f
reportdesign: fix GCC-4.7 build
...
Change-Id: Ib9c4a34c68b826d48b188c37f95a09f9a8d96301
2015-04-28 18:40:18 +02:00