Commit Graph

74 Commits

Author SHA1 Message Date
Stephan Bergmann
ac97f3388d sc: Use appropriate OUString functions on string constants
Change-Id: Ib4c0df8d7637bff7d7a45d24482fff4342169fae
2014-12-15 10:14:25 +01:00
Eike Rathke
135b8d6466 remove boolean parameter default from ScDocument::SetDirty
... and force the caller to make a decision. In fact some needed to
include empty cells.

Change-Id: I82b6ef72f7ecda6543b3cafc70f475519870b471
2014-12-03 17:49:57 +01:00
Noel Grandin
223a5b7545 loplugin: cstylecast
Change-Id: Icc349df0cb3ce45a0985c7c3c27be24ef81e8705
2014-10-28 08:11:25 +02:00
Noel Grandin
8e4dc1d760 create type-safe bitfield for sc insert/delete flags
The most important part of the change is in sc/inc/global.hxx

It creates a type-safe struct that prevents the accidental interaction
between regular integer types and the flags struct.
It also provides utility methods that make combining and testing the
flags type-safe.

Change-Id: Ibc5b20058b1655df913490682b679afd1297b36d
Reviewed-on: https://gerrit.libreoffice.org/11071
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-09-04 09:05:34 -05:00
Kohei Yoshida
300845922e fdo#79578: Properly update formulas upon change in db collection.
Update it to handle formula groups correctly.

Change-Id: I009a7fcf3d3fb17ef6951c50534ca6bc1fffc259
2014-07-28 22:08:22 -04:00
Kohei Yoshida
14d2444432 This undo class is no longer used.
Change-Id: I8c53ba5bd839a6b8c8f65f05bb2b261a5bd02dbb
2014-07-13 18:34:07 -04:00
Kohei Yoshida
5c6ee09126 fdo#81309: Adjust references during sort.
Change-Id: I2b98610f6b774400ecfaffe2905201c27fcab33f
2014-07-13 18:07:14 -04:00
Norbert Thiebaud
d92aa2f445 remove SFX_APP() macro that was a mer wrapper for SfxGetApp()
Change-Id: I480a789c767dd671775c9d70d96bf71908f21f5b
2014-06-27 17:08:04 +02:00
Markus Mohrhard
37e6631cc5 remove whitespace
Change-Id: Ib15413e73409cc33de01fa92a47b9d1237cfc4b2
2014-06-25 05:41:10 +02:00
Noel Grandin
e2080e70fe new compilerplugin returnbyref
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
   class A {
     struct X x;
     public X* getX() { return &x; }
   }
which can be:
     public X& getX() { return x; }

Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-24 11:34:21 +02:00
Markus Mohrhard
c4c51709ea whitespace cleanup in sc
Change-Id: Id1dcadcac179c52977e48a6912ce4d5fd542f60c
2014-04-06 17:19:54 +02:00
Caolán McNamara
bf83deaeca coverity#704711 Dereference after null check
Change-Id: I30e56ab58101a27acc9380031aabbac68fc74487
2014-03-02 20:08:18 +00:00
Caolán McNamara
08c8ea386f coverity#704710 Dereference after null check
Change-Id: I52ba4aed1dac93e3dbaa06cf70e690deac081b6e
2014-03-02 20:08:18 +00:00
Alexander Wilms
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
Noel Grandin
1118979789 sal_Bool->bool
Change-Id: I7e37926fc1e69da2b192a60df3b54807243c646f
2014-02-19 13:05:10 +02:00
Noel Grandin
e23b79e4fb sal_Bool->bool, and remove unused parameters
Change-Id: I55a07cbcb7f388143f115d35b20daea96d1bed5d
2014-02-19 13:05:00 +02:00
Noel Grandin
d6d922be5e sal_Bool->bool
Change-Id: Ie801378efed378a9daead57cb637a96fb51cf49a
2014-02-18 10:07:55 +02:00
Stephan Bergmann
cc2606a785 bool improvements
Change-Id: I740c0e18eefc64cb5f1da5b88ceb77289790ec37
2014-01-28 20:26:23 +01:00
Noel Grandin
c9a1165832 convert sc/.../undodat.hxx from String to OUString
Change-Id: I8bf3956d9941c005ab8c46f5e115e23b24c9c3e0
2013-10-04 08:48:51 +02:00
Norbert Thiebaud
009851223b module svl: all String and some bool and related clean-up
Change-Id: I36eb559fa58dbe75384b7119c788af0048813aed
Reviewed-on: https://gerrit.libreoffice.org/4733
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-07-07 20:00:16 +00:00
Kohei Yoshida
c008dc483f Switch to using multi_type_vector for cell storage.
The old style cell storage is no more.  Currently the code is buildable,
but crashes during unit test.

Change-Id: Ie688e22e95c7fb02b9e97b23df0fc1883a97945f
2013-06-24 16:51:25 -04:00
Luboš Luňák
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
Kohei Yoshida
8a39c27633 Let's stick with just one variant of ScDocument::GetString()...
Instead of having 3 of them.

Change-Id: I2de9b63c33b7362162a56ea391f8b68a468163fa
2013-01-30 01:20:34 -05:00
Kohei Yoshida
ecb7b8b698 Let's remove this underused bAlive flag....
It's no longer that useful in today's pivot table design.

Change-Id: I665a7707126793dfde17a2221ba563d22a59aad1
2013-01-11 23:37:11 -05:00
Michael Meeks
16155fdc39 re-base on ALv2 code. Includes:
Patches contributed by Herbert Duerr
    i#118735 prevent endless loop if vlookup/hlookup doesn't find anything
    http://svn.apache.org/viewvc?view=revision&revision=1239673

    Patches contributed by Andre Fischer
    remove lp_solver
    http://svn.apache.org/viewvc?view=revision&revision=1199180
    i#118160: Added external CoinMP library.
    http://svn.apache.org/viewvc?view=revision&revision=1233909

    Patches contributed by Armin Le-Grand
    i#118485 - Styles for OLEs are not saved.
    http://svn.apache.org/viewvc?view=revision&revision=1182166
    i#118524: apply patch, followup fixes to 118485
    http://svn.apache.org/viewvc?view=revision&revision=1186077

    Patches contributed by lihuiibm
    i#108860 - Fix range validation.
    http://svn.apache.org/viewvc?view=revision&revision=1242846
    i#118954 Chart data will lost after copy to different file
    http://svn.apache.org/viewvc?view=revision&revision=1301345

    Patches contributed by Ariel Constenla-Haile
    Fix Linux build breaker: extra qualification on member
    http://svn.apache.org/viewvc?view=revision&revision=1301591
    i#118696 - i#118697 - Fix some Sheet Tab Color API issues
    http://svn.apache.org/viewvc?view=revision&revision=1225428
    i#118697 - Fix uninitialized variable
    http://svn.apache.org/viewvc?view=revision&revision=1225859
    i#118771 - ScUndoImportTab should preserve tab background color
    http://svn.apache.org/viewvc?view=revision&revision=1230356
    i#118921 - Repaint linked sheet tab background color after updating link
    http://svn.apache.org/viewvc?view=revision&revision=1245177
    i#118927 - Undo/Redo "Update Link" does not reset sheet tab color
    http://svn.apache.org/viewvc?view=revision&revision=1245241
    i#118747 - Copy tab color when transferring sheets across documents
    http://svn.apache.org/viewvc?view=revision&revision=1230355

    Patch contributed by Oliver Rainer-Wittman
    i#118012 - methods <ScBroadcastAreaSlot::AreaBroadcast(..)> and
    <ScBroadcastAreaSlot::AreaBroadcastInRange(..)> adapt stl-container
    iteration in order to avoid destroyed iterators during iteration.
    http://svn.apache.org/viewvc?view=revision&revision=1297916

    Patches contributed by Mathias Bauer
    gnumake4 work variously
    http://svn.apache.org/viewvc?view=revision&revision=1394707
    http://svn.apache.org/viewvc?view=revision&revision=1394326
    http://svn.apache.org/viewvc?view=revision&revision=1396797
    http://svn.apache.org/viewvc?view=revision&revision=1397315

    Patch contributed by Daniel Rentz
    calc69: #i116936# fix VBA symbol Cells
    http://svn.apache.org/viewvc?view=revision&revision=1172135

    Patches contributed by leiw:
    i#118546 CPU 100% on switched off AutoCalculate with Conditional
    Formatting on date values
    http://svn.apache.org/viewvc?view=revision&revision=1301380

Re-add new function documentation. Many various cleanups.
Add missing calc66: #o11817313# also look at formula result
number format, remove redundant binaries.
2012-12-04 07:17:12 +00:00
Mathieu D
aafe2fcbcb database names are case insensitive, fdo#51309
Change-Id: Iac9ac4e48115ea09aeffa11bbd8da399266aede9
2012-11-19 14:10:37 +01:00
Stephan Bergmann
f34f7b6503 -Werror,-Wunused-private-field (various sc)
Change-Id: Ia30a2bb6b1f36304a3c420db1d28d177d429a19b
2012-09-11 17:11:11 +02:00
Philipp Riemer
9d6eedf05b removed commented out code in sc/source/ui/undo
This is a follow-up patch of 06f611210c.

Since the rebasing process is not finished yet, I submit it to
Gerrit, so that the changes are available for later when they can
be applied again to the related files.

Change-Id: I047ade3f9a6b3927ddab8b94a53113b17483c06f
Reviewed-on: https://gerrit.libreoffice.org/486
Reviewed-by: Kohei Yoshida <kohei.yoshida@gmail.com>
Tested-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2012-08-25 01:12:39 +00:00
Philipp Riemer
2ba410edd7 remove ascii-art and blank lines in sc/source/ui/undo
This is a follow-up patch to 06f611210c.

However, since the rebasing process is not done yet, I submit it to
Gerrit, so that the changes are available as soon as they can be
applied again to the related files.

Change-Id: I61292e9d893839bd2f8b18a521a30e670f80f05b
Reviewed-on: https://gerrit.libreoffice.org/484
Reviewed-by: Kohei Yoshida <kohei.yoshida@gmail.com>
Tested-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2012-08-25 01:02:53 +00:00
Philipp Riemer
98e9cc1796 fdo#39468: Translated German comments in sc/source/ui/undo
Eike and I reviewed the patch at the same time. However, he was was
faster ;-) Consequently, with this commit I include the fixes for
my remarks previously done in Gerrit as well as for Eike's comments.

This is a follow-up patch of 06f611210c.

Change-Id: I6ee721f15852e1023c8b3e4f0b580435ee52c0c6
2012-08-25 01:27:53 +02:00
Albert Thuswaldner
06f611210c Translation of comments from german in sc/source/ui/undo
Change-Id: Ic7f2233ae55f8c5505c5b325aef973b0d0c65730
Reviewed-on: https://gerrit.libreoffice.org/479
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2012-08-24 21:13:03 +00:00
Thomas Arnhold
cfda6c9a00 remove some useless comments
Change-Id: Ied223890539a3407abbed7c7135dfc3de2f2fe48
Reviewed-on: https://gerrit.libreoffice.org/429
Reviewed-by: Philipp Riemer <ruderphilipp@gmail.com>
Tested-by: Philipp Riemer <ruderphilipp@gmail.com>
2012-08-18 16:49:22 +00:00
Thomas Arnhold
d8afc8e5e9 Remove superfluous include comments
Change-Id: Ie5792855761b9be209bf3fa2cba9e6998523c982
2012-06-09 04:39:01 +02:00
Caolán McNamara
c182a75241 convert GetComment family to rtl::OUString
Change-Id: I563ab83a24ca4f839892548b350486e83dd071d3
2012-05-14 14:34:09 +01:00
Kohei Yoshida
35692c7370 ScOutlineCollection and its friends now free of ScSortedCollection.
But it's apparently broken at the moment.  I need to fix this...
2012-02-04 00:25:52 -05:00
Norbert Thiebaud
2721235724 remove include of pch header from sc 2011-11-27 13:20:15 -06:00
Kohei Yoshida
c4a3e29626 Reducing header dependency on markdata.hxx. 2011-11-23 21:32:39 -05:00
Markus Mohrhard
128947050b sal_Bool->bool in ScDocument 2011-11-07 03:26:31 +01:00
Jacek Wolszczak
8b569e74d6 Replace DBG_* with OSL_* in sc/source/ui 2011-05-27 06:03:37 +02:00
Kohei Yoshida
f30162187a Renamed dbcolect.?xx to dbdata.?xx.
That deliberately mis-spelled header name always bothered me.  Now
fixed once and for all.

For the record, the original file name was inspired by the 8-character
rule that some of the old compilers that the Hamburg guys had to use,
years and years ago.
2011-05-13 23:11:42 -04:00
Kohei Yoshida
f55cc330de Fixed the fallout of the changes in ScDBCollection. 2011-05-13 22:54:10 -04:00
Markus Mohrhard
7df4c7feac Support sheet-local anonymous database ranges.
This is for an Easy Hack to allow one autofilter per sheet, not per
document.
2011-04-01 00:11:02 -04:00
Kohei Yoshida
12343c1556 Merge commit 'ooo/DEV300_m101' into integration/dev300_m101 2011-03-10 20:21:13 -05:00
Thomas Arnhold
a6e69f8fcd Move DBG_ERROR to OSL_FAIL 2011-03-02 14:58:56 +01:00
Takeshi Abe
117066d1e9 Removed dead code 2011-03-02 03:14:31 +09:00
Mikhail Voytenko
cd42389ad6 removetooltypes01: #i112600# remove tooltypes from sc 2011-01-17 13:20:22 +01:00
Gert Faller
b9a388b78d cleaning of __EXPORT define 2010-12-11 23:25:30 +01:00
Noel Power
65389fcbb7 Merge commit 'origin/master' fix conflicts and more trailing ws
Conflicts:
	sc/source/ui/undo/undodat.cxx
	sc/source/ui/vba/excelvbahelper.cxx
	sc/source/ui/vba/vbadialog.cxx
	sc/source/ui/vba/vbahelper.cxx
	sc/source/ui/vba/vbapagesetup.cxx
2010-10-13 12:41:26 +01:00
Sebastian Spaeth
63bb42ab7d Add vim/emacs modelines to all source files
Fixes #fdo30794
Based on bin/add-modelines script (originally posted in mail
1286706307.1871.1399280959@webmail.messagingengine.com)

Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
2010-10-13 10:57:18 +02:00
Noel Power
f13fd7b138 initial commit for vba blob ( not including container_control stuff ) 2010-10-06 10:15:43 +01:00