Commit Graph

450 Commits

Author SHA1 Message Date
Andrea Gelmini
ae150c6a54 Fix typos
Change-Id: Ibfa971952cd330ddf430e7e951c5c235d2ae6bd8
Reviewed-on: https://gerrit.libreoffice.org/16314
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-18 11:44:56 +00:00
Noel Grandin
dcf6abfcdf cppcheck:unreadVariable
Change-Id: I03981ceba67280e8ed98a9add7f24b3bd958d522
2015-06-15 14:06:31 +02:00
Stephan Bergmann
bc2becdf1a loplugin:cstylecast: deal with remaining pointer casts
Change-Id: I94b2fbbb00e9772b668128f31cf08115bdfb16b5
2015-06-08 16:28:40 +02:00
Caolán McNamara
afe5672fbc cppcheck: noExplicitConstructor
Change-Id: I27c24d3284a8e0678fc5c041426b4a7e71cbd363
2015-05-27 13:54:54 +01:00
Miklos Vajna
23cba1f55f tdf#91095 svx: avoid unconditional SdrObject -> SdrObjCustomShape static_cast
Change-Id: I5ed86633e909c13f14ee382b4d9ec8f9c264df1d
2015-05-21 15:15:03 +01:00
Noel Grandin
d66f266cf2 convert SDR*ALIGN constants to scoped enum
Change-Id: I29b7b4fe1181133cbbb0bb43a1835941cf12210d
2015-04-29 10:41:39 +02:00
Noel Grandin
da9361374c convert SDRESC_ constants to scoped enum
Change-Id: I9488088d006ceae15368fae775aeebebfa7ce229
2015-04-29 10:41:39 +02:00
Noel Grandin
a38b2720a4 convert MSDFF_HANDLE_FLAGS_ constants to scoped enum
Change-Id: Ica0fe759db5ac9afca524f46ecfdb85368066403
2015-04-29 10:41:37 +02:00
Noel Grandin
e8199849a0 convert HANDLE_FLAGS constants to scoped enum
Change-Id: Ie6751bc97914e4b8ac1fe00aae41c02fff2773d9
2015-04-29 10:41:37 +02:00
Noel Grandin
b49e10f9db remove unused code
Change-Id: I1393240d8ba74388484839fb94bb82fd9d78da32
2015-04-29 10:41:37 +02:00
Noel Grandin
5df70781f3 svx: convert new to ::Create.
Change-Id: I52f589dabdedb538a4a5d0eadfa42b0d10de9b80
2015-04-17 16:33:13 +02:00
Michael Meeks
8a65284fe3 Automated conversion of VclPtr construction to use Instance template.
Change-Id: I8be9141b9653e73ebd23a5a3d810f240c376f97e
2015-04-10 13:40:25 +01:00
Michael Meeks
ed953d1842 Fix OutputDevice members / stack allocation: svx.
Change-Id: Id28aeb44b4c48fec944e21fed7a9acf9f7f8b68a
2015-04-10 12:20:00 +01:00
Stephan Bergmann
5429049e3b const_cast: convert some C-style casts and remove some redundant ones
Change-Id: Ic90647cc4da716b54b00520b683cee027a664c22
2015-03-26 15:33:38 +01:00
Noel Grandin
fba2d764d8 convert SfxPopupWindowType to enum class
Change-Id: I03813103d648c5745beab740403c7912cdff2756
2015-03-24 09:36:59 +02:00
Stephan Bergmann
d1c9e5ee53 tdf#43157: Fix format string violations in OSL_TRACE etc.
...for a 32-bit build, similar to what ee11e221d2
"tdf#43157: Fix format string violations in OSL_TRACE etc." did for a 64-bit
build

Change-Id: I05dd79ede3e66cb9ab7a33792319eb34b34c82dd
2015-03-13 18:21:36 +01:00
Stephan Bergmann
ee11e221d2 tdf#43157: Fix format string violations in OSL_TRACE etc.
...in preparation of enabling the __attribute__((format(...))) in
sal_detail_logFormat (include/sal/detail/log.h)

Change-Id: I8a859199fa11ca0f9f4f4b4b23a8ebddec955a86
2015-03-13 10:53:28 +01:00
Caolán McNamara
3744d8506e boost->std
Change-Id: I8371b942d915f777a29ca01cd0aed674db0ca853
2015-02-17 16:24:05 +00:00
Caolán McNamara
0be5d2b2f6 boost::unordered_map->std::unordered_map
Change-Id: I82f668ef72e916d2ff11df5cda2a02653999f66f
2015-01-04 11:07:58 +00:00
Zolnai Tamás
04fa50e398 Regression in rendering of flowChartPunchedTape custom shape
Regression from:
20f8006e21

It's not a good idea to create the arc first in small
resolution and scale it later, because the result won't
be smooth (e.g. in case of flowChartPunchedTape).

Both cloud and flowChartPunchedTape rendered well after
that change. It seems the problem in case of cloud
was with the arc tangent values which should be calculated
based on the ARCANGLETO's original values before scaling.

Change-Id: I0315afd0452108b6539b4b8ba271d1615810d985
2014-12-28 16:15:27 +01:00
Miklos Vajna
20f8006e21 fdo#87448 EnhancedCustomShape2d: fix handling of scaled ARCANGLETO commands
Change-Id: I7daf52a60e3fac8d9f86b464e86af60e0495fcb1
2014-12-18 19:28:19 +01:00
Radu Ioan
7528b498b6 fdo#85486 - Clean up unnecessary enumerations from xenum.hxx
Removed XLineStyle

Reviewed on:
	https://gerrit.libreoffice.org/13029

Change-Id: I583575a04988ccf932374e411672ba14a3f3cb2f
2014-11-23 18:15:44 +01:00
Michael Stahl
6a0fe37dec sal: clean up public headers with include-what-you-use
Sadly cannot forward declare "struct {...} TimeValue;".

rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...

Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-17 11:06:53 +01:00
Caolán McNamara
f075a3ad08 coverity#735623 Division or modulo by float zero
Change-Id: Ibd53687416a4e20af7ac4a1e02c54407892aa470
2014-11-04 20:44:53 +00:00
Caolán McNamara
f69067fd66 coverity#1244939 Division or modulo by float zero
and

coverity#1244938 Division or modulo by float zero

Change-Id: I128b1ac10f514285152cf189af24885460c9c5ca
2014-10-30 09:34:13 +00:00
Jan Holesovsky
31af61ea09 Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"
This reverts commit 47a2d7642d.

Conflicts:

	cui/source/tabpages/transfrm.cxx
	svx/source/svdraw/svdedtv1.cxx
	svx/source/svdraw/svdibrow.cxx
	sw/source/filter/ww1/w1filter.cxx
	tools/source/generic/rational.cxx

Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-23 18:34:39 +02:00
Jan Holesovsky
858c2a2977 Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit"
This reverts commit 582ef22d3e.

Conflicts:

	svx/source/svdraw/svdedtv1.cxx
	svx/source/svdraw/svdibrow.cxx
	sw/source/filter/ww1/w1filter.cxx

Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
2014-10-23 18:34:34 +02:00
Miklos Vajna
4332787892 nShearWink -> nShearAngle
Change-Id: I122f16783db4025b9335ed82a12f051516d98d4c
2014-10-21 08:56:29 +02:00
Noel Grandin
efa7f1a549 loplugin: cstylecast
Change-Id: Idb6337bed1c32444f9644d54eba5240f09c13ef6
2014-10-20 13:33:57 +02:00
Noel Grandin
67c9d05451 fdo#84938: replace TIB_ constants with enum
Change-Id: I435ce2331fb49e7ce9fe97bdfddfaef706759a84
Reviewed-on: https://gerrit.libreoffice.org/12023
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-20 07:16:46 +00:00
David Tardon
582ef22d3e fdo#84854 it seems long is not enough on 32 bit
Fraction used BigInt internally for computations, rational does nothing
like that.

Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-16 17:44:44 +02:00
Miklos Vajna
da77897d19 nDrehWink -> nRotationAngle
Change-Id: I33ca88f38210140931b12a05e426d1373243156e
2014-10-15 09:01:16 +02:00
Juan Picca
47a2d7642d fdo#81356: convert Fraction to boost::rational<long> - wip
* Added rational util functions used by Fraction class not
  available in the boost::rational class.
* Replaced usage of Fraction by boost::rational<long>
* Removed code that relies on:
  1. fraction.IsValid() -- rational only allow valid values, ie
     denominator() != 0
  2. rational.denominator() == 0 -- always false
  3. rational.denominator() < 0 -- always false but implementation
     detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation
* Simplified code that relies on:
  1. rational.denominator() != 0 -- always true
* BUGS EXIST because Fraction allows the creation of invalid values but
  boost::rational throws the exception boost::bad_rational

Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9
Reviewed-on: https://gerrit.libreoffice.org/11551
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2014-10-09 11:33:33 +00:00
Noel Grandin
3b34655cc5 loplugin: cstylecast
Change-Id: Id2b5b2510fb13f77592d7a0455f34ccd8a20c2d7
2014-10-06 09:21:36 +02:00
Noel Grandin
c9d4a2887c fdo#82577: Handle PolyPolygon
Put the TOOLS PolyPolygon class in the tools namespace. Avoids clash with the Windows
PolyPolygon typedef.

Change-Id: I811ecbb3d55ba4ce66e4555a8586f60fcd57fb66
2014-09-30 11:47:41 +02:00
Caolán McNamara
65277f994a Resolves: fdo#79131 crash in EnhancedCustomShapeTypeNames::Get
Change-Id: Ib21a4a1574119120f09d4ecac73b93a0f2f6739f
2014-09-29 20:41:38 +01:00
Noel Grandin
60e78fbb80 fdo#82577: Handle Font
Put the VCL Font class in the vcl namespace. Avoids clash with the X11
Font typedef.

Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-18 08:54:37 +02:00
Stephan Bergmann
148aea32a3 Consistency around SvxB3DVectorItem in svx/svx3ditems.hxx
...similar to what has been done for svx/sdtmfitm.hxx in
68969cc61a "Consistency around SdrMetricItem."

Change-Id: I7f2348d82c76f6f231e34f0dfc4b6ee6fddffe55
2014-09-01 16:46:59 +02:00
Stephan Bergmann
e5d6ae0c2e Consistency around SvxColorItem in svx/svx3ditems.hxx
...similar to what has been done for svx/sdtmfitm.hxx in
68969cc61a "Consistency around SdrMetricItem."

Change-Id: If26ab3229871d2d6a7e4e7e8f79f4cb927b96930
2014-09-01 16:16:49 +02:00
Stephan Bergmann
edf7c73d45 Consistency around SfxUInt16Item in svx/svx3ditems.hxx
...similar to what has been done for svx/sdtmfitm.hxx in
68969cc61a "Consistency around SdrMetricItem."

Change-Id: I2e467df03a34d694214e0560476cb7fd76ef0735
2014-09-01 15:18:17 +02:00
Stephan Bergmann
9f6018bb64 Consistency around SfxBoolItem in svx/svx3ditems.hxx
...similar to what has been done for svx/sdtmfitm.hxx in
68969cc61a "Consistency around SdrMetricItem."

Change-Id: I3253b4cc5657a7d6b960ee892584109d373eed3d
2014-09-01 14:46:50 +02:00
Stephan Bergmann
bb11009aba Remove unnecessary invalid downcasts
Change-Id: I04a6fa07ef4dfd2609b466c7c8ff9ba925c9683c
2014-08-25 16:11:32 +02:00
Stephan Bergmann
720ee90929 Point and Rectangle coordinates are long, not sal_Int32
Change-Id: I0f97d12f55e506af699976bf81f4dcf956195aab
2014-08-22 17:17:52 +02:00
Chris Laplante
7b33dbb253 svx: Cleanup ASCII art and useless comments
Change-Id: I5399362056276f324fd43eda05d3f606dc6f8c71
Reviewed-on: https://gerrit.libreoffice.org/11011
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-08-19 01:28:24 -05:00
Caolán McNamara
d21d5a7261 drop unnecessary shl.hxx includes
Change-Id: Ieb984987c4a4f888a563377e0500444b12f43506
2014-08-18 12:59:49 +01:00
Matteo Casalin
bc69fc451c Reserve vector capacity in advance
Change-Id: I2ee5913a274eecf86ad6bbf19b99e1fe61f0ade7
2014-08-16 21:52:32 +02:00
Matteo Casalin
47e2fd0dc8 Consistently use size_t and SAL_MAX_SIZE
Change-Id: Ibab89984ec94556ec368653b6db50c6c2e380dec
2014-08-16 21:52:32 +02:00
Joren De Cuyper
4fbd7437b1 Cleanup OUStrings in CustomShapes
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, removing stray left-over
sSecondLightDirection declaration

Change-Id: I5c7f5c956b70adad953b52be3d456775b0f5fbc1
2014-08-08 12:20:41 +02:00
Stephan Bergmann
8d023edc18 Consistency around SdrOnOffItem in svx/sdshitm.hxx
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1 "Remove unused ctors" and
68969cc61a "Consistency around SdrMetricItem."

Change-Id: Id712c222034ef807ea2d7bc459e78882e948aca6
2014-08-05 08:59:37 +02:00
Caolán McNamara
8547599e0e coverity#1209371 Division or modulo by float zero
Change-Id: I8834b81b71746daaf97f7b62d09421d5165fa707
2014-07-25 11:46:53 +01:00